GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Ensure AutoImportProviderProject can share source files with main program by andrewbranch · Pull Request #44274 · microsoft/TypeScript

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented May 26, 2021

Copy link
Copy Markdown
Member

Fixes a duplicate auto-import completions bug I noticed while working on #44295, caused by differing compiler options causing the AutoImportProviderProject not to share source files with its host Project.

It looks like those options (types, lib, and noLib) are actually misclassified as affecting module resolution, and Sheetal Nandi (@sheetalkamat) is opening a PR to fix that (extracting work from #41004). Once that’s fixed, the bug will be fixed, and I can revert the part of this PR that is actually a substantive behavior change. The primary value of this PR is structuring the config in such a way that the overriding options can be tested against sourceFileAffectingCompilerOptions and adding that test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andrew Branch (andrewbranch) added 2 commits May 26, 2021 14:11
@andrewbranch
Ensure AutoImportProviderProject can share source files with main pro…
55e10b4 
…gram
@andrewbranch
Revert package-lock change
f9c02d6
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) May 26, 2021
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 26, 2021
sheetalkamat
Sheetal Nandi (sheetalkamat) reviewed May 26, 2021
View reviewed changes
Comment thread src/server/project.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Andrew Branch (andrewbranch) added 2 commits May 26, 2021 15:54
@andrewbranch
Add back reclassified options
abb898c
@andrewbranch
Merge branch 'master' into bug/duplicate-auto-imports-sometimes
024e60d
@andrewbranch
Andrew Branch (andrewbranch) marked this pull request as ready for review May 26, 2021 23:23
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes May 26, 2021
View reviewed changes
@andrewbranch
Andrew Branch (andrewbranch) merged commit b1eaf3e into microsoft:master May 26, 2021
@andrewbranch
Andrew Branch (andrewbranch) deleted the bug/duplicate-auto-imports-sometimes branch May 26, 2021 23:47
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jun 16, 2021

Copy link
Copy Markdown
Member

Did this PR mean to reference something other than #44295?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch

Andrew Branch (andrewbranch) commented Jun 16, 2021

Copy link
Copy Markdown
Member Author

Yes, but I no longer recall what 🤔
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@andrewbranch @DanielRosenwasser @sheetalkamat @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.