GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(28491): add QF to declare missing properties by a-tarasyuk · Pull Request #44576 · microsoft/TypeScript

Conversation

@a-tarasyuk

@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Fixes #28491

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BigMacEtienne, frederikocmr, and luanxu-dev reacted with heart emoji
All reactions
  • ❤️ 3 reactions
@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 14, 2021
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) marked this pull request as ready for review June 14, 2021 16:31
@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

The TypeScript team hasn't accepted the linked issue #28491. If you can get it accepted, this PR will have a better chance of being reviewed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Jun 14, 2021
View reviewed changes
Comment thread src/services/codefixes/fixAddMissingMember.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/28491 branch from 1294517 to 8ad51df Compare June 14, 2021 19:47
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) requested a review from Daniel Rosenwasser (DanielRosenwasser) June 15, 2021 10:17
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) requested changes Jun 15, 2021
View reviewed changes

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want a bit more test coverage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tests/cases/fourslash/codeFixAddMissingProperties8.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/services/codefixes/fixAddMissingMember.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/cases/fourslash/codeFixAddMissingProperties1.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/28491 branch from 8ad51df to 5af5076 Compare June 15, 2021 18:40
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) requested a review from Daniel Rosenwasser (DanielRosenwasser) June 15, 2021 18:44
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes Jun 15, 2021
View reviewed changes
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) requested review from Andrew Branch (andrewbranch) and Wesley Wigham (weswigham) June 15, 2021 20:51
andrewbranch
Andrew Branch (andrewbranch) reviewed Jun 16, 2021
View reviewed changes
Comment thread src/services/codefixes/fixAddMissingMember.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/28491 branch from 5af5076 to 5896e3b Compare June 17, 2021 07:30
@andrewbranch

Andrew Branch (andrewbranch) commented Jun 17, 2021

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) pack this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 17, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the tarball bundle task on this PR at 5896e3b. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 17, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey Andrew Branch (@andrewbranch), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/105173/artifacts?artifactName=tgz&fileId=C607D22BDB832E857D96A8EDE1088CB00C7D84B8C315BAC7837C2B5B7FCDFACA02&fileName=/typescript-4.4.0-insiders.20210617.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch

Andrew Branch (andrewbranch) commented Jun 17, 2021

Copy link
Copy Markdown
Member

No playground link TypeScript Bot (@typescript-bot)? ☹️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
feat(28491): add QF to declare missing properties
839e72e
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feat/28491 branch from 5896e3b to 839e72e Compare June 17, 2021 17:13
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) requested a review from Andrew Branch (andrewbranch) June 17, 2021 17:17
andrewbranch
Andrew Branch (andrewbranch) approved these changes Jun 17, 2021
View reviewed changes

@andrewbranch Andrew Branch (andrewbranch) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit eee34d5 into microsoft:main Jun 17, 2021
@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) mentioned this pull request Jun 28, 2021
feat(16755): interface stubbing for anonymous implementations #44781
Merged
@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) mentioned this pull request Jul 23, 2021
Quickfix to add missing attributes/properties #45163
Closed
5 tasks done
This was referenced Oct 17, 2021
Add support for computed properties tamj0rd2/ts-quickfixes#305
Closed
Add quick fix support for all valid strings for computed properties #46402
Closed
@hpx7 Harsh Pandey (hpx7) mentioned this pull request Feb 5, 2022
Missing properties quickfix does not handle generic parameters #47746
Closed
@hpx7 Harsh Pandey (hpx7) mentioned this pull request May 6, 2022
Missing properties quickfix does not add missing imports #49001
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
@andrewbranch Andrew Branch (andrewbranch) andrewbranch approved these changes
@weswigham Wesley Wigham (weswigham) Awaiting requested review from weswigham

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Declare all missing members quick fix

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@a-tarasyuk @typescript-bot @andrewbranch @DanielRosenwasser
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.