GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||
GeezerVison is showing github.com — `moduleResolution: node12` support by weswigham · Pull Request #45884 · microsoft/TypeScript Conversation
Member
This PR is mostly just to pack up everything together for reviews over at weswigham#68 (if you're pinged as a reviewer here, go there to just review this most recent stage of development). It's also a viable PR to squash and merge to get everything merged all at once, once reviews and CI are in~
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Wesley Wigham (weswigham)
force-pushed
the
imports-exports-selfs
branch
from
cea73a2 to
093002c
Compare
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
Heya Wesley Wigham (@weswigham), I've started to run the tarball bundle task on this PR at 859abb6. You can monitor the build here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Hey Wesley Wigham (@weswigham), I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build and an npm module you can use via |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Wesley Wigham (@weswigham) i did test this beta get so support for moduleResolution |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I just tried the
See https://unpkg.com/browse/@angular/[email protected]/package.json
See https://unpkg.com/browse/[email protected]/package.json I have no idea how can it be fixed on my side. Test source codes: // worker.ts import type { ParsedTemplate } from '@angular/compiler' import { runAsWorker } from 'synckit' runAsWorker<ParsedTemplate>(async (code: string, filePath: string) => { const { parseTemplate } = await import('@angular/compiler') return parseTemplate(code, filePath, { preserveWhitespaces: true, preserveLineEndings: true, collectCommentNodes: true, }) }) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| let i = 0; | ||
| for (const name of names) { | ||
| let resolution = resolutionsInFile.get(name); | ||
| const mode = containingSourceFile ? getModeForResolutionAtIndex(containingSourceFile, i) : undefined; |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
We cannot assume that module name is referenced at index i in containing source file because we could be calling you with only few module names from the source file. https://github.com/microsoft/TypeScript/blob/main/src/compiler/program.ts#L1571 shows that case
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.