GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Correctly check computed property names in type-space get/set accessors by RyanCavanaugh · Pull Request #47156 · microsoft/TypeScript

Conversation

@RyanCavanaugh

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) commented Dec 15, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #47146 (introduced by #42425 which enabled this syntax)

Previously this code ran without error:

type OH_NO = {
  get [K in WAT](): string
};

because we incorrectly swallowed the errors in checkComputedPropertyName under the assumption that we were looking at a { [K in T]: U } declaration. The code path where the error would have been detected -- in the mapped checking logic -- obviously does not run because this is not actually a mapped type.

Thankfully the computed type was completely useless (see comments in linked issue), so it isn't feasible that anyone took a dependency on this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Ryan Cavanaugh (RyanCavanaugh) added 2 commits December 14, 2021 21:34
@RyanCavanaugh
Add test that should fail
aa6f3a3
@RyanCavanaugh
Make it fail
53170d9
Fixes microsoft#47146
@typescript-bot TypeScript Bot (typescript-bot) assigned Ryan Cavanaugh (RyanCavanaugh) Dec 15, 2021
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Dec 15, 2021
@RyanCavanaugh
Baselines
bee1a0d
@sandersn
Nathan Shively-Sanders (sandersn) requested review from Andrew Branch (andrewbranch) and Nathan Shively-Sanders (sandersn) January 31, 2022 19:37
andrewbranch
Andrew Branch (andrewbranch) approved these changes Jan 31, 2022
View reviewed changes
@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) merged commit 2172e19 into microsoft:main Feb 1, 2022
@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) deleted the fix47146 branch February 1, 2022 20:49
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch Andrew Branch (andrewbranch) andrewbranch approved these changes
@sandersn Nathan Shively-Sanders (sandersn) Awaiting requested review from sandersn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

infer on setter argument gives unknown

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@RyanCavanaugh @andrewbranch @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.