GeezerVison is showing github.com — Correctly check computed property names in type-space get/set accessors by RyanCavanaugh · Pull Request #47156 · microsoft/TypeScript
Conversation
Fixes #47146 (introduced by #42425 which enabled this syntax)
Previously this code ran without error:
type OH_NO = {
get [K in WAT](): string
};
because we incorrectly swallowed the errors in checkComputedPropertyName under the assumption that we were looking at a { [K in T]: U } declaration. The code path where the error would have been detected -- in the mapped checking logic -- obviously does not run because this is not actually a mapped type.
Thankfully the computed type was completely useless (see comments in linked issue), so it isn't feasible that anyone took a dependency on this.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.