GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add missing mapped type indexed access constraint by ahejlsberg · Pull Request #47370 · microsoft/TypeScript

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Jan 10, 2022

Copy link
Copy Markdown
Member

Fixes #47368.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
captain-yossarian reacted with thumbs up emoji quixot1c and tonivj5 reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 2 reactions
Anders Hejlsberg (ahejlsberg) added 2 commits January 10, 2022 08:36
@ahejlsberg
Type { [P in K]: E }[X] has constraint E with X substutited for P
f483738
@ahejlsberg
Add regression test
0a0b227
@typescript-bot TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg) Jan 10, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 10, 2022
@ahejlsberg
Anders Hejlsberg (ahejlsberg) requested review from Daniel Rosenwasser (DanielRosenwasser), Ryan Cavanaugh (RyanCavanaugh) and Wesley Wigham (weswigham) January 10, 2022 16:48
weswigham
Wesley Wigham (weswigham) approved these changes Jan 10, 2022
View reviewed changes
@ahejlsberg
Fix PragmaMap and ReadonlyPragmaMap declarations
8223920
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jan 10, 2022

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at 8223920. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at 8223920. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized Definitely Typed test suite on this PR at 8223920. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized community code test suite on this PR at 8223920. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jan 10, 2022

Copy link
Copy Markdown
Member Author

So, one issue I'm seeing with the new constraint rules is this:

type ArgMap = { a: { x: number }, b: { y: string } };
type Func<K extends keyof ArgMap> = (x: ArgMap[K]) => void;
type Funcs = { [K in keyof ArgMap]: Func<K> };

function ff<K extends keyof ArgMap>(x: Funcs[K], y: Funcs[keyof ArgMap]) {
    x = y;  // Error
    y = x;  // Was ok, now errors
}

This is because for type Funcs[K] we used to explore the constraint Funcs[keyof ArgMap] where we now explore the constraints Func<K> and then Func<keyof ArgMap>. We may have to explore both possibilities.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..47370

Metric main 47370 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 355,022k (± 0.01%) 355,097k (± 0.02%) +75k (+ 0.02%) 354,914k 355,318k
Parse Time 1.95s (± 0.58%) 1.95s (± 0.44%) -0.00s (- 0.20%) 1.93s 1.96s
Bind Time 0.84s (± 0.48%) 0.84s (± 0.77%) +0.00s (+ 0.12%) 0.83s 0.86s
Check Time 5.55s (± 0.36%) 5.53s (± 0.55%) -0.02s (- 0.41%) 5.45s 5.60s
Emit Time 5.89s (± 0.43%) 5.88s (± 0.62%) -0.01s (- 0.15%) 5.81s 5.99s
Total Time 14.24s (± 0.22%) 14.20s (± 0.39%) -0.04s (- 0.26%) 14.07s 14.33s
Compiler-Unions - node (v10.16.3, x64)
Memory used 204,106k (± 0.03%) 204,163k (± 0.03%) +58k (+ 0.03%) 203,992k 204,329k
Parse Time 0.79s (± 1.06%) 0.79s (± 0.78%) +0.00s (+ 0.51%) 0.78s 0.80s
Bind Time 0.52s (± 1.44%) 0.52s (± 1.12%) 0.00s ( 0.00%) 0.51s 0.53s
Check Time 7.84s (± 0.61%) 7.83s (± 0.55%) -0.02s (- 0.22%) 7.74s 7.94s
Emit Time 2.46s (± 0.76%) 2.46s (± 0.51%) -0.01s (- 0.32%) 2.42s 2.48s
Total Time 11.61s (± 0.52%) 11.59s (± 0.39%) -0.02s (- 0.16%) 11.51s 11.70s
Monaco - node (v10.16.3, x64)
Memory used 342,520k (± 0.02%) 342,511k (± 0.03%) -10k (- 0.00%) 342,201k 342,656k
Parse Time 1.48s (± 0.55%) 1.48s (± 0.79%) +0.00s (+ 0.07%) 1.44s 1.50s
Bind Time 0.74s (± 0.49%) 0.74s (± 0.67%) +0.00s (+ 0.13%) 0.74s 0.76s
Check Time 5.51s (± 0.64%) 5.50s (± 0.52%) -0.01s (- 0.22%) 5.46s 5.56s
Emit Time 3.21s (± 0.58%) 3.23s (± 1.04%) +0.02s (+ 0.53%) 3.15s 3.29s
Total Time 10.94s (± 0.35%) 10.95s (± 0.13%) +0.00s (+ 0.05%) 10.92s 10.98s
TFS - node (v10.16.3, x64)
Memory used 305,618k (± 0.02%) 305,590k (± 0.03%) -28k (- 0.01%) 305,408k 305,819k
Parse Time 1.19s (± 0.64%) 1.20s (± 0.37%) +0.00s (+ 0.25%) 1.19s 1.21s
Bind Time 0.71s (± 0.82%) 0.70s (± 0.68%) -0.00s (- 0.57%) 0.69s 0.71s
Check Time 5.04s (± 0.37%) 5.03s (± 0.60%) -0.01s (- 0.18%) 4.97s 5.10s
Emit Time 3.39s (± 1.00%) 3.34s (± 1.12%) -0.04s (- 1.33%) 3.24s 3.42s
Total Time 10.33s (± 0.41%) 10.27s (± 0.53%) -0.06s (- 0.58%) 10.12s 10.40s
material-ui - node (v10.16.3, x64)
Memory used 471,416k (± 0.02%) 471,422k (± 0.02%) +6k (+ 0.00%) 471,182k 471,618k
Parse Time 1.76s (± 0.39%) 1.76s (± 0.27%) -0.00s (- 0.06%) 1.75s 1.77s
Bind Time 0.66s (± 1.01%) 0.66s (± 0.88%) -0.00s (- 0.45%) 0.65s 0.67s
Check Time 14.23s (± 0.81%) 14.21s (± 0.35%) -0.02s (- 0.12%) 14.10s 14.30s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.66s (± 0.74%) 16.63s (± 0.28%) -0.02s (- 0.13%) 16.52s 16.72s
xstate - node (v10.16.3, x64)
Memory used 572,928k (± 1.40%) 576,374k (± 1.83%) +3,446k (+ 0.60%) 569,081k 604,902k
Parse Time 2.55s (± 0.29%) 2.55s (± 0.40%) -0.00s (- 0.16%) 2.52s 2.56s
Bind Time 1.00s (± 0.49%) 1.00s (± 0.50%) +0.00s (+ 0.10%) 1.00s 1.02s
Check Time 1.49s (± 0.59%) 1.49s (± 0.51%) +0.00s (+ 0.07%) 1.48s 1.51s
Emit Time 0.07s (± 3.14%) 0.07s (± 3.14%) 0.00s ( 0.00%) 0.07s 0.08s
Total Time 5.11s (± 0.25%) 5.11s (± 0.20%) 0.00s ( 0.00%) 5.09s 5.14s
Angular - node (v12.1.0, x64)
Memory used 332,867k (± 0.03%) 332,852k (± 0.03%) -15k (- 0.00%) 332,583k 333,036k
Parse Time 1.95s (± 0.52%) 1.95s (± 0.71%) -0.00s (- 0.26%) 1.93s 1.99s
Bind Time 0.82s (± 1.00%) 0.82s (± 0.86%) +0.00s (+ 0.24%) 0.81s 0.84s
Check Time 5.35s (± 0.50%) 5.34s (± 0.34%) -0.00s (- 0.07%) 5.29s 5.37s
Emit Time 6.12s (± 0.92%) 6.10s (± 0.56%) -0.02s (- 0.34%) 6.03s 6.18s
Total Time 14.23s (± 0.39%) 14.21s (± 0.35%) -0.03s (- 0.18%) 14.07s 14.31s
Compiler-Unions - node (v12.1.0, x64)
Memory used 191,531k (± 0.13%) 191,340k (± 0.31%) -191k (- 0.10%) 189,036k 191,796k
Parse Time 0.78s (± 0.75%) 0.78s (± 0.95%) +0.00s (+ 0.39%) 0.77s 0.80s
Bind Time 0.53s (± 0.75%) 0.53s (± 1.22%) +0.00s (+ 0.19%) 0.52s 0.55s
Check Time 7.33s (± 0.50%) 7.32s (± 0.55%) -0.01s (- 0.16%) 7.25s 7.42s
Emit Time 2.47s (± 0.96%) 2.47s (± 0.76%) -0.00s (- 0.04%) 2.43s 2.51s
Total Time 11.11s (± 0.59%) 11.10s (± 0.32%) -0.01s (- 0.10%) 11.03s 11.17s
Monaco - node (v12.1.0, x64)
Memory used 325,699k (± 0.02%) 325,653k (± 0.02%) -46k (- 0.01%) 325,474k 325,750k
Parse Time 1.47s (± 0.75%) 1.47s (± 0.64%) 0.00s ( 0.00%) 1.45s 1.49s
Bind Time 0.73s (± 1.00%) 0.73s (± 0.45%) +0.00s (+ 0.27%) 0.72s 0.74s
Check Time 5.38s (± 0.21%) 5.35s (± 0.40%) -0.02s (- 0.45%) 5.31s 5.40s
Emit Time 3.20s (± 0.44%) 3.21s (± 0.79%) +0.01s (+ 0.41%) 3.16s 3.27s
Total Time 10.78s (± 0.14%) 10.77s (± 0.35%) -0.01s (- 0.07%) 10.68s 10.86s
TFS - node (v12.1.0, x64)
Memory used 290,325k (± 0.03%) 290,301k (± 0.02%) -24k (- 0.01%) 290,140k 290,386k
Parse Time 1.21s (± 0.63%) 1.21s (± 0.49%) +0.01s (+ 0.66%) 1.20s 1.23s
Bind Time 0.69s (± 1.01%) 0.69s (± 0.80%) +0.00s (+ 0.14%) 0.68s 0.71s
Check Time 4.94s (± 0.36%) 4.96s (± 0.37%) +0.02s (+ 0.36%) 4.92s 5.00s
Emit Time 3.40s (± 0.65%) 3.40s (± 0.50%) -0.00s (- 0.03%) 3.37s 3.44s
Total Time 10.24s (± 0.27%) 10.26s (± 0.30%) +0.03s (+ 0.25%) 10.20s 10.32s
material-ui - node (v12.1.0, x64)
Memory used 450,211k (± 0.01%) 450,074k (± 0.06%) -136k (- 0.03%) 449,050k 450,307k
Parse Time 1.77s (± 0.28%) 1.78s (± 0.72%) +0.00s (+ 0.23%) 1.75s 1.80s
Bind Time 0.64s (± 0.58%) 0.64s (± 0.77%) +0.00s (+ 0.16%) 0.63s 0.65s
Check Time 12.71s (± 0.35%) 12.75s (± 0.73%) +0.04s (+ 0.32%) 12.57s 13.07s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.12s (± 0.31%) 15.16s (± 0.60%) +0.05s (+ 0.30%) 15.01s 15.47s
xstate - node (v12.1.0, x64)
Memory used 535,202k (± 0.01%) 538,753k (± 1.43%) +3,551k (+ 0.66%) 534,983k 569,860k
Parse Time 2.49s (± 0.30%) 2.50s (± 0.48%) +0.01s (+ 0.32%) 2.46s 2.51s
Bind Time 1.04s (± 0.45%) 1.03s (± 0.58%) -0.01s (- 0.48%) 1.02s 1.05s
Check Time 1.43s (± 0.62%) 1.43s (± 0.53%) -0.00s (- 0.07%) 1.41s 1.44s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.02s (± 0.23%) 5.02s (± 0.22%) -0.00s (- 0.04%) 4.99s 5.04s
Angular - node (v14.15.1, x64)
Memory used 331,245k (± 0.01%) 331,252k (± 0.01%) +6k (+ 0.00%) 331,205k 331,282k
Parse Time 1.95s (± 0.46%) 1.95s (± 0.38%) +0.00s (+ 0.21%) 1.94s 1.97s
Bind Time 0.86s (± 0.47%) 0.86s (± 0.47%) 0.00s ( 0.00%) 0.85s 0.87s
Check Time 5.43s (± 0.37%) 5.38s (± 0.66%) -0.05s (- 0.92%) 5.32s 5.47s
Emit Time 6.18s (± 0.67%) 6.13s (± 0.41%) -0.05s (- 0.76%) 6.07s 6.19s
Total Time 14.42s (± 0.39%) 14.32s (± 0.30%) -0.10s (- 0.68%) 14.20s 14.40s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,870k (± 0.50%) 191,820k (± 0.68%) -1,050k (- 0.54%) 189,131k 193,584k
Parse Time 0.81s (± 0.55%) 0.81s (± 0.64%) +0.00s (+ 0.12%) 0.80s 0.82s
Bind Time 0.56s (± 1.22%) 0.55s (± 0.54%) -0.00s (- 0.72%) 0.55s 0.56s
Check Time 7.40s (± 0.44%) 7.40s (± 0.52%) 0.00s ( 0.00%) 7.32s 7.49s
Emit Time 2.48s (± 0.71%) 2.48s (± 0.83%) +0.00s (+ 0.04%) 2.44s 2.53s
Total Time 11.25s (± 0.28%) 11.25s (± 0.43%) +0.00s (+ 0.03%) 11.15s 11.36s
Monaco - node (v14.15.1, x64)
Memory used 324,463k (± 0.01%) 324,490k (± 0.01%) +27k (+ 0.01%) 324,457k 324,526k
Parse Time 1.51s (± 0.54%) 1.50s (± 0.63%) -0.01s (- 0.86%) 1.48s 1.51s
Bind Time 0.76s (± 0.45%) 0.75s (± 0.48%) -0.00s (- 0.40%) 0.75s 0.76s
Check Time 5.37s (± 0.50%) 5.36s (± 0.35%) -0.01s (- 0.17%) 5.33s 5.41s
Emit Time 3.26s (± 0.66%) 3.27s (± 0.32%) +0.01s (+ 0.15%) 3.25s 3.30s
Total Time 10.90s (± 0.36%) 10.89s (± 0.31%) -0.02s (- 0.16%) 10.84s 10.98s
TFS - node (v14.15.1, x64)
Memory used 289,241k (± 0.01%) 289,252k (± 0.01%) +12k (+ 0.00%) 289,210k 289,282k
Parse Time 1.23s (± 0.89%) 1.23s (± 0.82%) +0.00s (+ 0.16%) 1.22s 1.26s
Bind Time 0.73s (± 0.76%) 0.73s (± 0.92%) -0.01s (- 0.68%) 0.72s 0.75s
Check Time 4.97s (± 0.60%) 4.95s (± 0.43%) -0.02s (- 0.44%) 4.91s 5.00s
Emit Time 3.45s (± 1.36%) 3.50s (± 0.70%) +0.04s (+ 1.27%) 3.46s 3.58s
Total Time 10.39s (± 0.55%) 10.41s (± 0.38%) +0.02s (+ 0.21%) 10.31s 10.52s
material-ui - node (v14.15.1, x64)
Memory used 448,370k (± 0.03%) 448,408k (± 0.01%) +38k (+ 0.01%) 448,332k 448,469k
Parse Time 1.82s (± 0.55%) 1.82s (± 0.42%) +0.00s (+ 0.05%) 1.81s 1.84s
Bind Time 0.68s (± 0.50%) 0.68s (± 0.54%) -0.00s (- 0.15%) 0.67s 0.68s
Check Time 12.84s (± 0.47%) 12.84s (± 0.57%) -0.00s (- 0.02%) 12.70s 13.02s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.34s (± 0.38%) 15.34s (± 0.50%) -0.00s (- 0.02%) 15.19s 15.53s
xstate - node (v14.15.1, x64)
Memory used 532,996k (± 0.00%) 532,986k (± 0.00%) -10k (- 0.00%) 532,923k 533,039k
Parse Time 2.54s (± 0.41%) 2.55s (± 0.54%) +0.01s (+ 0.51%) 2.53s 2.59s
Bind Time 1.16s (± 1.19%) 1.15s (± 0.93%) -0.01s (- 0.95%) 1.13s 1.18s
Check Time 1.48s (± 0.73%) 1.48s (± 0.40%) -0.00s (- 0.20%) 1.47s 1.49s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.25s (± 0.30%) 5.25s (± 0.30%) +0.00s (+ 0.02%) 5.22s 5.29s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory8 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 47370 10
Baseline main 10

Developer Information:

Download Benchmark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot TypeScript Bot (typescript-bot) mentioned this pull request Jan 10, 2022
🤖 User test baselines have changed for fix47368 typescript-bot/TypeScript#218
Open
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Anders Hejlsberg (ahejlsberg) added 3 commits January 10, 2022 14:53
@ahejlsberg
Explore additional constraint
d0f3303
@ahejlsberg
Revert previous change
c67f160
@ahejlsberg
Add tests
fcde8a2
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jan 10, 2022

Copy link
Copy Markdown
Member Author

Latest commits fix the issue I mentioned above. We know explore both possible constraints.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jan 10, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test faster
TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test inline
TypeScript Bot (@typescript-bot) run dt
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at fcde8a2. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at fcde8a2. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at fcde8a2. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jan 10, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) user test this inline
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I'm starting to run the inline community code test suite on this PR at fcde8a2. Hold tight - I'll update this comment with the log link once the build has been queued.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..47370

Metric main 47370 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 331,245k (± 0.01%) 331,192k (± 0.05%) -53k (- 0.02%) 330,476k 331,326k
Parse Time 1.95s (± 0.46%) 1.94s (± 0.51%) -0.00s (- 0.21%) 1.93s 1.97s
Bind Time 0.86s (± 0.47%) 0.86s (± 0.55%) +0.00s (+ 0.47%) 0.85s 0.87s
Check Time 5.43s (± 0.37%) 5.40s (± 0.43%) -0.03s (- 0.59%) 5.36s 5.46s
Emit Time 6.18s (± 0.67%) 6.18s (± 1.04%) +0.01s (+ 0.11%) 6.08s 6.38s
Total Time 14.42s (± 0.39%) 14.39s (± 0.49%) -0.03s (- 0.19%) 14.27s 14.55s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,870k (± 0.50%) 192,028k (± 0.57%) -842k (- 0.44%) 190,227k 193,607k
Parse Time 0.81s (± 0.55%) 0.81s (± 0.90%) +0.00s (+ 0.50%) 0.80s 0.83s
Bind Time 0.56s (± 1.22%) 0.55s (± 0.54%) -0.00s (- 0.72%) 0.55s 0.56s
Check Time 7.40s (± 0.44%) 7.40s (± 0.60%) +0.00s (+ 0.01%) 7.32s 7.50s
Emit Time 2.48s (± 0.71%) 2.48s (± 1.35%) -0.01s (- 0.24%) 2.42s 2.56s
Total Time 11.25s (± 0.28%) 11.24s (± 0.67%) -0.00s (- 0.00%) 11.11s 11.43s
Monaco - node (v14.15.1, x64)
Memory used 324,463k (± 0.01%) 324,459k (± 0.00%) -4k (- 0.00%) 324,427k 324,492k
Parse Time 1.51s (± 0.54%) 1.50s (± 0.54%) -0.01s (- 0.66%) 1.49s 1.53s
Bind Time 0.76s (± 0.45%) 0.76s (± 0.49%) -0.00s (- 0.26%) 0.75s 0.76s
Check Time 5.37s (± 0.50%) 5.35s (± 0.57%) -0.02s (- 0.47%) 5.26s 5.40s
Emit Time 3.26s (± 0.66%) 3.27s (± 1.13%) +0.01s (+ 0.28%) 3.22s 3.41s
Total Time 10.90s (± 0.36%) 10.88s (± 0.57%) -0.03s (- 0.25%) 10.78s 11.07s
TFS - node (v14.15.1, x64)
Memory used 289,241k (± 0.01%) 289,276k (± 0.00%) +35k (+ 0.01%) 289,251k 289,301k
Parse Time 1.23s (± 0.89%) 1.23s (± 0.80%) -0.00s (- 0.32%) 1.21s 1.26s
Bind Time 0.73s (± 0.76%) 0.73s (± 0.50%) +0.00s (+ 0.27%) 0.73s 0.74s
Check Time 4.97s (± 0.60%) 4.97s (± 0.56%) -0.00s (- 0.04%) 4.88s 5.01s
Emit Time 3.45s (± 1.36%) 3.48s (± 1.13%) +0.03s (+ 0.78%) 3.35s 3.56s
Total Time 10.39s (± 0.55%) 10.41s (± 0.31%) +0.02s (+ 0.24%) 10.33s 10.49s
material-ui - node (v14.15.1, x64)
Memory used 448,370k (± 0.03%) 448,350k (± 0.04%) -20k (- 0.00%) 447,711k 448,447k
Parse Time 1.82s (± 0.55%) 1.83s (± 0.54%) +0.01s (+ 0.27%) 1.81s 1.85s
Bind Time 0.68s (± 0.50%) 0.68s (± 0.44%) +0.00s (+ 0.15%) 0.67s 0.68s
Check Time 12.84s (± 0.47%) 12.76s (± 0.27%) -0.08s (- 0.61%) 12.67s 12.83s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.34s (± 0.38%) 15.27s (± 0.21%) -0.08s (- 0.50%) 15.19s 15.32s
xstate - node (v14.15.1, x64)
Memory used 532,996k (± 0.00%) 532,980k (± 0.00%) -17k (- 0.00%) 532,932k 533,026k
Parse Time 2.54s (± 0.41%) 2.55s (± 0.52%) +0.01s (+ 0.47%) 2.53s 2.59s
Bind Time 1.16s (± 1.19%) 1.15s (± 0.61%) -0.01s (- 0.61%) 1.14s 1.17s
Check Time 1.48s (± 0.73%) 1.48s (± 0.44%) +0.00s (+ 0.20%) 1.47s 1.50s
Emit Time 0.07s (± 0.00%) 0.07s (± 3.14%) +0.00s (+ 1.43%) 0.07s 0.08s
Total Time 5.25s (± 0.30%) 5.26s (± 0.41%) +0.01s (+ 0.11%) 5.22s 5.33s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory8 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 47370 10
Baseline main 10

Developer Information:

Download Benchmark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) user test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized community code test suite on this PR at fcde8a2. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jan 11, 2022

Copy link
Copy Markdown
Member Author

Tests and performance look good. I'm going to merge this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg
Anders Hejlsberg (ahejlsberg) merged commit 4d6dd11 into main Jan 11, 2022
@ahejlsberg
Anders Hejlsberg (ahejlsberg) deleted the fix47368 branch January 11, 2022 15:23
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) mentioned this pull request Jan 12, 2022
Type checking/VS Code slow when using MUI #34801
Closed
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) mentioned this pull request Mar 14, 2022
Cannot use mapped types to create new mapped types #48246
Closed
@ahejlsberg Anders Hejlsberg (ahejlsberg) mentioned this pull request Mar 15, 2022
Possible regression in typechecker for Required type #48157
Closed
@whzx5byb whzx5byb mentioned this pull request Apr 17, 2022
{[K in T]: (arg: K) => void}[T] has inconsistent/unsound behavior when T is a lazy-evaluated union #48734
Closed
@Andarist Mateusz Burzyński (Andarist) mentioned this pull request Jan 1, 2023
Add a test for indexed access on generic mapped type #52069
Merged
@Andarist Mateusz Burzyński (Andarist) mentioned this pull request Mar 6, 2023
Add extra test cases for indexed access on generic mapped type #53112
Merged
@Andarist Mateusz Burzyński (Andarist) mentioned this pull request Sep 21, 2024
Fix multiple issues with indexed access types applied to mapped types #47109
Merged
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham approved these changes
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ahejlsberg Anders Hejlsberg (ahejlsberg)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mapped type indexed access issue

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ahejlsberg @DanielRosenwasser @typescript-bot @weswigham
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.