GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Some refactoring for baselining for easy update by sheetalkamat · Pull Request #48516 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Apr 1, 2022

Copy link
Copy Markdown
Member

This is in anticipation and for my future PRs to be able to update baselines easily

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@typescript-bot TypeScript Bot (typescript-bot) assigned Sheetal Nandi (sheetalkamat) Apr 1, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 1, 2022
@sheetalkamat
Some refactoring for baselining for easy update
880907f
@sheetalkamat
Sheetal Nandi (sheetalkamat) force-pushed the baselining branch from e0975c8 to 880907f Compare April 1, 2022 22:06
@sheetalkamat
Sheetal Nandi (sheetalkamat) requested review from Andrew Casey (amcasey) and Andrew Branch (andrewbranch) April 4, 2022 17:02
@sheetalkamat
Set modified time in baseline
8d7151a
amcasey
Andrew Casey (amcasey) reviewed Apr 4, 2022
View reviewed changes

@amcasey Andrew Casey (amcasey) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but I mostly did spot checks - is there anything particular you want eyes on?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/harness/fakesHosts.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/testRunner/unittests/tsbuild/outFile.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/testRunner/unittests/tsc/helpers.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Sheetal Nandi (sheetalkamat) added 2 commits April 5, 2022 10:23
@sheetalkamat
Merge branch 'main' into baselining
f2fb4cf
@sheetalkamat
Some renames per feedback
710f639
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit 3fd8a6e into main Apr 6, 2022
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the baselining branch April 6, 2022 19:46
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch Andrew Branch (andrewbranch) Awaiting requested review from andrewbranch
1 more reviewer
@amcasey Andrew Casey (amcasey) amcasey left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sheetalkamat Sheetal Nandi (sheetalkamat)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sheetalkamat @amcasey @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.