GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix the version in baselines by sheetalkamat · Pull Request #48602 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Apr 7, 2022

Copy link
Copy Markdown
Member

This fixes issues with nightly or LKG builds failing the tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat
Write version for baselining in buildinfo
562c984 
Also baseline buildinfo so its easier to detect mistakes
@typescript-bot TypeScript Bot (typescript-bot) assigned Sheetal Nandi (sheetalkamat) Apr 7, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 7, 2022
@sheetalkamat
Sheetal Nandi (sheetalkamat) requested review from Daniel Rosenwasser (DanielRosenwasser), Andrew Casey (amcasey) and Andrew Branch (andrewbranch) April 7, 2022 20:17
weswigham
Wesley Wigham (weswigham) reviewed Apr 7, 2022
View reviewed changes
Comment thread ...e/tsbuild/outFile/rebuilds-completely-when-version-in-tsbuildinfo-doesnt-match-ts-version.js
Output::
/lib/tsc --b /src/third --verbose
12:00:00 AM - Projects in this build:
[12:00:00 AM] Projects in this build:

@weswigham Wesley Wigham (weswigham) Apr 7, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did these intentionally swap to pretty output?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sheetalkamat Sheetal Nandi (sheetalkamat) Apr 7, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.. The helper does that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) approved these changes Apr 7, 2022
View reviewed changes
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit d8edd19 into main Apr 7, 2022
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the versionFix branch April 7, 2022 20:38
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham left review comments
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) RyanCavanaugh approved these changes
@amcasey Andrew Casey (amcasey) Awaiting requested review from amcasey
@andrewbranch Andrew Branch (andrewbranch) Awaiting requested review from andrewbranch
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sheetalkamat Sheetal Nandi (sheetalkamat)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sheetalkamat @weswigham @RyanCavanaugh @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.