GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don’t let other completions shadow type keywords in type locations by andrewbranch · Pull Request #48939 · microsoft/TypeScript

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented May 3, 2022

Copy link
Copy Markdown
Member

Fixes #48075

As part of this fix, I started to implement a lot more keyword filtering than we currently do (type keywords are normally offered in value locations 🤦‍♂️), but stopped when it became clear that it was going to be a significant change late in the release cycle. I hope to pick that back up for 4.8.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andrew Branch (andrewbranch) added 2 commits April 22, 2022 16:15
@andrewbranch
Allow type keywords with the same names as other completions
8819771
@andrewbranch
Only add type keywords that are the same as other completions in type…
4f82f7b 
… locations
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) May 3, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 3, 2022
@andrewbranch
Andrew Branch (andrewbranch) requested a review from Gabriela Araujo Britto (gabritto) May 3, 2022 17:50
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes May 3, 2022
View reviewed changes
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed May 3, 2022
View reviewed changes
Comment thread src/services/completions.ts
TypeKeywords,
TypeKeyword, // Literally just `type`
Last = TypeKeywords
Last = TypeKeyword

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) May 3, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 oof, who even uses Last?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gabritto
Gabriela Araujo Britto (gabritto) approved these changes May 4, 2022
View reviewed changes
@andrewbranch
Andrew Branch (andrewbranch) merged commit d879880 into microsoft:main May 4, 2022
@andrewbranch
Andrew Branch (andrewbranch) deleted the bug/48075-2 branch May 4, 2022 15:35
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser left review comments
@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat approved these changes
@gabritto Gabriela Araujo Britto (gabritto) gabritto approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeScript incorrectly auto-importing string from fp-ts.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@andrewbranch @DanielRosenwasser @sheetalkamat @gabritto @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.