GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Skip missing nodes in formatting by andrewbranch · Pull Request #48953 · microsoft/TypeScript

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented May 4, 2022

Copy link
Copy Markdown
Member

Fixes #32862 (not the first and not the last time)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrewbranch
Skip missing nodes in formatting
55f2504
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) May 4, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 4, 2022
@andrewbranch
Andrew Branch (andrewbranch) requested a review from Jake Bailey (jakebailey) May 4, 2022 17:24
jakebailey
Jake Bailey (jakebailey) reviewed May 4, 2022
View reviewed changes

@jakebailey Jake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume formatting is called from code fixes, then, given the original traces are all rooted from getCodeFixes, or should the test call via code fixes?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrewbranch

Andrew Branch (andrewbranch) commented May 4, 2022

Copy link
Copy Markdown
Member Author

In this case you can just take my word that selection-based formatting caused the same crash prior to my fix. Occasionally a formatter crash can only be reproduced with synthesized nodes, but that wasn’t the case here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jakebailey
Jake Bailey (jakebailey) approved these changes May 4, 2022
View reviewed changes
@andrewbranch
Andrew Branch (andrewbranch) merged commit e26bc8a into microsoft:main May 4, 2022
@andrewbranch
Andrew Branch (andrewbranch) deleted the bug/32862 branch May 4, 2022 22:07
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey Jake Bailey (jakebailey) jakebailey approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Debug Failure. False expression: Token end is child end in 'processChildNode' during 'getCodeFixes'

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@andrewbranch @jakebailey @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.