GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "feat(47595): allow using private fields in type queries" by jakebailey · Pull Request #48959 · microsoft/TypeScript

Conversation

@jakebailey

@jakebailey Jake Bailey (jakebailey) commented May 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reopens #47595

This caused an accidental API break (noted here #47696 (comment)).

It's too close to 4.7 to come up with a redesigned AST, so reverting.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bradzacher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@jakebailey
Revert "feat(47595): allow using private fields in type queries (micr…
52ac031 
…osoft#47696)"

This reverts commit 063eaa7.
@jakebailey
Jake Bailey (jakebailey) requested review from Daniel Rosenwasser (DanielRosenwasser) and Nathan Shively-Sanders (sandersn) May 4, 2022 22:13
@typescript-bot TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey) May 4, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 4, 2022
This was referenced May 4, 2022
feat(es/parser): typeof on #private Fields swc-project/swc#4302
Merged
feat: support typeof on #private Fields evanw/esbuild#2174
Merged
Feat(rome_js_parser): typeof private property name rome/tools#2524
Closed
typeof on #private Fields babel/babel#14451
Closed
feat: typeof on #private Fields in TypeScript babel/babel#14454
Closed
typeof on #private Fields not handled by typeof import() #48690
Closed
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request May 4, 2022
Design Meeting Notes, 5/4/2022 #48960
Closed
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes May 4, 2022
View reviewed changes
@jakebailey
Jake Bailey (jakebailey) merged commit 7d60dc1 into microsoft:main May 4, 2022
@jakebailey
Jake Bailey (jakebailey) deleted the revert-47696 branch May 4, 2022 23:50
@jakebailey Jake Bailey (jakebailey) mentioned this pull request May 4, 2022
Inability to use typeof on an ES private property #47595
Closed
@bradzacher Brad Zacher (bradzacher) mentioned this pull request May 5, 2022
feat(typescript-estree): typeof private identifiers typescript-eslint/typescript-eslint#4832
Closed
3 tasks done
@MichaReiser Micha Reiser (MichaReiser) mentioned this pull request May 5, 2022
📎 TypeScript 4.7 rome/tools#2400
Closed
3 of 4 tasks
@williamtetlow William Tetlow (williamtetlow) mentioned this pull request May 5, 2022
Revert "feat(es): Support typeof with private fields (#4302)" swc-project/swc#4542
Merged
@magic-akari magic-akari mentioned this pull request May 6, 2022
fix typeof import("path").Foo.#private #48763
Closed
@fatcerberus Bruce Pascoe (fatcerberus) mentioned this pull request May 21, 2023
typeof doesn't work with #private fields - identifier expected #54337
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
@sandersn Nathan Shively-Sanders (sandersn) Awaiting requested review from sandersn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jakebailey Jake Bailey (jakebailey)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jakebailey @DanielRosenwasser @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.