GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(48878): TypeChecker.getTypeAtLocation throws runtime errors when passed valid nodes by a-tarasyuk · Pull Request #48967 · microsoft/TypeScript

Conversation

@a-tarasyuk

@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) commented May 5, 2022

Copy link
Copy Markdown
Contributor

Fixes #48878

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@typescript-bot TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label May 5, 2022
sheetalkamat
Sheetal Nandi (sheetalkamat) requested changes May 5, 2022
View reviewed changes
Comment thread src/compiler/checker.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
fix(48878): return errorType on invalid nodes in getTypeAtLocation
65c1f70
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the fix/48878 branch from 4404e1e to 65c1f70 Compare May 5, 2022 17:24
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) requested a review from Sheetal Nandi (sheetalkamat) May 5, 2022 17:25
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes May 5, 2022
View reviewed changes
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit f8a09be into microsoft:main May 5, 2022
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeChecker.getTypeAtLocation throws runtime errors when passed valid nodes

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@a-tarasyuk @sheetalkamat @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.