GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix node16 tests for module resolution by sheetalkamat · Pull Request #48974 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented May 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

These tests were broken in #48879

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat
Fix node16 tests
3182a2a
@typescript-bot TypeScript Bot (typescript-bot) assigned Sheetal Nandi (sheetalkamat) May 5, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 5, 2022
@sheetalkamat
Sheetal Nandi (sheetalkamat) requested review from Daniel Rosenwasser (DanielRosenwasser) and Wesley Wigham (weswigham) May 5, 2022 17:12
@sheetalkamat Sheetal Nandi (sheetalkamat) mentioned this pull request May 5, 2022
Start Node ESM stable version at Node16 #48879
Merged
andrewbranch
Andrew Branch (andrewbranch) approved these changes May 5, 2022
View reviewed changes
weswigham
Wesley Wigham (weswigham) approved these changes May 5, 2022
View reviewed changes
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes May 5, 2022
View reviewed changes
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit 1e157ef into main May 5, 2022
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the node16TestsFix branch May 5, 2022 18:45
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
@weswigham Wesley Wigham (weswigham) weswigham approved these changes
@andrewbranch Andrew Branch (andrewbranch) andrewbranch approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sheetalkamat Sheetal Nandi (sheetalkamat)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sheetalkamat @DanielRosenwasser @weswigham @andrewbranch @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.