GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Flag resolution mode assertions in non-nightly builds by RyanCavanaugh · Pull Request #49002 · microsoft/TypeScript

Conversation

@RyanCavanaugh

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) commented May 6, 2022

Copy link
Copy Markdown
Member

Per offline discussion.

See RyanCavanaugh@898be45 for what happens in non-nightly builds

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
weswigham reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@RyanCavanaugh
Flag resolution mode assertions in non-nightly builds
3126112
@typescript-bot TypeScript Bot (typescript-bot) assigned Ryan Cavanaugh (RyanCavanaugh) May 6, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 6, 2022
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed May 6, 2022
View reviewed changes
Comment thread src/compiler/transformers/declarations.ts
// Nothing visible
}

function getResolutionModeOverrideForClauseInNightly(assertClause: AssertClause | undefined) {

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) May 6, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be getting called in the checker? Seems like you'll only get an error in .d.ts generation scenarios

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RyanCavanaugh
Add checker check
9576396
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented May 6, 2022

Copy link
Copy Markdown
Member

Ideally the span would be on the resolution-mode field, but it works.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes May 6, 2022
View reviewed changes
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit 1a4643b into microsoft:main May 6, 2022
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jun 1, 2022

Copy link
Copy Markdown
Member

Looks like this didn't cover import() types though.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) deleted the flagImportAssertions branch June 1, 2022 23:35
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jun 2, 2022

Copy link
Copy Markdown
Member

Opened #49354 as a follow-up.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Jun 2, 2022
Add nightly-only error on ImportType resolution mode assertion #49356
Merged
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@RyanCavanaugh @DanielRosenwasser @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.