GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Swap `checkExpressionWorker` to use an array of functions instead of a `switch` statement. by DanielRosenwasser · Pull Request #50228 · microsoft/TypeScript

Conversation

@DanielRosenwasser

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) commented Aug 8, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DanielRosenwasser
Swap checkExpressionWorker to use an array of functions instead of …
2b0503b 
…a `switch` statement.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Aug 8, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 8, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the perf test suite on this PR at 2b0503b. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50228
Metric main 50228 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 360,462k (± 0.02%) 360,517k (± 0.02%) +56k (+ 0.02%) 360,382k 360,611k
Parse Time 2.10s (± 0.42%) 2.11s (± 0.45%) +0.00s (+ 0.24%) 2.09s 2.13s
Bind Time 0.89s (± 1.00%) 0.89s (± 0.69%) -0.01s (- 0.67%) 0.87s 0.90s
Check Time 6.04s (± 0.53%) 6.04s (± 0.42%) +0.01s (+ 0.12%) 5.97s 6.11s
Emit Time 6.16s (± 0.53%) 6.19s (± 0.95%) +0.03s (+ 0.52%) 6.10s 6.40s
Total Time 15.19s (± 0.32%) 15.23s (± 0.44%) +0.04s (+ 0.25%) 15.11s 15.39s
Compiler-Unions - node (v10.16.3, x64)
Memory used 205,501k (± 0.04%) 205,575k (± 0.02%) +74k (+ 0.04%) 205,451k 205,695k
Parse Time 0.83s (± 0.94%) 0.84s (± 1.07%) +0.01s (+ 0.84%) 0.82s 0.85s
Bind Time 0.53s (± 1.66%) 0.53s (± 1.54%) 0.00s ( 0.00%) 0.52s 0.55s
Check Time 7.13s (± 0.61%) 7.13s (± 0.41%) -0.00s (- 0.03%) 7.06s 7.21s
Emit Time 2.51s (± 0.98%) 2.53s (± 0.94%) +0.02s (+ 0.64%) 2.46s 2.58s
Total Time 11.01s (± 0.52%) 11.02s (± 0.36%) +0.02s (+ 0.17%) 10.93s 11.11s
Monaco - node (v10.16.3, x64)
Memory used 343,965k (± 0.02%) 343,980k (± 0.01%) +15k (+ 0.00%) 343,895k 344,095k
Parse Time 1.61s (± 0.62%) 1.62s (± 0.52%) +0.01s (+ 0.68%) 1.61s 1.64s
Bind Time 0.75s (± 0.59%) 0.76s (± 0.63%) +0.01s (+ 0.66%) 0.75s 0.77s
Check Time 5.99s (± 0.47%) 6.03s (± 0.56%) +0.04s (+ 0.68%) 5.97s 6.12s
Emit Time 3.27s (± 1.00%) 3.29s (± 0.40%) +0.02s (+ 0.55%) 3.26s 3.32s
Total Time 11.63s (± 0.51%) 11.69s (± 0.27%) +0.07s (+ 0.58%) 11.62s 11.76s
TFS - node (v10.16.3, x64)
Memory used 305,274k (± 0.02%) 305,330k (± 0.02%) +55k (+ 0.02%) 305,189k 305,485k
Parse Time 1.29s (± 0.65%) 1.29s (± 0.46%) +0.00s (+ 0.23%) 1.28s 1.31s
Bind Time 0.72s (± 0.66%) 0.72s (± 0.66%) 0.00s ( 0.00%) 0.71s 0.73s
Check Time 5.42s (± 0.58%) 5.45s (± 0.41%) +0.02s (+ 0.46%) 5.39s 5.48s
Emit Time 3.45s (± 1.01%) 3.46s (± 1.04%) +0.01s (+ 0.35%) 3.38s 3.56s
Total Time 10.88s (± 0.41%) 10.92s (± 0.48%) +0.04s (+ 0.32%) 10.81s 11.04s
material-ui - node (v10.16.3, x64)
Memory used 469,523k (± 0.01%) 469,563k (± 0.01%) +40k (+ 0.01%) 469,453k 469,668k
Parse Time 1.84s (± 0.75%) 1.84s (± 0.77%) 0.00s ( 0.00%) 1.81s 1.87s
Bind Time 0.69s (± 1.69%) 0.69s (± 1.16%) +0.01s (+ 0.87%) 0.67s 0.71s
Check Time 14.62s (± 0.68%) 14.59s (± 0.44%) -0.03s (- 0.18%) 14.42s 14.72s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.14s (± 0.62%) 17.11s (± 0.43%) -0.03s (- 0.16%) 16.92s 17.29s
xstate - node (v10.16.3, x64)
Memory used 578,547k (± 0.02%) 578,577k (± 0.01%) +30k (+ 0.01%) 578,446k 578,764k
Parse Time 2.62s (± 0.43%) 2.61s (± 0.44%) -0.01s (- 0.27%) 2.58s 2.63s
Bind Time 1.03s (± 1.14%) 1.02s (± 1.18%) -0.01s (- 0.58%) 1.00s 1.06s
Check Time 1.57s (± 0.56%) 1.56s (± 0.48%) -0.01s (- 0.83%) 1.54s 1.57s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.29s (± 0.34%) 5.26s (± 0.34%) -0.02s (- 0.45%) 5.22s 5.31s
Angular - node (v12.1.0, x64)
Memory used 338,015k (± 0.03%) 337,880k (± 0.08%) -135k (- 0.04%) 336,836k 338,206k
Parse Time 2.08s (± 0.42%) 2.11s (± 0.56%) +0.02s (+ 1.20%) 2.08s 2.13s
Bind Time 0.86s (± 0.95%) 0.86s (± 0.60%) +0.00s (+ 0.12%) 0.85s 0.88s
Check Time 5.88s (± 0.82%) 5.89s (± 0.67%) +0.00s (+ 0.09%) 5.83s 6.02s
Emit Time 6.38s (± 0.65%) 6.39s (± 0.52%) +0.01s (+ 0.09%) 6.31s 6.46s
Total Time 15.21s (± 0.56%) 15.24s (± 0.40%) +0.03s (+ 0.22%) 15.17s 15.45s
Compiler-Unions - node (v12.1.0, x64)
Memory used 193,299k (± 0.02%) 193,267k (± 0.03%) -32k (- 0.02%) 193,150k 193,388k
Parse Time 0.82s (± 0.94%) 0.82s (± 1.00%) +0.00s (+ 0.37%) 0.81s 0.85s
Bind Time 0.55s (± 1.39%) 0.54s (± 0.88%) -0.00s (- 0.55%) 0.54s 0.56s
Check Time 6.67s (± 0.71%) 6.66s (± 0.68%) -0.01s (- 0.15%) 6.57s 6.74s
Emit Time 2.57s (± 1.31%) 2.54s (± 0.60%) -0.02s (- 0.93%) 2.52s 2.59s
Total Time 10.61s (± 0.36%) 10.57s (± 0.51%) -0.04s (- 0.33%) 10.45s 10.67s
Monaco - node (v12.1.0, x64)
Memory used 326,984k (± 0.03%) 327,049k (± 0.02%) +65k (+ 0.02%) 326,952k 327,175k
Parse Time 1.57s (± 0.60%) 1.58s (± 0.85%) +0.01s (+ 0.51%) 1.54s 1.60s
Bind Time 0.75s (± 0.67%) 0.74s (± 0.78%) -0.00s (- 0.27%) 0.73s 0.76s
Check Time 5.81s (± 0.52%) 5.85s (± 0.43%) +0.04s (+ 0.69%) 5.78s 5.89s
Emit Time 3.30s (± 0.76%) 3.30s (± 0.63%) +0.01s (+ 0.18%) 3.26s 3.35s
Total Time 11.42s (± 0.37%) 11.47s (± 0.42%) +0.05s (+ 0.47%) 11.36s 11.57s
TFS - node (v12.1.0, x64)
Memory used 289,858k (± 0.02%) 289,910k (± 0.03%) +52k (+ 0.02%) 289,760k 290,141k
Parse Time 1.30s (± 0.74%) 1.30s (± 1.11%) +0.00s (+ 0.15%) 1.27s 1.34s
Bind Time 0.72s (± 0.90%) 0.72s (± 0.62%) -0.00s (- 0.00%) 0.71s 0.73s
Check Time 5.37s (± 0.40%) 5.36s (± 0.59%) -0.01s (- 0.22%) 5.31s 5.43s
Emit Time 3.52s (± 0.90%) 3.53s (± 0.57%) +0.01s (+ 0.28%) 3.49s 3.57s
Total Time 10.91s (± 0.25%) 10.91s (± 0.43%) -0.00s (- 0.02%) 10.81s 11.00s
material-ui - node (v12.1.0, x64)
Memory used 448,382k (± 0.08%) 448,654k (± 0.01%) +272k (+ 0.06%) 448,540k 448,734k
Parse Time 1.82s (± 0.45%) 1.82s (± 0.55%) 0.00s ( 0.00%) 1.80s 1.84s
Bind Time 0.67s (± 0.54%) 0.67s (± 0.83%) -0.00s (- 0.30%) 0.66s 0.69s
Check Time 13.10s (± 0.93%) 13.06s (± 0.61%) -0.04s (- 0.27%) 12.88s 13.22s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.59s (± 0.77%) 15.56s (± 0.56%) -0.03s (- 0.20%) 15.37s 15.73s
xstate - node (v12.1.0, x64)
Memory used 547,270k (± 1.33%) 544,009k (± 0.01%) -3,260k (- 0.60%) 543,792k 544,151k
Parse Time 2.56s (± 0.77%) 2.55s (± 0.39%) -0.02s (- 0.62%) 2.53s 2.58s
Bind Time 1.02s (± 1.32%) 1.02s (± 1.18%) +0.00s (+ 0.20%) 0.99s 1.04s
Check Time 1.51s (± 0.54%) 1.51s (± 0.55%) +0.00s (+ 0.07%) 1.49s 1.53s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.17s (± 0.51%) 5.15s (± 0.32%) -0.02s (- 0.37%) 5.10s 5.19s
Angular - node (v14.15.1, x64)
Memory used 336,174k (± 0.01%) 336,257k (± 0.01%) +82k (+ 0.02%) 336,206k 336,317k
Parse Time 2.08s (± 1.12%) 2.06s (± 0.31%) -0.02s (- 1.06%) 2.05s 2.08s
Bind Time 0.89s (± 0.65%) 0.90s (± 0.81%) +0.01s (+ 0.56%) 0.88s 0.91s
Check Time 5.81s (± 0.48%) 5.85s (± 0.52%) +0.03s (+ 0.58%) 5.79s 5.90s
Emit Time 6.38s (± 0.66%) 6.41s (± 0.65%) +0.02s (+ 0.39%) 6.33s 6.53s
Total Time 15.17s (± 0.49%) 15.22s (± 0.34%) +0.05s (+ 0.30%) 15.11s 15.36s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,796k (± 0.01%) 192,193k (± 0.38%) +397k (+ 0.21%) 191,827k 195,179k
Parse Time 0.85s (± 0.61%) 0.85s (± 0.82%) -0.00s (- 0.00%) 0.84s 0.87s
Bind Time 0.57s (± 1.66%) 0.57s (± 1.32%) -0.01s (- 1.22%) 0.56s 0.59s
Check Time 6.66s (± 0.43%) 6.67s (± 0.65%) +0.02s (+ 0.23%) 6.60s 6.81s
Emit Time 2.49s (± 0.91%) 2.49s (± 0.72%) +0.00s (+ 0.08%) 2.46s 2.54s
Total Time 10.57s (± 0.45%) 10.58s (± 0.39%) +0.01s (+ 0.10%) 10.54s 10.74s
Monaco - node (v14.15.1, x64)
Memory used 325,736k (± 0.01%) 325,799k (± 0.01%) +63k (+ 0.02%) 325,754k 325,841k
Parse Time 1.58s (± 0.79%) 1.58s (± 0.73%) +0.01s (+ 0.44%) 1.56s 1.61s
Bind Time 0.78s (± 0.74%) 0.79s (± 0.63%) +0.00s (+ 0.38%) 0.78s 0.80s
Check Time 5.71s (± 0.61%) 5.69s (± 0.30%) -0.02s (- 0.33%) 5.66s 5.73s
Emit Time 3.37s (± 0.74%) 3.32s (± 0.70%) -0.05s (- 1.40%) 3.29s 3.39s
Total Time 11.44s (± 0.41%) 11.38s (± 0.39%) -0.06s (- 0.52%) 11.31s 11.49s
TFS - node (v14.15.1, x64)
Memory used 288,892k (± 0.01%) 288,958k (± 0.01%) +67k (+ 0.02%) 288,903k 288,997k
Parse Time 1.33s (± 1.47%) 1.35s (± 0.95%) +0.02s (+ 1.20%) 1.31s 1.37s
Bind Time 0.77s (± 4.58%) 0.74s (± 1.34%) 🟩-0.02s (- 3.13%) 0.73s 0.78s
Check Time 5.36s (± 0.47%) 5.37s (± 0.36%) +0.01s (+ 0.21%) 5.32s 5.41s
Emit Time 3.60s (± 2.46%) 3.57s (± 1.81%) -0.03s (- 0.72%) 3.43s 3.69s
Total Time 11.06s (± 0.70%) 11.03s (± 0.68%) -0.03s (- 0.24%) 10.85s 11.19s
material-ui - node (v14.15.1, x64)
Memory used 446,583k (± 0.07%) 446,861k (± 0.01%) +278k (+ 0.06%) 446,802k 446,925k
Parse Time 1.88s (± 0.64%) 1.88s (± 0.53%) +0.01s (+ 0.37%) 1.86s 1.90s
Bind Time 0.71s (± 1.06%) 0.72s (± 0.82%) +0.01s (+ 1.40%) 0.71s 0.74s
Check Time 13.21s (± 0.80%) 13.21s (± 0.77%) +0.00s (+ 0.02%) 12.99s 13.43s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.80s (± 0.70%) 15.82s (± 0.71%) +0.02s (+ 0.10%) 15.57s 16.06s
xstate - node (v14.15.1, x64)
Memory used 541,782k (± 0.00%) 541,820k (± 0.00%) +38k (+ 0.01%) 541,767k 541,880k
Parse Time 2.62s (± 0.54%) 2.60s (± 0.35%) -0.02s (- 0.65%) 2.58s 2.62s
Bind Time 1.16s (± 1.60%) 1.14s (± 1.30%) -0.01s (- 1.12%) 1.11s 1.17s
Check Time 1.56s (± 0.39%) 1.56s (± 0.81%) +0.00s (+ 0.26%) 1.53s 1.58s
Emit Time 0.08s (± 4.79%) 0.07s (± 4.95%) -0.00s (- 1.32%) 0.07s 0.08s
Total Time 5.40s (± 0.48%) 5.37s (± 0.48%) -0.02s (- 0.44%) 5.31s 5.43s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50228 10
Baseline main 10

TSServer

Comparison Report - main..50228
Metric main 50228 Delta Best Worst
Compiler-UnionsTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,460ms (± 0.53%) 1,457ms (± 0.40%) -3ms (- 0.23%) 1,440ms 1,469ms
Req 2 - geterr 3,619ms (± 0.35%) 3,606ms (± 0.42%) -13ms (- 0.36%) 3,568ms 3,644ms
Req 3 - references 280ms (± 1.76%) 276ms (± 0.94%) -4ms (- 1.39%) 270ms 281ms
Req 4 - navto 235ms (± 0.92%) 231ms (± 2.35%) -4ms (- 1.66%) 213ms 239ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 63ms (± 4.43%) 63ms (± 4.50%) -0ms (- 0.32%) 59ms 70ms
CompilerTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,562ms (± 0.68%) 1,565ms (± 0.58%) +3ms (+ 0.18%) 1,546ms 1,582ms
Req 2 - geterr 2,288ms (± 0.43%) 2,278ms (± 0.51%) -10ms (- 0.43%) 2,252ms 2,303ms
Req 3 - references 301ms (± 1.74%) 300ms (± 1.35%) -1ms (- 0.20%) 294ms 315ms
Req 4 - navto 237ms (± 1.74%) 236ms (± 2.39%) -2ms (- 0.72%) 225ms 249ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 69ms (± 1.43%) 69ms (± 1.89%) -0ms (- 0.29%) 65ms 71ms
xstateTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 2,179ms (± 0.42%) 2,181ms (± 0.49%) +2ms (+ 0.09%) 2,156ms 2,201ms
Req 2 - geterr 776ms (± 0.78%) 775ms (± 0.35%) -1ms (- 0.14%) 769ms 780ms
Req 3 - references 97ms (± 1.58%) 96ms (± 1.29%) -1ms (- 1.13%) 93ms 99ms
Req 4 - navto 254ms (± 0.91%) 255ms (± 0.73%) +1ms (+ 0.55%) 251ms 258ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 273ms (± 1.17%) 272ms (± 1.19%) -1ms (- 0.29%) 261ms 277ms
Compiler-UnionsTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,477ms (± 0.79%) 1,481ms (± 0.89%) +4ms (+ 0.24%) 1,450ms 1,518ms
Req 2 - geterr 3,402ms (± 0.61%) 3,406ms (± 0.72%) +4ms (+ 0.12%) 3,367ms 3,464ms
Req 3 - references 261ms (± 0.68%) 262ms (± 0.88%) +2ms (+ 0.65%) 258ms 269ms
Req 4 - navto 205ms (± 0.82%) 204ms (± 0.59%) -1ms (- 0.39%) 201ms 207ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 74ms (±13.16%) 72ms (±13.79%) -2ms (- 2.69%) 55ms 84ms
CompilerTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,559ms (± 0.59%) 1,565ms (± 0.40%) +5ms (+ 0.35%) 1,551ms 1,578ms
Req 2 - geterr 2,209ms (± 0.48%) 2,211ms (± 0.49%) +2ms (+ 0.09%) 2,192ms 2,230ms
Req 3 - references 273ms (± 0.67%) 277ms (± 2.65%) +4ms (+ 1.50%) 271ms 305ms
Req 4 - navto 215ms (± 0.57%) 216ms (± 0.88%) +0ms (+ 0.14%) 213ms 222ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 64ms (± 3.74%) 62ms (± 5.22%) 🟩-2ms (- 3.15%) 55ms 67ms
xstateTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 2,100ms (± 0.68%) 2,116ms (± 0.68%) +16ms (+ 0.76%) 2,084ms 2,159ms
Req 2 - geterr 761ms (± 0.65%) 763ms (± 0.50%) +2ms (+ 0.25%) 756ms 771ms
Req 3 - references 65ms (± 1.12%) 65ms (± 1.62%) +1ms (+ 0.93%) 63ms 67ms
Req 4 - navto 242ms (± 1.35%) 240ms (± 1.81%) -2ms (- 0.83%) 229ms 247ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 265ms (± 1.41%) 265ms (± 1.04%) -1ms (- 0.26%) 259ms 272ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,527ms (± 0.67%) 1,529ms (± 0.46%) +2ms (+ 0.15%) 1,510ms 1,541ms
Req 2 - geterr 3,534ms (± 0.52%) 3,544ms (± 0.61%) +9ms (+ 0.26%) 3,492ms 3,590ms
Req 3 - references 276ms (± 0.48%) 278ms (± 0.60%) +2ms (+ 0.54%) 274ms 282ms
Req 4 - navto 217ms (± 0.43%) 218ms (± 0.57%) +1ms (+ 0.46%) 216ms 221ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 57ms (± 5.74%) 56ms (± 3.96%) -1ms (- 1.40%) 54ms 65ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,605ms (± 0.61%) 1,609ms (± 0.61%) +4ms (+ 0.23%) 1,590ms 1,634ms
Req 2 - geterr 2,341ms (± 0.58%) 2,338ms (± 0.50%) -3ms (- 0.14%) 2,315ms 2,368ms
Req 3 - references 286ms (± 0.79%) 287ms (± 0.83%) +1ms (+ 0.24%) 284ms 294ms
Req 4 - navto 235ms (± 2.59%) 235ms (± 2.56%) +1ms (+ 0.34%) 226ms 249ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 54ms (± 1.52%) 53ms (± 1.09%) -0ms (- 0.74%) 52ms 55ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,228ms (± 0.37%) 2,246ms (± 0.66%) +18ms (+ 0.79%) 2,210ms 2,272ms
Req 2 - geterr 783ms (± 0.51%) 786ms (± 0.55%) +2ms (+ 0.31%) 778ms 797ms
Req 3 - references 68ms (± 9.45%) 65ms (± 1.03%) 🟩-3ms (- 4.99%) 63ms 66ms
Req 4 - navto 249ms (± 0.77%) 250ms (± 0.92%) +0ms (+ 0.08%) 245ms 256ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 267ms (± 0.47%) 267ms (± 0.49%) +0ms (+ 0.04%) 264ms 271ms
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v10.16.3, x64)
  • Compiler-UnionsTSServer - node (v12.1.0, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v10.16.3, x64)
  • CompilerTSServer - node (v12.1.0, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v10.16.3, x64)
  • xstateTSServer - node (v12.1.0, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50228 10
Baseline main 10

Developer Information:

Download Benchmark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser
Add consistent arity to all checkExpressionWorkerTable entries.
ed827b2
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Aug 9, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this faster
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the abridged perf test suite on this PR at ed827b2. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser
Add a special case for arrays to avoid cascading forceTuple everywh…
f0ab973 
…ere.
@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50228

Metric main 50228 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 336,202k (± 0.01%) 336,206k (± 0.00%) +4k (+ 0.00%) 336,167k 336,232k
Parse Time 2.07s (± 0.78%) 2.07s (± 0.86%) +0.00s (+ 0.05%) 2.04s 2.13s
Bind Time 0.90s (± 0.85%) 0.90s (± 0.37%) +0.00s (+ 0.45%) 0.89s 0.91s
Check Time 5.85s (± 0.59%) 5.84s (± 0.43%) -0.01s (- 0.21%) 5.79s 5.90s
Emit Time 6.41s (± 0.73%) 6.42s (± 0.74%) +0.01s (+ 0.20%) 6.33s 6.52s
Total Time 15.23s (± 0.47%) 15.23s (± 0.44%) +0.00s (+ 0.01%) 15.07s 15.35s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,817k (± 0.02%) 191,854k (± 0.01%) +36k (+ 0.02%) 191,809k 191,916k
Parse Time 0.85s (± 0.61%) 0.86s (± 0.65%) +0.01s (+ 0.82%) 0.85s 0.87s
Bind Time 0.57s (± 0.78%) 0.58s (± 1.03%) +0.01s (+ 1.41%) 0.56s 0.59s
Check Time 6.69s (± 0.69%) 6.69s (± 0.35%) +0.00s (+ 0.03%) 6.64s 6.75s
Emit Time 2.49s (± 0.74%) 2.48s (± 0.76%) -0.02s (- 0.64%) 2.44s 2.51s
Total Time 10.60s (± 0.50%) 10.60s (± 0.30%) +0.00s (+ 0.03%) 10.53s 10.66s
Monaco - node (v14.15.1, x64)
Memory used 325,751k (± 0.00%) 325,779k (± 0.01%) +28k (+ 0.01%) 325,718k 325,842k
Parse Time 1.58s (± 0.57%) 1.58s (± 0.66%) +0.00s (+ 0.13%) 1.56s 1.60s
Bind Time 0.79s (± 1.35%) 0.78s (± 0.71%) -0.01s (- 1.02%) 0.77s 0.79s
Check Time 5.69s (± 0.59%) 5.69s (± 0.62%) -0.00s (- 0.02%) 5.64s 5.77s
Emit Time 3.38s (± 0.80%) 3.34s (± 0.33%) -0.05s (- 1.36%) 3.31s 3.36s
Total Time 11.43s (± 0.48%) 11.38s (± 0.37%) -0.05s (- 0.39%) 11.32s 11.49s
TFS - node (v14.15.1, x64)
Memory used 288,908k (± 0.01%) 288,934k (± 0.01%) +26k (+ 0.01%) 288,871k 289,011k
Parse Time 1.34s (± 2.44%) 1.33s (± 1.46%) -0.01s (- 0.60%) 1.30s 1.37s
Bind Time 0.76s (± 3.58%) 0.76s (± 2.03%) -0.01s (- 0.79%) 0.73s 0.78s
Check Time 5.36s (± 0.31%) 5.38s (± 0.57%) +0.02s (+ 0.34%) 5.29s 5.44s
Emit Time 3.55s (± 1.72%) 3.60s (± 2.12%) +0.04s (+ 1.21%) 3.47s 3.72s
Total Time 11.01s (± 0.56%) 11.06s (± 0.85%) +0.05s (+ 0.46%) 10.86s 11.20s
material-ui - node (v14.15.1, x64)
Memory used 446,827k (± 0.01%) 446,846k (± 0.01%) +19k (+ 0.00%) 446,790k 446,906k
Parse Time 1.87s (± 0.31%) 1.87s (± 0.33%) +0.00s (+ 0.21%) 1.86s 1.88s
Bind Time 0.71s (± 0.70%) 0.72s (± 1.11%) +0.00s (+ 0.42%) 0.70s 0.73s
Check Time 13.15s (± 0.75%) 13.14s (± 0.47%) -0.01s (- 0.07%) 13.04s 13.34s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.73s (± 0.61%) 15.73s (± 0.38%) -0.00s (- 0.03%) 15.64s 15.91s
xstate - node (v14.15.1, x64)
Memory used 541,802k (± 0.00%) 541,830k (± 0.01%) +28k (+ 0.01%) 541,767k 541,933k
Parse Time 2.62s (± 0.37%) 2.60s (± 0.53%) -0.02s (- 0.69%) 2.58s 2.64s
Bind Time 1.14s (± 1.11%) 1.14s (± 1.16%) +0.00s (+ 0.09%) 1.11s 1.17s
Check Time 1.55s (± 0.48%) 1.56s (± 0.38%) +0.02s (+ 1.10%) 1.55s 1.58s
Emit Time 0.07s (± 4.66%) 0.08s (± 4.79%) +0.00s (+ 4.11%) 0.07s 0.08s
Total Time 5.38s (± 0.43%) 5.38s (± 0.37%) -0.00s (- 0.04%) 5.33s 5.42s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50228 10
Baseline main 10

Developer Information:

Download Benchmark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Aug 9, 2022
Swap forEachChild to use a table of functions instead of a switch statement. #50225
Merged
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Aug 9, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this faster
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
2 similar comments
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Aug 9, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this faster
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Aug 9, 2022

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) perf test this faster
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the abridged perf test suite on this PR at f0ab973. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Daniel Rosenwasser (@DanielRosenwasser)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..50228

Metric main 50228 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 336,180k (± 0.01%) 336,216k (± 0.01%) +36k (+ 0.01%) 336,131k 336,298k
Parse Time 2.06s (± 0.51%) 2.07s (± 0.37%) +0.01s (+ 0.39%) 2.05s 2.08s
Bind Time 0.89s (± 0.66%) 0.90s (± 0.41%) +0.00s (+ 0.11%) 0.89s 0.90s
Check Time 5.84s (± 0.41%) 5.85s (± 0.40%) +0.01s (+ 0.15%) 5.80s 5.91s
Emit Time 6.36s (± 0.58%) 6.39s (± 0.38%) +0.03s (+ 0.39%) 6.33s 6.45s
Total Time 15.16s (± 0.32%) 15.19s (± 0.26%) +0.04s (+ 0.24%) 15.10s 15.29s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,814k (± 0.02%) 191,852k (± 0.01%) +39k (+ 0.02%) 191,802k 191,903k
Parse Time 0.85s (± 0.80%) 0.85s (± 0.65%) -0.00s (- 0.35%) 0.84s 0.86s
Bind Time 0.57s (± 1.44%) 0.57s (± 0.58%) -0.00s (- 0.70%) 0.56s 0.58s
Check Time 6.68s (± 0.64%) 6.69s (± 0.39%) +0.00s (+ 0.04%) 6.63s 6.74s
Emit Time 2.50s (± 0.51%) 2.50s (± 0.84%) -0.00s (- 0.08%) 2.46s 2.56s
Total Time 10.62s (± 0.38%) 10.61s (± 0.28%) -0.01s (- 0.09%) 10.56s 10.70s
Monaco - node (v14.15.1, x64)
Memory used 325,749k (± 0.00%) 325,778k (± 0.00%) +29k (+ 0.01%) 325,741k 325,805k
Parse Time 1.58s (± 0.47%) 1.58s (± 0.55%) +0.00s (+ 0.13%) 1.57s 1.61s
Bind Time 0.78s (± 0.43%) 0.78s (± 0.60%) 0.00s ( 0.00%) 0.77s 0.79s
Check Time 5.70s (± 0.47%) 5.71s (± 0.41%) +0.01s (+ 0.25%) 5.67s 5.76s
Emit Time 3.36s (± 0.61%) 3.35s (± 0.94%) -0.01s (- 0.39%) 3.29s 3.42s
Total Time 11.42s (± 0.38%) 11.42s (± 0.41%) +0.00s (+ 0.03%) 11.32s 11.53s
TFS - node (v14.15.1, x64)
Memory used 288,904k (± 0.01%) 288,944k (± 0.01%) +41k (+ 0.01%) 288,917k 289,016k
Parse Time 1.36s (± 2.38%) 1.33s (± 1.18%) -0.03s (- 2.42%) 1.30s 1.37s
Bind Time 0.75s (± 2.32%) 0.75s (± 1.93%) -0.00s (- 0.40%) 0.73s 0.79s
Check Time 5.38s (± 0.55%) 5.36s (± 0.38%) -0.02s (- 0.37%) 5.31s 5.40s
Emit Time 3.60s (± 2.04%) 3.58s (± 2.08%) -0.02s (- 0.67%) 3.43s 3.71s
Total Time 11.09s (± 0.78%) 11.02s (± 0.77%) -0.08s (- 0.70%) 10.82s 11.18s
material-ui - node (v14.15.1, x64)
Memory used 446,709k (± 0.06%) 446,637k (± 0.07%) -72k (- 0.02%) 445,646k 446,908k
Parse Time 1.89s (± 0.89%) 1.87s (± 0.40%) -0.02s (- 0.85%) 1.85s 1.89s
Bind Time 0.72s (± 1.05%) 0.72s (± 0.80%) -0.00s (- 0.14%) 0.71s 0.73s
Check Time 13.24s (± 0.77%) 13.26s (± 0.77%) +0.02s (+ 0.15%) 13.08s 13.53s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.85s (± 0.66%) 15.86s (± 0.65%) +0.01s (+ 0.04%) 15.67s 16.15s
xstate - node (v14.15.1, x64)
Memory used 541,809k (± 0.00%) 541,817k (± 0.00%) +8k (+ 0.00%) 541,772k 541,880k
Parse Time 2.61s (± 0.39%) 2.59s (± 0.39%) -0.02s (- 0.69%) 2.57s 2.61s
Bind Time 1.16s (± 1.26%) 1.15s (± 0.75%) -0.00s (- 0.26%) 1.14s 1.18s
Check Time 1.56s (± 0.73%) 1.55s (± 0.38%) -0.01s (- 0.51%) 1.54s 1.57s
Emit Time 0.08s (± 4.42%) 0.07s (± 4.66%) 🟩-0.00s (- 5.19%) 0.07s 0.08s
Total Time 5.40s (± 0.36%) 5.37s (± 0.26%) -0.03s (- 0.63%) 5.34s 5.41s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50228 10
Baseline main 10

Developer Information:

Download Benchmark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) closed this Aug 16, 2022
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) deleted the checkExpressionWorkerTable branch August 16, 2022 21:35
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
@typescript-bot TypeScript Bot (typescript-bot) assigned Daniel Rosenwasser (DanielRosenwasser) Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DanielRosenwasser @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.