GeezerVison

TypeScript Bot (@typescript-bot) pack this

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the tarball bundle task on this PR at 50a952b. You can monitor the build here.

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 50a952b. You can monitor the build here.

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at 50a952b. You can monitor the build here.

Update: The results are in!

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the parallelized Definitely Typed test suite on this PR at 50a952b. You can monitor the build here.

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at 50a952b. You can monitor the build here.

Update: The results are in!

Anders Hejlsberg (@ahejlsberg)
The results of the perf run you requested are in!

Anders Hejlsberg (@ahejlsberg) Here are the results of running the user test suite comparing main and refs/pull/50528/merge:

Everything looks good!

Heya Anders Hejlsberg (@ahejlsberg), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

Hey Ryan Cavanaugh (@RyanCavanaugh), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/133037/artifacts?artifactName=tgz&fileId=3F948668C1BD8758CB1C8E59919B3D6E945DCF3815094A729B98FCE15A366B7E02&fileName=/typescript-4.9.0-insiders.20220829.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this inline
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test faster
TypeScript Bot (@typescript-bot) test top100

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based top-repos suite on this PR at 3f66f6c. You can monitor the build here.

Update: The results are in!

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the diff-based user code test suite on this PR at 3f66f6c. You can monitor the build here.

Update: The results are in!

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the abridged perf test suite on this PR at 3f66f6c. You can monitor the build here.

Update: The results are in!

Heya Anders Hejlsberg (@ahejlsberg), I've started to run the extended test suite on this PR at 3f66f6c. You can monitor the build here.

Is this included in a published version of Typescript yet? Based on the comments in this PR thread, it sounds like it should be in Typescript 5.

I'm on Typescript 5.0.2, but getting the error "const enum member initializers can only contain literal values and other computed enum values.", which I believe shouldn't happen if I'm on a version of typescript that includes this code?

I'm copying the example from the PR:

const prefix = '/data';

const enum Routes {
  Parts = `${prefix}/parts`, // "/data/parts"
  Invoices = `${prefix}/invoices`, // "/data/invoices"
}

Is this included in a published version of Typescript yet? Based on the comments in this PR thread, it sounds like it should be in Typescript 5.

Alex von Brandenfels (@Sweater-Baron) Yes it is, your example is working perfectly fine running version 5.0.2 (see playground). If you use VSCode make sure that you use your local TypeScript version and not VSCode's version.

Is there any plan to implement enum extension like in this playground (or some other way to extend enums)?:

Is this included in a published version of Typescript yet? Based on the comments in this PR thread, it sounds like it should be in Typescript 5.

Alex von Brandenfels (@Sweater-Baron) Yes it is, your example is working perfectly fine running version 5.0.2 (see playground). If you use VSCode make sure that you use your local TypeScript version and not VSCode's version.

I have set my vscode to use 5.0.2, but im still getting the error

Jordan Christiansen (@JordanDC2) Not 100% exactly what you asked for..
But I find they work better than enums

https://www.typescriptlang.org/play?#code/MYewdgzgLgBADgJwKYDMCWAPGBeGByAegBMBDKEvAbgFgAoUSWAJRAFcokIcYBvOmATAAKJBFAgAuGAAMAJD0SpMAXwJxR46QBp+ggJJgAbiDTBOUuQuToMqtEZNmI2uspgkuDaDVp0vzNg4IAFEMDjAiJCJuPlpBGAA6JJZ2Th04wQB5BEiESRl5RRtVEBykPJdaNw8Yfx86KABPOCQYFKDQ8MiiADUSABtWTm4mlpAUNsDOTqQIqIBtAGskRvGYUaQ19umw2e6AXXraFFYwYCg0cBgAcxAoEAAKBCmpbZDdud6BoYgASl5lHQ6Ld7g83jNPgkDMZTJxfj4QY83lCHLC-pQgA

Colin Richardson (@WORMSS) yeah thats kind of what im having to work with currently, i just wish it was a capability of Enums since we can have computed values now but not computed keys

Jordan Christiansen (@JordanDC2) Not 100% exactly what you asked for.. But I find they work better than enums

https://www.typescriptlang.org/play?#code/MYewdgzgLgBADgJwKYDMCWAPGBeGByAegBMBDKEvAbgFgAoUSWAJRAFcokIcYBvOmATAAKJBFAgAuGAAMAJD0SpMAXwJxR46QBp+ggJJgAbiDTBOUuQuToMqtEZNmI2uspgkuDaDVp0vzNg4IAFEMDjAiJCJuPlpBGAA6JJZ2Th04wQB5BEiESRl5RRtVEBykPJdaNw8Yfx86KABPOCQYFKDQ8MiiADUSABtWTm4mlpAUNsDOTqQIqIBtAGskRvGYUaQ19umw2e6AXXraFFYwYCg0cBgAcxAoEAAKBCmpbZDdud6BoYgASl5lHQ6Ld7g83jNPgkDMZTJxfj4QY83lCHLC-pQgA

Man, you saved me, thank you.
This is indeed better than using enums or at least when not using literals.

Sounds weird, but I'm on Typescript 5.0.2. I'm forcing VSC to use the local installed Typescript version (which it recognizes is 5.0.2 instead of VSC's 4.9.5) and the enum values still get udnerlined with red squiggly line.

export enum TABLES {
    foo = `${config.schema}.foos`,
    bar = `${config.schema}.bars`
}

Any ideas what I'm missing here? I see the playground link posted above by Jan (@janbiasi) and it should be working for 5.0.2. But it's not.

I confirm that the project has 5.0.2 installed with npm ls typescript; only 5.0.2 and no other version exists in the workspace.

We just tried to update our code base and we noticed a ton of errors. Turns out this change basically means you cannot treat an enum as basically "just" a number anymore? No way to optionally tell TypeScript to allow "optional" values that are basically null?

This is somewhat weird, because you now can't have a fall back state and HAVE to define a "NONE" type.

enum TEST {
    ONE = 1,
    TWO
}

const foo: TEST = 0;

This now is an error. Was there any reason not to allow for a fallback here?

how come
we have strict enum usages when value is number, when using number literal or enum entry
but
we have strict enum usages when value is string, only when using enum entry - not when using string literal ?

would be really useful to not have this not so obvious difference

you can check some examples here

Gabriel-Calin Lazar (@gabriel-calin-lazar) See my comment here.

tka85 any ideas about it? Also have TS above 5 and it complains

Valery Tarelkin (@vtarelkin) Nope. No response.

An old PR is really not the best place to ask for help or report bugs. I would really suggest filing an issue if you want it to be seen by the right people.

Jake Bailey (@jakebailey) people are searching over the whole net and hope to find a clue here) maybe you could help us please?)) I have a TS above 5th version and it still complains

Please, please, please, file an issue and fill out the template.

Jake Bailey (@jakebailey) this issues comes the first google search result. I have typescript 5.1.3 and just noticed the same problem, still trying to find any relevant tickets in this repo.

If there is a solution - it might be helpful to add it here, or at least have a link somewhere in comments

Please file a new issue outlining the problem you're having