GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Prepare module resolution for resolving TS extensions by andrewbranch · Pull Request #51171 · microsoft/TypeScript

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented Oct 13, 2022

Copy link
Copy Markdown
Member

This is all the stuff from #50153 that will get reused for --moduleResolution hybrid. We don’t necessarily need to merge this first (though I tried to make it independently mergeable for the most part); I can just base --moduleResolution hybrid off of this branch, as it would be easier to review the two diffs separately.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andrew Branch (andrewbranch) added 19 commits July 28, 2022 09:20
@andrewbranch
WIP
e9f0a1a
@andrewbranch
Add extension error back unless noEmit is set
5f9cf9d
@andrewbranch
Add non-relative tests
2421cf5
@andrewbranch
Add error for importing from declaration file
660026e
@andrewbranch
Merge branch 'main' into module-resolution/minimal
2daa136
@andrewbranch
Update unit test
f49a368
@andrewbranch
Add explicit flag for importing from .ts extensions
af03675
@andrewbranch
Add module specifier resolution changes
496ef99
@andrewbranch
Add auto-import tests
458c125
@andrewbranch
Disallow relative imports into node_modules
7d64928
@andrewbranch
Ensure auto-imports don’t suggest ./node_modules;
0249e0a
@andrewbranch
Test a non-portable declaration emit issue
6242ee3
@andrewbranch
Test auto-importing TSX file
6cc0e18
@andrewbranch
Update path completions
240533a
@andrewbranch
Merge branch 'main' into module-resolution/minimal
eb9a4bb
@andrewbranch
Fix lint due to merge
619843e
@andrewbranch
Remove minimal-specific stuff
2ceb4bc
@andrewbranch
Remove minimal tests
aad7fe7
@andrewbranch
Update unit tests
7fd3e72
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) Oct 13, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 13, 2022
Andrew Branch (andrewbranch) added 4 commits October 14, 2022 09:53
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
7cca6f3
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
ea12012
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
8655cf9
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
c55c454
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Nov 8, 2022
Add --allowArbitraryExtensions, a flag for allowing arbitrary extensions on import paths #51435
Merged
Andrew Branch (andrewbranch) added 2 commits November 15, 2022 14:43
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
6e1989e
@andrewbranch
Revamp string completions ending preferences
fa188b1
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Nov 18, 2022
--moduleResolution hybrid andrewbranch/TypeScript#2
Closed
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
c6b963b
@andrewbranch

Andrew Branch (andrewbranch) commented Nov 18, 2022

Copy link
Copy Markdown
Member Author

Nothing should change here because this is mostly adding code that no existing projects are able to touch, but:

TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) run top100
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Branch (@andrewbranch), I've started to run the perf test suite on this PR at c6b963b. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 19, 2022

Copy link
Copy Markdown
Contributor

Andrew Branch (@andrewbranch)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51171
Metric main 51171 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 341,273k (± 0.01%) 341,204k (± 0.03%) -69k (- 0.02%) 340,981k 341,341k
Parse Time 1.55s (± 0.82%) 1.56s (± 0.58%) +0.01s (+ 0.39%) 1.54s 1.57s
Bind Time 0.53s (± 0.75%) 0.53s (± 0.68%) +0.00s (+ 0.56%) 0.53s 0.54s
Check Time 3.99s (± 0.83%) 4.00s (± 0.75%) +0.01s (+ 0.20%) 3.94s 4.09s
Emit Time 4.23s (± 0.69%) 4.25s (± 1.12%) +0.02s (+ 0.52%) 4.17s 4.38s
Total Time 10.30s (± 0.52%) 10.34s (± 0.56%) +0.04s (+ 0.42%) 10.25s 10.47s
Compiler-Unions - node (v18.10.0, x64)
Memory used 188,395k (± 1.07%) 187,882k (± 1.11%) -513k (- 0.27%) 185,037k 190,778k
Parse Time 0.61s (± 0.49%) 0.62s (± 0.96%) +0.00s (+ 0.65%) 0.60s 0.63s
Bind Time 0.32s (± 1.12%) 0.33s (± 1.12%) +0.00s (+ 0.62%) 0.32s 0.33s
Check Time 4.99s (± 0.84%) 5.03s (± 0.89%) +0.05s (+ 0.94%) 4.97s 5.15s
Emit Time 1.53s (± 0.81%) 1.56s (± 1.39%) +0.03s (+ 1.70%) 1.51s 1.61s
Total Time 7.46s (± 0.70%) 7.53s (± 0.86%) +0.08s (+ 1.05%) 7.41s 7.71s
Monaco - node (v18.10.0, x64)
Memory used 320,474k (± 0.02%) 320,505k (± 0.01%) +31k (+ 0.01%) 320,388k 320,557k
Parse Time 1.16s (± 1.28%) 1.15s (± 1.53%) -0.01s (- 0.60%) 1.13s 1.21s
Bind Time 0.49s (± 1.81%) 0.49s (± 2.85%) +0.00s (+ 1.03%) 0.47s 0.54s
Check Time 3.83s (± 0.88%) 3.83s (± 0.49%) +0.00s (+ 0.08%) 3.80s 3.88s
Emit Time 2.25s (± 1.05%) 2.22s (± 0.53%) -0.03s (- 1.29%) 2.20s 2.25s
Total Time 7.73s (± 0.68%) 7.70s (± 0.38%) -0.03s (- 0.35%) 7.64s 7.75s
TFS - node (v18.10.0, x64)
Memory used 283,841k (± 0.26%) 283,890k (± 0.25%) +49k (+ 0.02%) 282,815k 285,046k
Parse Time 0.95s (± 0.70%) 0.97s (± 2.23%) +0.02s (+ 2.00%) 0.94s 1.04s
Bind Time 0.45s (± 6.22%) 0.45s (± 1.71%) -0.00s (- 1.11%) 0.43s 0.46s
Check Time 3.75s (± 0.22%) 3.78s (± 0.72%) +0.03s (+ 0.91%) 3.72s 3.83s
Emit Time 2.17s (± 0.70%) 2.19s (± 0.53%) +0.01s (+ 0.51%) 2.16s 2.21s
Total Time 7.32s (± 0.49%) 7.38s (± 0.66%) +0.06s (+ 0.82%) 7.31s 7.51s
material-ui - node (v18.10.0, x64)
Memory used 435,915k (± 0.00%) 435,960k (± 0.01%) +45k (+ 0.01%) 435,873k 436,119k
Parse Time 1.33s (± 0.60%) 1.33s (± 0.39%) +0.00s (+ 0.23%) 1.32s 1.34s
Bind Time 0.49s (± 2.58%) 0.49s (± 3.23%) -0.00s (- 0.21%) 0.44s 0.51s
Check Time 10.26s (± 0.65%) 10.28s (± 0.58%) +0.01s (+ 0.14%) 10.15s 10.45s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 12.08s (± 0.62%) 12.09s (± 0.55%) +0.02s (+ 0.13%) 11.97s 12.29s
xstate - node (v18.10.0, x64)
Memory used 518,435k (± 0.02%) 518,467k (± 0.02%) +32k (+ 0.01%) 518,347k 518,661k
Parse Time 1.91s (± 0.57%) 1.91s (± 0.66%) -0.00s (- 0.16%) 1.89s 1.95s
Bind Time 0.77s (± 3.26%) 0.74s (± 3.87%) 🟩-0.03s (- 3.38%) 0.70s 0.82s
Check Time 1.03s (± 0.68%) 1.04s (± 0.56%) +0.01s (+ 0.78%) 1.02s 1.05s
Emit Time 0.05s (± 0.00%) 0.05s (± 0.00%) 0.00s ( 0.00%) 0.05s 0.05s
Total Time 3.76s (± 0.76%) 3.74s (± 0.94%) -0.02s (- 0.48%) 3.69s 3.84s
Angular - node (v16.17.1, x64)
Memory used 340,637k (± 0.01%) 340,687k (± 0.01%) +51k (+ 0.01%) 340,639k 340,753k
Parse Time 1.88s (± 0.59%) 1.88s (± 0.56%) 0.00s ( 0.00%) 1.86s 1.91s
Bind Time 0.65s (± 0.95%) 0.65s (± 1.30%) -0.00s (- 0.00%) 0.64s 0.67s
Check Time 5.16s (± 0.48%) 5.16s (± 0.48%) -0.00s (- 0.06%) 5.09s 5.22s
Emit Time 5.12s (± 0.54%) 5.07s (± 0.98%) -0.05s (- 0.98%) 4.90s 5.15s
Total Time 12.81s (± 0.37%) 12.76s (± 0.53%) -0.05s (- 0.43%) 12.58s 12.90s
Compiler-Unions - node (v16.17.1, x64)
Memory used 186,680k (± 0.02%) 186,652k (± 0.04%) -28k (- 0.01%) 186,467k 186,785k
Parse Time 0.79s (± 0.82%) 0.79s (± 0.92%) +0.00s (+ 0.51%) 0.77s 0.81s
Bind Time 0.42s (± 0.82%) 0.42s (± 0.82%) 0.00s ( 0.00%) 0.41s 0.42s
Check Time 6.05s (± 0.84%) 6.03s (± 0.70%) -0.02s (- 0.26%) 5.94s 6.15s
Emit Time 1.93s (± 0.96%) 1.93s (± 1.02%) +0.01s (+ 0.47%) 1.90s 2.00s
Total Time 9.18s (± 0.64%) 9.18s (± 0.56%) -0.00s (- 0.02%) 9.08s 9.29s
Monaco - node (v16.17.1, x64)
Memory used 319,782k (± 0.01%) 319,818k (± 0.01%) +37k (+ 0.01%) 319,727k 319,898k
Parse Time 1.42s (± 0.77%) 1.42s (± 0.79%) -0.00s (- 0.21%) 1.40s 1.45s
Bind Time 0.59s (± 0.80%) 0.59s (± 1.04%) -0.00s (- 0.34%) 0.58s 0.61s
Check Time 4.87s (± 0.42%) 4.86s (± 0.48%) -0.01s (- 0.25%) 4.80s 4.91s
Emit Time 2.75s (± 0.66%) 2.71s (± 0.96%) -0.03s (- 1.17%) 2.66s 2.76s
Total Time 9.63s (± 0.41%) 9.58s (± 0.57%) -0.05s (- 0.50%) 9.44s 9.68s
TFS - node (v16.17.1, x64)
Memory used 282,273k (± 0.02%) 282,280k (± 0.02%) +7k (+ 0.00%) 282,067k 282,342k
Parse Time 1.17s (± 0.99%) 1.16s (± 1.04%) -0.00s (- 0.17%) 1.14s 1.20s
Bind Time 0.65s (± 3.82%) 0.64s (± 4.28%) -0.01s (- 2.15%) 0.58s 0.69s
Check Time 4.75s (± 0.57%) 4.75s (± 0.39%) -0.00s (- 0.04%) 4.69s 4.78s
Emit Time 2.73s (± 2.19%) 2.72s (± 1.75%) -0.01s (- 0.44%) 2.65s 2.86s
Total Time 9.30s (± 0.93%) 9.27s (± 0.42%) -0.03s (- 0.35%) 9.22s 9.37s
material-ui - node (v16.17.1, x64)
Memory used 435,283k (± 0.01%) 435,307k (± 0.00%) +25k (+ 0.01%) 435,264k 435,342k
Parse Time 1.64s (± 0.35%) 1.63s (± 0.55%) -0.01s (- 0.55%) 1.62s 1.66s
Bind Time 0.50s (± 1.17%) 0.50s (± 0.89%) +0.00s (+ 0.20%) 0.49s 0.51s
Check Time 11.79s (± 0.85%) 11.81s (± 0.68%) +0.02s (+ 0.20%) 11.71s 12.01s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 13.93s (± 0.73%) 13.94s (± 0.55%) +0.02s (+ 0.13%) 13.85s 14.14s
xstate - node (v16.17.1, x64)
Memory used 516,062k (± 0.02%) 516,074k (± 0.01%) +12k (+ 0.00%) 515,975k 516,236k
Parse Time 2.30s (± 0.36%) 2.30s (± 0.56%) -0.00s (- 0.00%) 2.27s 2.33s
Bind Time 0.83s (± 0.96%) 0.86s (± 3.02%) +0.02s (+ 2.76%) 0.81s 0.90s
Check Time 1.35s (± 0.82%) 1.36s (± 0.77%) +0.00s (+ 0.30%) 1.34s 1.38s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.55s (± 0.45%) 4.57s (± 0.68%) +0.02s (+ 0.51%) 4.51s 4.66s
Angular - node (v14.15.1, x64)
Memory used 334,095k (± 0.01%) 334,111k (± 0.01%) +16k (+ 0.00%) 334,043k 334,175k
Parse Time 2.04s (± 0.39%) 2.04s (± 0.71%) +0.00s (+ 0.15%) 2.02s 2.07s
Bind Time 0.70s (± 0.88%) 0.70s (± 0.47%) -0.00s (- 0.14%) 0.69s 0.71s
Check Time 5.52s (± 0.73%) 5.51s (± 0.52%) -0.00s (- 0.07%) 5.46s 5.57s
Emit Time 5.34s (± 0.75%) 5.29s (± 0.77%) -0.04s (- 0.81%) 5.17s 5.37s
Total Time 13.59s (± 0.53%) 13.55s (± 0.46%) -0.04s (- 0.31%) 13.35s 13.66s
Compiler-Unions - node (v14.15.1, x64)
Memory used 181,988k (± 0.41%) 181,607k (± 0.05%) -381k (- 0.21%) 181,328k 181,746k
Parse Time 0.89s (± 0.75%) 0.89s (± 0.54%) -0.01s (- 0.67%) 0.88s 0.90s
Bind Time 0.45s (± 0.49%) 0.45s (± 0.80%) +0.00s (+ 0.67%) 0.45s 0.46s
Check Time 6.31s (± 0.29%) 6.36s (± 0.41%) +0.05s (+ 0.86%) 6.32s 6.44s
Emit Time 2.03s (± 0.52%) 2.05s (± 1.41%) +0.02s (+ 0.89%) 2.01s 2.12s
Total Time 9.68s (± 0.23%) 9.75s (± 0.40%) +0.06s (+ 0.66%) 9.67s 9.86s
Monaco - node (v14.15.1, x64)
Memory used 314,610k (± 0.01%) 314,645k (± 0.01%) +34k (+ 0.01%) 314,594k 314,752k
Parse Time 1.56s (± 0.75%) 1.57s (± 0.52%) +0.01s (+ 0.38%) 1.55s 1.59s
Bind Time 0.63s (± 0.58%) 0.64s (± 1.08%) +0.00s (+ 0.00%) 0.63s 0.66s
Check Time 5.18s (± 0.41%) 5.19s (± 0.36%) +0.01s (+ 0.21%) 5.15s 5.23s
Emit Time 2.87s (± 0.71%) 2.87s (± 0.68%) +0.00s (+ 0.03%) 2.85s 2.93s
Total Time 10.25s (± 0.34%) 10.27s (± 0.25%) +0.02s (+ 0.18%) 10.21s 10.32s
TFS - node (v14.15.1, x64)
Memory used 279,319k (± 0.00%) 279,343k (± 0.01%) +25k (+ 0.01%) 279,289k 279,418k
Parse Time 1.32s (± 0.45%) 1.33s (± 1.20%) +0.01s (+ 0.76%) 1.30s 1.37s
Bind Time 0.59s (± 0.58%) 0.59s (± 0.58%) 0.00s ( 0.00%) 0.58s 0.59s
Check Time 5.05s (± 0.34%) 5.06s (± 0.42%) +0.01s (+ 0.30%) 5.01s 5.10s
Emit Time 3.05s (± 0.55%) 3.06s (± 0.82%) +0.01s (+ 0.20%) 2.98s 3.11s
Total Time 10.01s (± 0.27%) 10.04s (± 0.19%) +0.03s (+ 0.30%) 10.00s 10.08s
material-ui - node (v14.15.1, x64)
Memory used 430,746k (± 0.00%) 430,764k (± 0.00%) +17k (+ 0.00%) 430,696k 430,796k
Parse Time 1.85s (± 0.48%) 1.87s (± 0.54%) +0.01s (+ 0.70%) 1.84s 1.89s
Bind Time 0.53s (± 0.69%) 0.53s (± 0.89%) +0.00s (+ 0.76%) 0.52s 0.54s
Check Time 12.18s (± 0.41%) 12.21s (± 0.52%) +0.03s (+ 0.24%) 12.12s 12.40s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.56s (± 0.32%) 14.60s (± 0.42%) +0.05s (+ 0.31%) 14.52s 14.80s
xstate - node (v14.15.1, x64)
Memory used 504,246k (± 0.01%) 504,267k (± 0.01%) +21k (+ 0.00%) 504,163k 504,326k
Parse Time 2.61s (± 0.57%) 2.62s (± 0.80%) +0.01s (+ 0.34%) 2.58s 2.69s
Bind Time 0.84s (± 0.71%) 0.84s (± 0.80%) +0.00s (+ 0.12%) 0.82s 0.85s
Check Time 1.47s (± 0.49%) 1.48s (± 0.49%) +0.01s (+ 0.41%) 1.46s 1.49s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 4.99s (± 0.34%) 5.00s (± 0.37%) +0.02s (+ 0.34%) 4.96s 5.05s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51171 10
Baseline main 10

TSServer

Comparison Report - main..51171
Metric main 51171 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,046ms (± 0.84%) 1,054ms (± 0.83%) +8ms (+ 0.77%) 1,037ms 1,072ms
Req 2 - geterr 2,566ms (± 0.79%) 2,600ms (± 0.69%) +34ms (+ 1.32%) 2,551ms 2,635ms
Req 3 - references 165ms (± 0.69%) 165ms (± 0.75%) +0ms (+ 0.06%) 163ms 168ms
Req 4 - navto 138ms (± 0.54%) 138ms (± 0.73%) +1ms (+ 0.51%) 136ms 141ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 62ms (± 2.17%) 61ms (± 2.29%) -1ms (- 1.45%) 58ms 65ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,103ms (± 1.02%) 1,107ms (± 0.73%) +4ms (+ 0.34%) 1,082ms 1,123ms
Req 2 - geterr 1,590ms (± 0.56%) 1,591ms (± 0.96%) +1ms (+ 0.05%) 1,571ms 1,636ms
Req 3 - references 169ms (± 0.86%) 170ms (± 1.35%) +1ms (+ 0.83%) 168ms 178ms
Req 4 - navto 150ms (± 0.35%) 152ms (± 0.96%) +2ms (+ 1.33%) 149ms 155ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 53ms (± 2.58%) 54ms (± 2.25%) +1ms (+ 1.52%) 52ms 58ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,506ms (± 0.45%) 1,511ms (± 0.63%) +5ms (+ 0.32%) 1,489ms 1,529ms
Req 2 - geterr 551ms (± 0.70%) 558ms (± 0.36%) +7ms (+ 1.25%) 553ms 563ms
Req 3 - references 59ms (± 1.73%) 58ms (± 1.53%) -1ms (- 2.37%) 57ms 61ms
Req 4 - navto 196ms (± 0.66%) 197ms (± 0.86%) +2ms (+ 0.82%) 193ms 200ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 212ms (± 0.99%) 216ms (± 0.74%) +4ms (+ 1.69%) 213ms 220ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,299ms (± 0.52%) 1,299ms (± 0.47%) +0ms (+ 0.01%) 1,280ms 1,309ms
Req 2 - geterr 3,205ms (± 0.92%) 3,228ms (± 1.60%) +23ms (+ 0.72%) 3,161ms 3,412ms
Req 3 - references 191ms (± 1.05%) 191ms (± 0.82%) -0ms (- 0.05%) 188ms 195ms
Req 4 - navto 151ms (± 0.71%) 151ms (± 0.79%) +0ms (+ 0.27%) 149ms 154ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 61ms (± 4.67%) 64ms (± 7.30%) +3ms (+ 4.60%) 57ms 72ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,385ms (± 1.10%) 1,385ms (± 0.97%) +1ms (+ 0.04%) 1,353ms 1,413ms
Req 2 - geterr 2,101ms (± 0.70%) 2,106ms (± 0.67%) +6ms (+ 0.27%) 2,070ms 2,129ms
Req 3 - references 198ms (± 0.76%) 201ms (± 0.82%) +3ms (+ 1.36%) 197ms 206ms
Req 4 - navto 164ms (± 1.34%) 166ms (± 1.23%) +3ms (+ 1.53%) 163ms 172ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 56ms (± 1.71%) 57ms (± 2.58%) +1ms (+ 1.62%) 54ms 61ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,821ms (± 0.85%) 1,816ms (± 0.58%) -6ms (- 0.31%) 1,793ms 1,835ms
Req 2 - geterr 720ms (± 0.46%) 725ms (± 0.42%) +5ms (+ 0.74%) 719ms 734ms
Req 3 - references 68ms (± 1.03%) 68ms (± 1.94%) +0ms (+ 0.44%) 65ms 72ms
Req 4 - navto 198ms (± 0.63%) 197ms (± 1.16%) -0ms (- 0.10%) 194ms 204ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 254ms (± 0.85%) 257ms (± 0.81%) +3ms (+ 1.02%) 252ms 262ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,449ms (± 0.55%) 1,450ms (± 0.36%) +1ms (+ 0.07%) 1,439ms 1,462ms
Req 2 - geterr 3,417ms (± 0.67%) 3,432ms (± 0.60%) +15ms (+ 0.43%) 3,395ms 3,482ms
Req 3 - references 205ms (± 0.81%) 206ms (± 0.99%) +1ms (+ 0.54%) 203ms 213ms
Req 4 - navto 162ms (± 0.99%) 162ms (± 0.71%) +1ms (+ 0.31%) 160ms 165ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 57ms (± 1.01%) 58ms (± 0.87%) +0ms (+ 0.35%) 56ms 58ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,520ms (± 0.45%) 1,527ms (± 0.45%) +7ms (+ 0.45%) 1,513ms 1,543ms
Req 2 - geterr 2,269ms (± 0.41%) 2,274ms (± 0.40%) +5ms (+ 0.21%) 2,253ms 2,294ms
Req 3 - references 216ms (± 1.12%) 216ms (± 1.07%) -1ms (- 0.37%) 211ms 221ms
Req 4 - navto 174ms (± 0.77%) 174ms (± 0.51%) -1ms (- 0.29%) 172ms 175ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 56ms (± 1.36%) 56ms (± 0.89%) 0ms ( 0.00%) 55ms 57ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,998ms (± 0.36%) 2,003ms (± 0.60%) +5ms (+ 0.27%) 1,979ms 2,024ms
Req 2 - geterr 747ms (± 0.70%) 745ms (± 0.36%) -2ms (- 0.29%) 740ms 753ms
Req 3 - references 74ms (± 1.44%) 72ms (± 0.82%) -1ms (- 1.63%) 71ms 74ms
Req 4 - navto 218ms (± 0.68%) 218ms (± 0.46%) -0ms (- 0.14%) 216ms 220ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 277ms (± 1.85%) 278ms (± 1.78%) +1ms (+ 0.47%) 270ms 286ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51171 10
Baseline main 10

Startup

Comparison Report - main..51171
Metric main 51171 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 117.63ms (± 0.37%) 118.49ms (± 0.43%) +0.86ms (+ 0.73%) 115.46ms 125.67ms
tsserver-startup - node (v16.17.1, x64)
Execution time 198.25ms (± 0.30%) 198.28ms (± 0.30%) +0.03ms (+ 0.01%) 195.22ms 207.23ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 191.80ms (± 0.29%) 192.48ms (± 0.35%) +0.67ms (+ 0.35%) 189.16ms 202.31ms
typescript-startup - node (v16.17.1, x64)
Execution time 177.03ms (± 0.29%) 177.49ms (± 0.31%) +0.46ms (+ 0.26%) 174.87ms 183.13ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51171 10
Baseline main 10

Developer Information:

Download Benchmark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Nov 28, 2022
--moduleResolution bundler (formerly known as hybrid) #51669
Merged
Andrew Branch (andrewbranch) added 6 commits November 28, 2022 11:56
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
7225671
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
3b1d554
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
5909643
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
c3575de
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
c4ba4a5
@andrewbranch
Merge branch 'main' into module-resolution/ts-extensions
4e73a46
@andrewbranch Andrew Branch (andrewbranch) closed this in #51669 Dec 13, 2022
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andrewbranch @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.