GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Flip imports to case insensitive sorting by jakebailey · Pull Request #51579 · microsoft/TypeScript

Conversation

@jakebailey

@jakebailey Jake Bailey (jakebailey) commented Nov 17, 2022

Copy link
Copy Markdown
Member

After merging #51565, I went to merge it into SFT only to hit issues with auto-imports; it looks like auto-imports always inserts new imports at the bottom unless the imports are sorted case-insensitivly.

Flipping these imports to case insensitive means that future auto-imports seem to be inserted in the right place.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jakebailey
Flip imports to case insensitive sorting
5d380b9
@jakebailey
Jake Bailey (jakebailey) requested review from Andrew Branch (andrewbranch) and Wesley Wigham (weswigham) November 17, 2022 22:03
@typescript-bot TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey) Nov 17, 2022
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 17, 2022
weswigham
Wesley Wigham (weswigham) approved these changes Nov 17, 2022
View reviewed changes

@weswigham Wesley Wigham (weswigham) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should file 2 bugs:

  1. To fix auto imports insertion order on case-sensitive import lists
  2. To swap our imports back once we've shipped said fix

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
saschanaz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@jakebailey

Jake Bailey (jakebailey) commented Nov 17, 2022

Copy link
Copy Markdown
Member Author

How much do we need 2? My only problem is just that it's more churn for other PRs again if I reorder everything. I suppose it's one time, but I don't know that it actually matters what the order is as long as it merges well (which any sort will do).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakebailey
Jake Bailey (jakebailey) merged commit 00dc0b6 into microsoft:main Nov 17, 2022
@jakebailey
Jake Bailey (jakebailey) deleted the reformat-imports-2 branch November 17, 2022 23:42
This was referenced Nov 21, 2022
Presence of underscore prefixed item in sorted import list causes auto-import to place new import at the end #51616
Closed
Restore case-sensitive import sorting #51617
Closed
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Dec 3, 2022
Add option for organize imports case sensitivity #51733
Merged
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham approved these changes
@andrewbranch Andrew Branch (andrewbranch) Awaiting requested review from andrewbranch

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jakebailey Jake Bailey (jakebailey)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@jakebailey @weswigham @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.