GeezerVison is showing github.com — [experiment] Try using consistent shapes for FlowNodes by jakebailey · Pull Request #51585 · microsoft/TypeScript
Conversation
This is in the spirit of #51380 but I didn't use any tooling to tell me if this was good or not. I noticed this while trying to see about another binder change, not because I used the deopt explorer or anything (the right thing to do).
Testing on my perf machine says it does help at the cost of memory, but I want to see if the perf runner says the same thing.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Jake Bailey (@jakebailey)
The results of the perf run you requested are in!
Here they are:
Comparison Report - main..51585
| Metric |
main |
51585 |
Delta |
Best |
Worst |
| Angular - node (v16.17.1, x64) |
|---|
| Memory used |
340,652k (± 0.01%) |
344,192k (± 0.02%) |
+3,541k (+ 1.04%) |
343,992k |
344,298k |
| Parse Time |
1.89s (± 0.59%) |
1.88s (± 0.52%) |
-0.01s (- 0.69%) |
1.86s |
1.90s |
| Bind Time |
0.65s (± 0.69%) |
0.65s (± 0.72%) |
+0.00s (+ 0.31%) |
0.64s |
0.66s |
| Check Time |
5.17s (± 0.67%) |
5.16s (± 0.64%) |
-0.01s (- 0.27%) |
5.07s |
5.24s |
| Emit Time |
5.14s (± 0.95%) |
5.08s (± 0.76%) |
-0.06s (- 1.11%) |
4.98s |
5.13s |
| Total Time |
12.86s (± 0.62%) |
12.77s (± 0.51%) |
-0.08s (- 0.63%) |
12.57s |
12.89s |
| Compiler-Unions - node (v16.17.1, x64) |
|---|
| Memory used |
187,635k (± 0.59%) |
188,718k (± 0.02%) |
+1,083k (+ 0.58%) |
188,625k |
188,780k |
| Parse Time |
0.80s (± 0.62%) |
0.80s (± 1.46%) |
0.00s ( 0.00%) |
0.78s |
0.82s |
| Bind Time |
0.42s (± 0.53%) |
0.42s (± 0.71%) |
-0.00s (- 0.24%) |
0.41s |
0.42s |
| Check Time |
6.06s (± 0.53%) |
6.02s (± 0.68%) |
-0.04s (- 0.68%) |
5.92s |
6.11s |
| Emit Time |
1.94s (± 0.73%) |
1.92s (± 0.52%) |
-0.01s (- 0.57%) |
1.90s |
1.94s |
| Total Time |
9.22s (± 0.27%) |
9.16s (± 0.47%) |
-0.05s (- 0.60%) |
9.06s |
9.26s |
| Monaco - node (v16.17.1, x64) |
|---|
| Memory used |
319,782k (± 0.01%) |
323,632k (± 0.01%) |
+3,850k (+ 1.20%) |
323,576k |
323,717k |
| Parse Time |
1.43s (± 0.99%) |
1.42s (± 0.39%) |
-0.01s (- 0.63%) |
1.41s |
1.43s |
| Bind Time |
0.59s (± 0.88%) |
0.59s (± 1.13%) |
-0.00s (- 0.17%) |
0.58s |
0.61s |
| Check Time |
4.86s (± 0.44%) |
4.86s (± 0.53%) |
-0.01s (- 0.18%) |
4.77s |
4.90s |
| Emit Time |
2.72s (± 0.95%) |
2.72s (± 0.82%) |
-0.01s (- 0.18%) |
2.67s |
2.77s |
| Total Time |
9.61s (± 0.58%) |
9.58s (± 0.46%) |
-0.03s (- 0.29%) |
9.47s |
9.68s |
| TFS - node (v16.17.1, x64) |
|---|
| Memory used |
282,287k (± 0.01%) |
286,748k (± 0.01%) |
+4,461k (+ 1.58%) |
286,621k |
286,780k |
| Parse Time |
1.17s (± 0.76%) |
1.16s (± 1.15%) |
-0.01s (- 0.51%) |
1.13s |
1.19s |
| Bind Time |
0.66s (± 3.83%) |
0.64s (± 4.32%) |
-0.02s (- 2.58%) |
0.58s |
0.69s |
| Check Time |
4.76s (± 0.59%) |
4.70s (± 0.42%) |
-0.06s (- 1.20%) |
4.65s |
4.73s |
| Emit Time |
2.77s (± 2.09%) |
2.73s (± 1.79%) |
-0.04s (- 1.55%) |
2.65s |
2.84s |
| Total Time |
9.35s (± 0.93%) |
9.23s (± 0.73%) |
-0.12s (- 1.33%) |
9.01s |
9.35s |
| material-ui - node (v16.17.1, x64) |
|---|
| Memory used |
435,264k (± 0.00%) |
436,826k (± 0.00%) |
+1,562k (+ 0.36%) |
436,799k |
436,859k |
| Parse Time |
1.64s (± 0.54%) |
1.65s (± 0.42%) |
+0.01s (+ 0.37%) |
1.64s |
1.66s |
| Bind Time |
0.50s (± 1.11%) |
0.50s (± 0.60%) |
-0.00s (- 0.80%) |
0.49s |
0.50s |
| Check Time |
11.86s (± 0.77%) |
11.85s (± 0.55%) |
-0.01s (- 0.11%) |
11.68s |
11.99s |
| Emit Time |
0.00s (± 0.00%) |
0.00s (± 0.00%) |
0.00s ( NaN%) |
0.00s |
0.00s |
| Total Time |
14.01s (± 0.68%) |
14.00s (± 0.47%) |
-0.01s (- 0.07%) |
13.81s |
14.12s |
| xstate - node (v16.17.1, x64) |
|---|
| Memory used |
516,029k (± 0.02%) |
519,469k (± 0.01%) |
+3,440k (+ 0.67%) |
519,373k |
519,637k |
| Parse Time |
2.30s (± 0.43%) |
2.31s (± 0.50%) |
+0.01s (+ 0.44%) |
2.28s |
2.33s |
| Bind Time |
0.83s (± 1.60%) |
0.82s (± 0.92%) |
-0.01s (- 1.08%) |
0.81s |
0.84s |
| Check Time |
1.36s (± 0.59%) |
1.35s (± 0.82%) |
-0.01s (- 0.66%) |
1.33s |
1.37s |
| Emit Time |
0.06s (± 0.00%) |
0.06s (± 0.00%) |
0.00s ( 0.00%) |
0.06s |
0.06s |
| Total Time |
4.56s (± 0.44%) |
4.55s (± 0.47%) |
-0.01s (- 0.24%) |
4.50s |
4.60s |
System
| Machine Name | ts-ci-ubuntu |
|---|
| Platform | linux 5.4.0-131-generic |
|---|
| Architecture | x64 |
|---|
| Available Memory | 16 GB |
|---|
| Available Memory | 15 GB |
|---|
| CPUs | 4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz |
|---|
Scenarios
- Angular - node (v16.17.1, x64)
- Compiler-Unions - node (v16.17.1, x64)
- Monaco - node (v16.17.1, x64)
- TFS - node (v16.17.1, x64)
- material-ui - node (v16.17.1, x64)
- xstate - node (v16.17.1, x64)
| Benchmark |
Name |
Iterations |
| Current |
51585 |
10 |
| Baseline |
main |
10 |
Developer Information:Download Benchmark |
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I'm going to close this; I think I'll have to come back to this one day with the tooling as this PR was just guesswork.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Copilot will automatically review once the pull request is marked ready for review
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|