GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Do not infer to mapped types from implied index signatures created by rest bindings by Andarist · Pull Request #52632 · microsoft/TypeScript

Conversation

@Andarist

@Andarist Mateusz Burzyński (Andarist) commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

fixes #52629

cc Andrew Branch (@andrewbranch) , it might be interesting to you given your work on #49086

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Andarist
Do not infer to mapped types from implied index signatures created by…
8470be3 
… rest bindings
@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 6, 2023
@jakebailey

Jake Bailey (jakebailey) commented Feb 7, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) user test tsserver
TypeScript Bot (@typescript-bot) test tsserver top100
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) pack this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at 8470be3. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the tarball bundle task on this PR at 8470be3. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite (tsserver) on this PR at 8470be3. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at 8470be3. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 8470be3. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite (tsserver) on this PR at 8470be3. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at 8470be3. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at 8470be3. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/145835/artifacts?artifactName=tgz&fileId=3CE1E7CDF60C71EDE447ECB5C939B7AE544A6B62E19AE2611ABD11C9EE21DAAB02&fileName=/typescript-5.0.0-insiders.20230207.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52632/merge:

Everything looks good!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52632/merge:

Everything looks good!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52632
Metric main 52632 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,868k (± 0.02%) 359,905k (± 0.02%) ~ 359,789k 359,962k p=0.229 n=6
Parse Time 4.01s (± 0.79%) 3.96s (± 1.22%) ~ 3.88s 4.01s p=0.126 n=6
Bind Time 1.18s (± 0.71%) 1.18s (± 0.44%) ~ 1.17s 1.18s p=0.070 n=6
Check Time 8.74s (± 0.64%) 8.67s (± 0.27%) -0.07s (- 0.86%) 8.63s 8.69s p=0.044 n=6
Emit Time 7.68s (± 0.94%) 7.61s (± 0.64%) ~ 7.57s 7.70s p=0.145 n=6
Total Time 21.61s (± 0.65%) 21.42s (± 0.38%) -0.19s (- 0.86%) 21.30s 21.51s p=0.037 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 193,249k (± 1.16%) 195,124k (± 1.61%) ~ 192,157k 198,093k p=0.689 n=6
Parse Time 1.62s (± 2.08%) 1.63s (± 2.03%) ~ 1.59s 1.67s p=0.803 n=6
Bind Time 0.80s (± 1.05%) 0.79s (± 0.52%) ~ 0.79s 0.80s p=0.285 n=6
Check Time 9.78s (± 0.74%) 9.73s (± 1.02%) ~ 9.61s 9.90s p=0.334 n=6
Emit Time 2.88s (± 4.68%) 2.80s (± 0.57%) ~ 2.79s 2.83s p=0.086 n=6
Total Time 15.07s (± 1.12%) 14.96s (± 0.63%) ~ 14.84s 15.08s p=0.128 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,999k (± 0.01%) 343,986k (± 0.01%) ~ 343,931k 344,058k p=0.689 n=6
Parse Time 2.96s (± 1.10%) 2.96s (± 1.08%) ~ 2.90s 2.99s p=1.000 n=6
Bind Time 1.04s (± 0.61%) 1.04s (± 0.86%) ~ 1.03s 1.05s p=1.000 n=6
Check Time 7.05s (± 0.34%) 7.04s (± 0.34%) ~ 7.00s 7.07s p=0.935 n=6
Emit Time 4.32s (± 0.62%) 4.33s (± 0.68%) ~ 4.29s 4.37s p=0.294 n=6
Total Time 15.37s (± 0.42%) 15.38s (± 0.45%) ~ 15.25s 15.44s p=0.688 n=6
TFS - node (v18.10.0, x64)
Memory used 300,395k (± 0.01%) 300,408k (± 0.00%) ~ 300,399k 300,424k p=0.170 n=6
Parse Time 2.28s (± 1.56%) 2.26s (± 2.25%) ~ 2.22s 2.34s p=0.332 n=6
Bind Time 1.17s (± 0.47%) 1.17s (± 0.64%) ~ 1.16s 1.18s p=0.476 n=6
Check Time 6.54s (± 0.97%) 6.59s (± 0.21%) ~ 6.57s 6.61s p=0.125 n=6
Emit Time 3.93s (± 0.62%) 3.94s (± 0.55%) ~ 3.91s 3.96s p=0.677 n=6
Total Time 13.93s (± 0.32%) 13.96s (± 0.41%) ~ 13.91s 14.05s p=0.571 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,861k (± 0.01%) 476,854k (± 0.00%) ~ 476,823k 476,890k p=0.521 n=6
Parse Time 3.57s (± 0.71%) 3.55s (± 0.85%) ~ 3.50s 3.59s p=0.466 n=6
Bind Time 0.97s (± 0.56%) 0.97s (± 0.84%) ~ 0.96s 0.98s p=0.088 n=6
Check Time 17.28s (± 0.64%) 17.19s (± 0.36%) ~ 17.13s 17.30s p=0.148 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.83s (± 0.50%) 21.71s (± 0.36%) ~ 21.62s 21.83s p=0.128 n=6
xstate - node (v18.10.0, x64)
Memory used 549,038k (± 0.01%) 549,179k (± 0.03%) +141k (+ 0.03%) 548,960k 549,399k p=0.045 n=6
Parse Time 4.56s (± 0.24%) 4.56s (± 0.31%) ~ 4.54s 4.58s p=0.868 n=6
Bind Time 1.71s (± 0.71%) 1.72s (± 1.13%) ~ 1.70s 1.75s p=0.567 n=6
Check Time 2.84s (± 0.69%) 2.84s (± 1.11%) ~ 2.79s 2.87s p=0.936 n=6
Emit Time 0.08s (± 4.99%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=0.405 n=6
Total Time 9.20s (± 0.31%) 9.20s (± 0.46%) ~ 9.15s 9.26s p=1.000 n=6
Angular - node (v16.17.1, x64)
Memory used 359,206k (± 0.01%) 359,227k (± 0.01%) ~ 359,188k 359,263k p=0.689 n=6
Parse Time 4.18s (± 0.36%) 4.18s (± 0.19%) ~ 4.17s 4.19s p=0.797 n=6
Bind Time 1.23s (± 0.42%) 1.22s (± 0.67%) ~ 1.21s 1.23s p=0.523 n=6
Check Time 9.48s (± 0.74%) 9.47s (± 0.40%) ~ 9.41s 9.53s p=1.000 n=6
Emit Time 8.08s (± 0.49%) 8.06s (± 0.43%) ~ 8.02s 8.10s p=0.627 n=6
Total Time 22.98s (± 0.37%) 22.93s (± 0.31%) ~ 22.85s 23.02s p=0.573 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,901k (± 0.04%) 194,507k (± 0.67%) ~ 193,925k 197,179k p=0.065 n=6
Parse Time 1.80s (± 0.23%) 1.81s (± 0.57%) ~ 1.79s 1.82s p=0.101 n=6
Bind Time 0.85s (± 1.16%) 0.84s (± 1.24%) ~ 0.83s 0.86s p=0.673 n=6
Check Time 10.42s (± 0.82%) 10.43s (± 0.75%) ~ 10.32s 10.56s p=0.810 n=6
Emit Time 3.07s (± 0.81%) 3.06s (± 0.86%) ~ 3.03s 3.10s p=0.747 n=6
Total Time 16.14s (± 0.54%) 16.14s (± 0.62%) ~ 15.99s 16.30s p=1.000 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,278k (± 0.01%) 343,281k (± 0.01%) ~ 343,243k 343,323k p=0.873 n=6
Parse Time 3.18s (± 1.07%) 3.18s (± 1.59%) ~ 3.09s 3.23s p=0.809 n=6
Bind Time 1.12s (± 0.88%) 1.11s (± 0.00%) ~ 1.11s 1.11s p=0.073 n=6
Check Time 7.72s (± 0.41%) 7.73s (± 0.54%) ~ 7.67s 7.79s p=1.000 n=6
Emit Time 4.53s (± 0.43%) 4.55s (± 0.74%) ~ 4.52s 4.61s p=0.211 n=6
Total Time 16.55s (± 0.25%) 16.57s (± 0.49%) ~ 16.48s 16.68s p=1.000 n=6
TFS - node (v16.17.1, x64)
Memory used 299,763k (± 0.00%) 299,749k (± 0.00%) ~ 299,733k 299,764k p=0.053 n=6
Parse Time 2.48s (± 1.54%) 2.47s (± 0.86%) ~ 2.44s 2.49s p=0.869 n=6
Bind Time 1.26s (± 0.50%) 1.25s (± 0.67%) ~ 1.25s 1.27s p=0.226 n=6
Check Time 7.22s (± 0.44%) 7.19s (± 0.72%) ~ 7.14s 7.28s p=0.335 n=6
Emit Time 4.23s (± 0.41%) 4.23s (± 0.69%) ~ 4.20s 4.27s p=0.747 n=6
Total Time 15.18s (± 0.32%) 15.14s (± 0.44%) ~ 15.05s 15.22s p=0.521 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,111k (± 0.00%) 476,129k (± 0.01%) ~ 476,086k 476,202k p=0.689 n=6
Parse Time 3.72s (± 0.24%) 3.72s (± 0.28%) ~ 3.70s 3.73s p=0.673 n=6
Bind Time 1.02s (± 0.50%) 1.02s (± 0.00%) ~ 1.02s 1.02s p=0.174 n=6
Check Time 18.17s (± 0.68%) 18.11s (± 0.15%) ~ 18.07s 18.15s p=0.226 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.92s (± 0.54%) 22.85s (± 0.15%) ~ 22.79s 22.89s p=0.297 n=6
xstate - node (v16.17.1, x64)
Memory used 546,780k (± 0.03%) 546,873k (± 0.01%) ~ 546,820k 546,991k p=0.378 n=6
Parse Time 4.76s (± 0.57%) 4.76s (± 0.52%) ~ 4.73s 4.79s p=0.935 n=6
Bind Time 1.79s (± 5.30%) 1.81s (± 4.05%) ~ 1.66s 1.85s p=0.803 n=6
Check Time 3.15s (± 3.68%) 3.10s (± 2.83%) ~ 3.04s 3.28s p=0.360 n=6
Emit Time 0.09s (± 4.45%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=0.405 n=6
Total Time 9.79s (± 0.49%) 9.76s (± 0.37%) ~ 9.72s 9.81s p=0.377 n=6
Angular - node (v14.15.1, x64)
Memory used 352,855k (± 0.00%) 352,861k (± 0.00%) ~ 352,849k 352,875k p=0.375 n=6
Parse Time 4.25s (± 0.38%) 4.25s (± 0.12%) ~ 4.24s 4.25s p=0.666 n=6
Bind Time 1.29s (± 0.40%) 1.29s (± 0.63%) ~ 1.28s 1.30s p=0.929 n=6
Check Time 9.76s (± 0.68%) 9.75s (± 0.42%) ~ 9.68s 9.79s p=0.688 n=6
Emit Time 8.39s (± 0.61%) 8.37s (± 0.80%) ~ 8.29s 8.45s p=0.686 n=6
Total Time 23.68s (± 0.51%) 23.65s (± 0.46%) ~ 23.49s 23.78s p=0.574 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,370k (± 0.76%) 188,951k (± 0.08%) ~ 188,763k 189,085k p=0.378 n=6
Parse Time 1.85s (± 0.74%) 1.84s (± 0.59%) ~ 1.82s 1.85s p=0.554 n=6
Bind Time 0.87s (± 1.40%) 0.86s (± 0.47%) ~ 0.86s 0.87s p=0.527 n=6
Check Time 10.54s (± 0.49%) 10.55s (± 0.40%) ~ 10.49s 10.60s p=0.870 n=6
Emit Time 3.44s (± 3.76%) 3.26s (± 5.16%) ~ 3.14s 3.50s p=0.053 n=6
Total Time 16.70s (± 0.81%) 16.51s (± 1.14%) ~ 16.34s 16.76s p=0.090 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,017k (± 0.00%) 338,027k (± 0.01%) ~ 337,996k 338,057k p=0.336 n=6
Parse Time 3.22s (± 0.85%) 3.24s (± 1.72%) ~ 3.19s 3.35s p=0.627 n=6
Bind Time 1.11s (± 0.37%) 1.11s (± 0.46%) ~ 1.11s 1.12s p=0.595 n=6
Check Time 8.07s (± 0.42%) 8.07s (± 0.43%) ~ 8.02s 8.12s p=0.747 n=6
Emit Time 4.79s (± 0.96%) 4.77s (± 0.34%) ~ 4.74s 4.78s p=0.369 n=6
Total Time 17.19s (± 0.43%) 17.20s (± 0.52%) ~ 17.09s 17.36s p=1.000 n=6
TFS - node (v14.15.1, x64)
Memory used 294,572k (± 0.00%) 294,597k (± 0.01%) +25k (+ 0.01%) 294,578k 294,627k p=0.006 n=6
Parse Time 2.75s (± 1.16%) 2.76s (± 0.36%) ~ 2.75s 2.77s p=0.801 n=6
Bind Time 1.11s (± 0.73%) 1.11s (± 0.46%) ~ 1.11s 1.12s p=0.929 n=6
Check Time 7.53s (± 0.50%) 7.52s (± 0.41%) ~ 7.49s 7.57s p=0.936 n=6
Emit Time 4.65s (± 0.54%) 4.62s (± 0.49%) ~ 4.60s 4.65s p=0.062 n=6
Total Time 16.04s (± 0.26%) 16.02s (± 0.18%) ~ 15.99s 16.06s p=0.421 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,631k (± 0.00%) 471,633k (± 0.00%) ~ 471,624k 471,640k p=0.936 n=6
Parse Time 3.96s (± 0.72%) 3.93s (± 0.41%) ~ 3.91s 3.96s p=0.086 n=6
Bind Time 1.04s (± 0.39%) 1.04s (± 0.53%) ~ 1.03s 1.04s p=0.054 n=6
Check Time 19.18s (± 0.55%) 19.10s (± 0.51%) ~ 19.00s 19.27s p=0.261 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 24.18s (± 0.47%) 24.07s (± 0.48%) ~ 23.95s 24.28s p=0.149 n=6
xstate - node (v14.15.1, x64)
Memory used 534,854k (± 0.01%) 534,861k (± 0.01%) ~ 534,800k 534,901k p=0.810 n=6
Parse Time 5.15s (± 0.80%) 5.16s (± 1.00%) ~ 5.10s 5.24s p=0.936 n=6
Bind Time 1.73s (± 0.52%) 1.72s (± 0.82%) ~ 1.70s 1.74s p=0.250 n=6
Check Time 3.14s (± 0.71%) 3.14s (± 0.31%) ~ 3.12s 3.15s p=0.866 n=6
Emit Time 0.10s (± 0.00%) 0.10s (± 4.01%) ~ 0.10s 0.11s p=0.405 n=6
Total Time 10.12s (± 0.61%) 10.12s (± 0.44%) ~ 10.08s 10.19s p=0.573 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52632 6
Baseline main 6

TSServer

Comparison Report - main..52632
Metric main 52632 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,538ms (± 1.70%) 2,508ms (± 1.51%) ~ 2,480ms 2,573ms p=0.226 n=6
Req 2 - geterr 5,556ms (± 0.54%) 5,562ms (± 0.27%) ~ 5,541ms 5,585ms p=0.378 n=6
Req 3 - references 370ms (± 0.77%) 368ms (± 0.50%) ~ 365ms 370ms p=0.369 n=6
Req 4 - navto 284ms (± 0.36%) 285ms (± 0.61%) ~ 282ms 287ms p=0.279 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 71ms (± 0.72%) 75ms (± 4.88%) +4ms (+ 4.91%) 72ms 82ms p=0.007 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,752ms (± 1.42%) 2,708ms (± 1.15%) ~ 2,661ms 2,743ms p=0.066 n=6
Req 2 - geterr 4,042ms (± 0.58%) 4,054ms (± 0.51%) ~ 4,023ms 4,087ms p=0.471 n=6
Req 3 - references 368ms (± 1.37%) 369ms (± 0.75%) ~ 364ms 371ms p=0.744 n=6
Req 4 - navto 293ms (± 0.91%) 294ms (± 0.76%) ~ 291ms 297ms p=0.418 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 66ms (± 0.78%) 66ms (± 0.62%) ~ 66ms 67ms p=0.595 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,489ms (± 0.64%) 3,487ms (± 0.69%) ~ 3,465ms 3,530ms p=1.000 n=6
Req 2 - geterr 1,646ms (± 0.69%) 1,650ms (± 0.72%) ~ 1,640ms 1,671ms p=0.688 n=6
Req 3 - references 104ms (± 1.61%) 104ms (± 2.09%) ~ 101ms 106ms p=0.805 n=6
Req 4 - navto 360ms (± 1.11%) 356ms (± 0.58%) -4ms (- 1.20%) 353ms 358ms p=0.036 n=6
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) ~ 3,175 3,175 p=1.000 n=6
Req 5 - completionInfo 445ms (± 0.95%) 446ms (± 1.21%) ~ 439ms 452ms p=0.628 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,774ms (± 0.53%) 2,778ms (± 1.00%) ~ 2,726ms 2,801ms p=0.471 n=6
Req 2 - geterr 5,923ms (± 0.72%) 5,928ms (± 0.51%) ~ 5,883ms 5,962ms p=0.689 n=6
Req 3 - references 381ms (± 0.95%) 380ms (± 0.96%) ~ 377ms 387ms p=0.685 n=6
Req 4 - navto 278ms (± 1.01%) 278ms (± 0.90%) ~ 276ms 283ms p=0.936 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 78ms (± 1.89%) 78ms (± 1.50%) ~ 76ms 79ms p=0.933 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,941ms (± 0.46%) 2,953ms (± 0.80%) ~ 2,934ms 2,996ms p=0.688 n=6
Req 2 - geterr 4,416ms (± 0.57%) 4,422ms (± 0.23%) ~ 4,411ms 4,440ms p=0.873 n=6
Req 3 - references 382ms (± 1.06%) 379ms (± 0.79%) ~ 377ms 385ms p=0.257 n=6
Req 4 - navto 288ms (± 0.81%) 288ms (± 0.36%) ~ 287ms 290ms p=0.512 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 72ms (± 1.05%) 72ms (± 1.24%) ~ 71ms 73ms p=0.798 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,637ms (± 0.24%) 3,626ms (± 0.30%) ~ 3,609ms 3,637ms p=0.092 n=6
Req 2 - geterr 1,819ms (± 1.29%) 1,825ms (± 0.74%) ~ 1,809ms 1,838ms p=0.520 n=6
Req 3 - references 113ms (± 1.42%) 114ms (± 0.55%) ~ 113ms 115ms p=0.152 n=6
Req 4 - navto 347ms (± 1.36%) 342ms (± 1.03%) -5ms (- 1.35%) 339ms 349ms p=0.044 n=6
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) ~ 3,175 3,175 p=1.000 n=6
Req 5 - completionInfo 456ms (± 1.40%) 456ms (± 0.49%) ~ 452ms 458ms p=0.686 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,906ms (± 0.67%) 2,903ms (± 0.33%) ~ 2,894ms 2,920ms p=0.936 n=6
Req 2 - geterr 6,343ms (± 1.03%) 6,322ms (± 1.16%) ~ 6,265ms 6,428ms p=0.748 n=6
Req 3 - references 390ms (± 1.04%) 391ms (± 0.64%) ~ 387ms 394ms p=1.000 n=6
Req 4 - navto 285ms (± 2.11%) 285ms (± 1.47%) ~ 278ms 290ms p=0.809 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 93ms (± 8.64%) 89ms (±11.89%) ~ 81ms 107ms p=0.567 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,116ms (± 0.72%) 3,076ms (± 0.63%) -40ms (- 1.29%) 3,053ms 3,104ms p=0.008 n=6
Req 2 - geterr 4,723ms (± 0.51%) 4,711ms (± 0.22%) ~ 4,691ms 4,720ms p=0.298 n=6
Req 3 - references 408ms (± 1.04%) 410ms (± 0.97%) ~ 406ms 416ms p=0.332 n=6
Req 4 - navto 297ms (± 0.51%) 295ms (± 0.55%) ~ 294ms 298ms p=0.185 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 87ms (± 3.29%) 86ms (± 4.70%) ~ 80ms 89ms p=0.924 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,988ms (± 0.91%) 3,992ms (± 0.34%) ~ 3,976ms 4,010ms p=0.810 n=6
Req 2 - geterr 1,809ms (± 1.11%) 1,803ms (± 1.98%) ~ 1,768ms 1,855ms p=0.575 n=6
Req 3 - references 131ms (± 3.01%) 129ms (± 3.03%) ~ 124ms 136ms p=0.687 n=6
Req 4 - navto 378ms (± 0.55%) 375ms (± 0.26%) -3ms (- 0.66%) 374ms 377ms p=0.028 n=6
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) ~ 3,175 3,175 p=1.000 n=6
Req 5 - completionInfo 476ms (± 1.81%) 467ms (± 2.58%) ~ 454ms 482ms p=0.145 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52632 6
Baseline main 6

Startup

Comparison Report - main..52632
Metric main 52632 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.26ms (± 0.20%) 142.68ms (± 0.17%) +0.42ms (+ 0.30%) 141.80ms 144.92ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 226.84ms (± 0.17%) 227.63ms (± 0.26%) +0.79ms (+ 0.35%) 226.16ms 233.31ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.85ms (± 0.19%) 229.16ms (± 0.22%) +0.30ms (+ 0.13%) 227.83ms 236.17ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.52ms (± 0.19%) 209.60ms (± 0.18%) +0.08ms (+ 0.04%) 208.69ms 214.99ms p=0.009 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52632 6
Baseline main 6

Developer Information:

Download Benchmark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52632/merge:

Everything looks good!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52632/merge:

Something interesting changed - please have a look.

Details

apache/echarts

⚠️ Note that built also had errors ⚠️ 
Req #21489 - completionInfo
    at getTextOfPropertyName (/typescript-main/built/local/tsserver.js:15718:16)
    at Object.getMemberOverrideModifierStatus (/typescript-main/built/local/tsserver.js:81902:51)
    at /typescript-main/built/local/tsserver.js:148417:43
    at Object.addNewNodeForMemberSymbol (/typescript-main/built/local/tsserver.js:145975:7)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148398:22)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148295:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148834:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147962:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147784:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134892:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178444:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176855:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #21489 - completionInfo
    at getTextOfPropertyName (/typescript-52632/built/local/tsserver.js:15718:16)
    at Object.getMemberOverrideModifierStatus (/typescript-52632/built/local/tsserver.js:81908:51)
    at /typescript-52632/built/local/tsserver.js:148423:43
    at Object.addNewNodeForMemberSymbol (/typescript-52632/built/local/tsserver.js:145981:7)
    at getEntryForMemberCompletion (/typescript-52632/built/local/tsserver.js:148404:22)
    at createCompletionEntry (/typescript-52632/built/local/tsserver.js:148301:64)
    at getCompletionEntriesFromSymbols (/typescript-52632/built/local/tsserver.js:148840:19)
    at completionInfoFromData (/typescript-52632/built/local/tsserver.js:147968:23)
    at Object.getCompletionsAtPosition (/typescript-52632/built/local/tsserver.js:147790:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52632/built/local/tsserver.js:134898:35)
    at IOSession.getCompletions (/typescript-52632/built/local/tsserver.js:178450:54)
    at completionInfo (/typescript-52632/built/local/tsserver.js:176861:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults1/apache.echarts.rawError.txt in the artifact folder

Last few requests

 
{"seq":21486,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/chart/sankey/SankeySeries.ts","line":124,"offset":8,"entryNames":["@abstract"]}}
{"seq":21487,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/chart/sankey/SankeySeries.ts","line":132,"offset":49,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":21488,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/chart/sankey/SankeySeries.ts","line":132,"offset":49,"entryNames":["readonly"]}}
{"seq":21489,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/chart/sankey/SankeySeries.ts","line":151,"offset":45,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps
  1. git clone https://github.com/apache/echarts --recurse-submodules
  2. In dir echarts, run git reset --hard 8120aaba4b523e8dee1aca0f8089d36c5096f0e5
  3. Install packages (exact steps are below, but it might be easier to follow the repo readme)
    1. In dir echarts, run npm ci --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
    2. In dir echarts/test/runTest, run npm install --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
  4. Back in the initial folder, download RepoResults1/apache.echarts.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./echarts ./apache.echarts.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

balena-io/etcher

⚠️ Note that built also had errors ⚠️ 
Req #744 - completionInfo
    at getMembersOfSymbol (/typescript-main/built/local/tsserver.js:56507:19)
    at getTypeFromTypeLiteralOrFunctionOrConstructorTypeNode (/typescript-main/built/local/tsserver.js:61285:11)
    at getTypeFromTypeNodeWorker (/typescript-main/built/local/tsserver.js:61653:16)
    at getTypeFromTypeNode (/typescript-main/built/local/tsserver.js:61579:41)
    at map (/typescript-main/built/local/tsserver.js:2512:19)
    at typeArgumentsFromTypeReferenceNode (/typescript-main/built/local/tsserver.js:59111:12)
    at getTypeFromClassOrInterfaceReference (/typescript-main/built/local/tsserver.js:58796:92)
    at getTypeReferenceType (/typescript-main/built/local/tsserver.js:58922:14)
    at getTypeFromTypeReference (/typescript-main/built/local/tsserver.js:59098:18)
    at getTypeParametersForTypeReference (/typescript-main/built/local/tsserver.js:78432:18)
    at getTypeArgumentConstraint (/typescript-main/built/local/tsserver.js:78476:28)
    at Object.getTypeArgumentConstraint (/typescript-main/built/local/tsserver.js:47127:22)
    at getConstraintOfTypeArgumentProperty (/typescript-main/built/local/tsserver.js:150796:20)
    at tryGetObjectTypeLiteralInTypeArgumentCompletionSymbols (/typescript-main/built/local/tsserver.js:150011:35)
    at tryGetGlobalSymbols (/typescript-main/built/local/tsserver.js:149654:20)
    at getCompletionData (/typescript-main/built/local/tsserver.js:149421:10)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147766:26)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134892:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178444:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176855:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #744 - completionInfo
    at getMembersOfSymbol (/typescript-52632/built/local/tsserver.js:56507:19)
    at getTypeFromTypeLiteralOrFunctionOrConstructorTypeNode (/typescript-52632/built/local/tsserver.js:61285:11)
    at getTypeFromTypeNodeWorker (/typescript-52632/built/local/tsserver.js:61653:16)
    at getTypeFromTypeNode (/typescript-52632/built/local/tsserver.js:61579:41)
    at map (/typescript-52632/built/local/tsserver.js:2512:19)
    at typeArgumentsFromTypeReferenceNode (/typescript-52632/built/local/tsserver.js:59111:12)
    at getTypeFromClassOrInterfaceReference (/typescript-52632/built/local/tsserver.js:58796:92)
    at getTypeReferenceType (/typescript-52632/built/local/tsserver.js:58922:14)
    at getTypeFromTypeReference (/typescript-52632/built/local/tsserver.js:59098:18)
    at getTypeParametersForTypeReference (/typescript-52632/built/local/tsserver.js:78438:18)
    at getTypeArgumentConstraint (/typescript-52632/built/local/tsserver.js:78482:28)
    at Object.getTypeArgumentConstraint (/typescript-52632/built/local/tsserver.js:47127:22)
    at getConstraintOfTypeArgumentProperty (/typescript-52632/built/local/tsserver.js:150802:20)
    at tryGetObjectTypeLiteralInTypeArgumentCompletionSymbols (/typescript-52632/built/local/tsserver.js:150017:35)
    at tryGetGlobalSymbols (/typescript-52632/built/local/tsserver.js:149660:20)
    at getCompletionData (/typescript-52632/built/local/tsserver.js:149427:10)
    at Object.getCompletionsAtPosition (/typescript-52632/built/local/tsserver.js:147772:26)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52632/built/local/tsserver.js:134898:35)
    at IOSession.getCompletions (/typescript-52632/built/local/tsserver.js:178450:54)
    at completionInfo (/typescript-52632/built/local/tsserver.js:176861:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults3/balena-io.etcher.rawError.txt in the artifact folder

Last few requests

 
{"seq":741,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/lib/gui/modules/child-writer.ts","line":116,"offset":4,"entryNames":["@abstract"]}}
{"seq":742,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/lib/gui/modules/child-writer.ts","line":117,"offset":4}}
{"seq":743,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/lib/gui/modules/child-writer.ts","line":118,"offset":4}}
{"seq":744,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/lib/gui/modules/child-writer.ts","line":118,"offset":53,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps
  1. git clone https://github.com/balena-io/etcher --recurse-submodules
  2. In dir etcher, run git reset --hard 748f9d9147a8f9a4983142f53a9e5c721336b8c0
  3. In dir etcher, run npm ci --prefer-offline --no-audit --no-progress --legacy-peer-deps --ignore-scripts -q
  4. Back in the initial folder, download RepoResults3/balena-io.etcher.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./etcher ./balena-io.etcher.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

codex-team/editor.js

⚠️ Note that built also had errors ⚠️ 
Req #3336 - completionInfo
    at Object.addImportFromExportedSymbol (/typescript-main/built/local/tsserver.js:140805:13)
    at /typescript-main/built/local/tsserver.js:146539:38
    at importSymbols (/typescript-main/built/local/tsserver.js:146539:11)
    at Object.addNewNodeForMemberSymbol (/typescript-main/built/local/tsserver.js:145972:11)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148398:22)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148295:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148834:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147962:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147784:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134892:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178444:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176855:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #3336 - completionInfo
    at Object.addImportFromExportedSymbol (/typescript-52632/built/local/tsserver.js:140811:13)
    at /typescript-52632/built/local/tsserver.js:146545:38
    at importSymbols (/typescript-52632/built/local/tsserver.js:146545:11)
    at Object.addNewNodeForMemberSymbol (/typescript-52632/built/local/tsserver.js:145978:11)
    at getEntryForMemberCompletion (/typescript-52632/built/local/tsserver.js:148404:22)
    at createCompletionEntry (/typescript-52632/built/local/tsserver.js:148301:64)
    at getCompletionEntriesFromSymbols (/typescript-52632/built/local/tsserver.js:148840:19)
    at completionInfoFromData (/typescript-52632/built/local/tsserver.js:147968:23)
    at Object.getCompletionsAtPosition (/typescript-52632/built/local/tsserver.js:147790:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52632/built/local/tsserver.js:134898:35)
    at IOSession.getCompletions (/typescript-52632/built/local/tsserver.js:178450:54)
    at completionInfo (/typescript-52632/built/local/tsserver.js:176861:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/codex-team.editor.js.rawError.txt in the artifact folder

Last few requests

 
{"seq":3333,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/api/caret.ts","line":30,"offset":6}}
{"seq":3334,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/api/caret.ts","line":30,"offset":6,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":3335,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/api/caret.ts","line":30,"offset":6,"entryNames":["@abstract"]}}
{"seq":3336,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/components/modules/api/caret.ts","line":40,"offset":5,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps
  1. git clone https://github.com/codex-team/editor.js --recurse-submodules
  2. In dir editor.js, run git reset --hard 551e3f10b92cf5f5bb4fbd95ac504a815526dc18
  3. Install packages (exact steps are below, but it might be easier to follow the repo readme)
    1. In dir editor.js/example/tools/checklist, run yarn install --ignore-engines --ignore-scripts --silent
    2. In dir editor.js/example/tools/code, run yarn install --ignore-engines --ignore-scripts --silent
    3. In dir editor.js/example/tools/delimiter, run yarn install --ignore-engines --ignore-scripts --silent
    4. In dir editor.js/example/tools/embed, run yarn install --ignore-engines --ignore-scripts --silent
    5. In dir editor.js/example/tools/header, run yarn install --ignore-engines --ignore-scripts --silent
    6. In dir editor.js/example/tools/image, run yarn install --ignore-engines --ignore-scripts --silent
    7. In dir editor.js/example/tools/inline-code, run yarn install --ignore-engines --ignore-scripts --silent
    8. In dir editor.js/example/tools/link, run yarn install --ignore-engines --ignore-scripts --silent
    9. In dir editor.js/example/tools/list, run yarn install --ignore-engines --ignore-scripts --silent
    10. In dir editor.js/example/tools/marker, run yarn install --ignore-engines --ignore-scripts --silent
    11. In dir editor.js/example/tools/nested-list, run yarn install --ignore-engines --ignore-scripts --silent
    12. In dir editor.js/example/tools/quote, run yarn install --ignore-engines --ignore-scripts --silent
    13. In dir editor.js/example/tools/raw, run yarn install --ignore-engines --ignore-scripts --silent
    14. In dir editor.js/example/tools/simple-image, run yarn install --ignore-engines --ignore-scripts --silent
    15. In dir editor.js/example/tools/table, run yarn install --ignore-engines --ignore-scripts --silent
    16. In dir editor.js/example/tools/text-variant-tune, run yarn install --ignore-engines --ignore-scripts --silent
    17. In dir editor.js/example/tools/warning, run yarn install --ignore-engines --ignore-scripts --silent
    18. In dir editor.js, run yarn install --ignore-engines --ignore-scripts --silent
    19. In dir editor.js/src/tools/paragraph, run yarn install --ignore-engines --ignore-scripts --silent
  4. Back in the initial folder, download RepoResults4/codex-team.editor.js.replay.txt from the artifact folder
  5. npm install --no-save @typescript/server-replay
  6. npx tsreplay ./editor.js ./codex-team.editor.js.replay.txt path/to/tsserver.js
  7. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

facebook/jest

⚠️ Note that built also had errors ⚠️ 
Req #6611 - references
    at getSymbolForProgram (/typescript-main/built/local/tsserver.js:134828:19)
    at Object.updateIsDefinitionOfReferencedSymbols (/typescript-main/built/local/tsserver.js:134803:20)
    at /typescript-main/built/local/tsserver.js:176354:54
    at getReferencesWorker (/typescript-main/built/local/tsserver.js:176351:25)
    at IOSession.getReferences (/typescript-main/built/local/tsserver.js:178192:24)
    at references (/typescript-main/built/local/tsserver.js:176736:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #6611 - references
    at getSymbolForProgram (/typescript-52632/built/local/tsserver.js:134834:19)
    at Object.updateIsDefinitionOfReferencedSymbols (/typescript-52632/built/local/tsserver.js:134809:20)
    at /typescript-52632/built/local/tsserver.js:176360:54
    at getReferencesWorker (/typescript-52632/built/local/tsserver.js:176357:25)
    at IOSession.getReferences (/typescript-52632/built/local/tsserver.js:178198:24)
    at references (/typescript-52632/built/local/tsserver.js:176742:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults1/facebook.jest.rawError.txt in the artifact folder

Last few requests

 
{"seq":6608,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/packages/jest-resolve/src/fileWalkers.ts","line":46,"offset":19}}
{"seq":6609,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/packages/jest-resolve/src/fileWalkers.ts","line":68,"offset":83,"includeExternalModuleExports":false,"triggerKind":1}}
{"seq":6610,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/packages/jest-resolve/src/fileWalkers.ts","line":83,"offset":52}}
{"seq":6611,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/packages/jest-resolve/src/fileWalkers.ts","line":119,"offset":8}}

Repro Steps
  1. git clone https://github.com/facebook/jest --recurse-submodules
  2. In dir jest, run git reset --hard be501e1029c86f9da539e13798f8da77bb71211d
  3. Back in the initial folder, download RepoResults1/facebook.jest.replay.txt from the artifact folder
  4. npm install --no-save @typescript/server-replay
  5. npx tsreplay ./jest ./facebook.jest.replay.txt path/to/tsserver.js
  6. npx tsreplay --help to learn about helpful switches for debugging, logging, etc

typeorm/typeorm

⚠️ Note that built also had errors ⚠️ 
Req #4739 - completionInfo
    at consumeTokenAndAdvanceScanner (/typescript-main/built/local/tsserver.js:166004:13)
    at processChildNode (/typescript-main/built/local/tsserver.js:165913:9)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInMappedType (/typescript-main/built/local/tsserver.js:29433:133)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInArrayType (/typescript-main/built/local/tsserver.js:29408:12)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInConditionalType (/typescript-main/built/local/tsserver.js:29416:90)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInParenthesizedTypeOrTypeOperator (/typescript-main/built/local/tsserver.js:29754:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165971:32)
    at /typescript-main/built/local/tsserver.js:165865:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29295:14)
    at forEachChildInUnionOrIntersectionType (/typescript-main/built/local/tsserver.js:29751:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInMappedType (/typescript-main/built/local/tsserver.js:29433:175)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165971:32)
    at /typescript-main/built/local/tsserver.js:165865:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29295:14)
    at forEachChildInUnionOrIntersectionType (/typescript-main/built/local/tsserver.js:29751:10)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at /typescript-main/built/local/tsserver.js:165852:9
    at visitNode2 (/typescript-main/built/local/tsserver.js:29290:18)
    at forEachChildInParameter (/typescript-main/built/local/tsserver.js:29340:177)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at processChildNode (/typescript-main/built/local/tsserver.js:165928:7)
    at processChildNodes (/typescript-main/built/local/tsserver.js:165971:32)
    at /typescript-main/built/local/tsserver.js:165865:9
    at visitNodes (/typescript-main/built/local/tsserver.js:29295:14)
    at forEachChildInMethodDeclaration (/typescript-main/built/local/tsserver.js:29369:273)
    at forEachChild (/typescript-main/built/local/tsserver.js:29804:35)
    at processNode (/typescript-main/built/local/tsserver.js:165849:5)
    at formatSpanWorker (/typescript-main/built/local/tsserver.js:165657:5)
    at /typescript-main/built/local/tsserver.js:165597:105
    at getFormattingScanner (/typescript-main/built/local/tsserver.js:164413:15)
    at Object.formatNodeGivenIndentation (/typescript-main/built/local/tsserver.js:165597:10)
    at /typescript-main/built/local/tsserver.js:148666:36
    at flatMap (/typescript-main/built/local/tsserver.js:2556:17)
    at Object.printAndFormatSnippetList (/typescript-main/built/local/tsserver.js:148664:21)
    at getEntryForMemberCompletion (/typescript-main/built/local/tsserver.js:148434:28)
    at createCompletionEntry (/typescript-main/built/local/tsserver.js:148295:64)
    at getCompletionEntriesFromSymbols (/typescript-main/built/local/tsserver.js:148834:19)
    at completionInfoFromData (/typescript-main/built/local/tsserver.js:147962:23)
    at Object.getCompletionsAtPosition (/typescript-main/built/local/tsserver.js:147784:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-main/built/local/tsserver.js:134892:35)
    at IOSession.getCompletions (/typescript-main/built/local/tsserver.js:178444:54)
    at completionInfo (/typescript-main/built/local/tsserver.js:176855:43)
    at /typescript-main/built/local/tsserver.js:179208:69
    at IOSession.executeWithRequestId (/typescript-main/built/local/tsserver.js:179200:14)
    at IOSession.executeCommand (/typescript-main/built/local/tsserver.js:179208:29)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:179250:51)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:180794:14)

Req #4739 - completionInfo
    at consumeTokenAndAdvanceScanner (/typescript-52632/built/local/tsserver.js:166010:13)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165919:9)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInMappedType (/typescript-52632/built/local/tsserver.js:29433:133)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInArrayType (/typescript-52632/built/local/tsserver.js:29408:12)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInConditionalType (/typescript-52632/built/local/tsserver.js:29416:90)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInParenthesizedTypeOrTypeOperator (/typescript-52632/built/local/tsserver.js:29754:10)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at processChildNodes (/typescript-52632/built/local/tsserver.js:165977:32)
    at /typescript-52632/built/local/tsserver.js:165871:9
    at visitNodes (/typescript-52632/built/local/tsserver.js:29295:14)
    at forEachChildInUnionOrIntersectionType (/typescript-52632/built/local/tsserver.js:29751:10)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInMappedType (/typescript-52632/built/local/tsserver.js:29433:175)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at processChildNodes (/typescript-52632/built/local/tsserver.js:165977:32)
    at /typescript-52632/built/local/tsserver.js:165871:9
    at visitNodes (/typescript-52632/built/local/tsserver.js:29295:14)
    at forEachChildInUnionOrIntersectionType (/typescript-52632/built/local/tsserver.js:29751:10)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at /typescript-52632/built/local/tsserver.js:165858:9
    at visitNode2 (/typescript-52632/built/local/tsserver.js:29290:18)
    at forEachChildInParameter (/typescript-52632/built/local/tsserver.js:29340:177)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at processChildNode (/typescript-52632/built/local/tsserver.js:165934:7)
    at processChildNodes (/typescript-52632/built/local/tsserver.js:165977:32)
    at /typescript-52632/built/local/tsserver.js:165871:9
    at visitNodes (/typescript-52632/built/local/tsserver.js:29295:14)
    at forEachChildInMethodDeclaration (/typescript-52632/built/local/tsserver.js:29369:273)
    at forEachChild (/typescript-52632/built/local/tsserver.js:29804:35)
    at processNode (/typescript-52632/built/local/tsserver.js:165855:5)
    at formatSpanWorker (/typescript-52632/built/local/tsserver.js:165663:5)
    at /typescript-52632/built/local/tsserver.js:165603:105
    at getFormattingScanner (/typescript-52632/built/local/tsserver.js:164419:15)
    at Object.formatNodeGivenIndentation (/typescript-52632/built/local/tsserver.js:165603:10)
    at /typescript-52632/built/local/tsserver.js:148672:36
    at flatMap (/typescript-52632/built/local/tsserver.js:2556:17)
    at Object.printAndFormatSnippetList (/typescript-52632/built/local/tsserver.js:148670:21)
    at getEntryForMemberCompletion (/typescript-52632/built/local/tsserver.js:148440:28)
    at createCompletionEntry (/typescript-52632/built/local/tsserver.js:148301:64)
    at getCompletionEntriesFromSymbols (/typescript-52632/built/local/tsserver.js:148840:19)
    at completionInfoFromData (/typescript-52632/built/local/tsserver.js:147968:23)
    at Object.getCompletionsAtPosition (/typescript-52632/built/local/tsserver.js:147790:24)
    at Object.getCompletionsAtPosition2 [as getCompletionsAtPosition] (/typescript-52632/built/local/tsserver.js:134898:35)
    at IOSession.getCompletions (/typescript-52632/built/local/tsserver.js:178450:54)
    at completionInfo (/typescript-52632/built/local/tsserver.js:176861:43)
    at /typescript-52632/built/local/tsserver.js:179214:69
    at IOSession.executeWithRequestId (/typescript-52632/built/local/tsserver.js:179206:14)
    at IOSession.executeCommand (/typescript-52632/built/local/tsserver.js:179214:29)
    at IOSession.onMessage (/typescript-52632/built/local/tsserver.js:179256:51)
    at Interface.<anonymous> (/typescript-52632/built/local/tsserver.js:180800:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults2/typeorm.typeorm.rawError.txt in the artifact folder

Last few requests

 
{"seq":4736,"type":"request","command":"updateOpen","arguments":{"changedFiles":[{"fileName":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","textChanges":[{"newText":" //comment","start":{"line":1,"offset":46},"end":{"line":1,"offset":46}}]}],"closedFiles":[],"openFiles":[]}}
{"seq":4737,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":7,"offset":18,"includeExternalModuleExports":false,"triggerKind":2,"triggerCharacter":" "}}
{"seq":4738,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":9,"offset":45,"includeExternalModuleExports":false,"triggerKind":2,"triggerCharacter":" "}}
{"seq":4739,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/query-builder/DeleteQueryBuilder.ts","line":17,"offset":1,"includeExternalModuleExports":false,"triggerKind":1}}

Repro Steps
  1. git clone https://github.com/typeorm/typeorm --recurse-submodules
  2. In dir typeorm, run git reset --hard 7df2ccf69d13f8f0769e614638d8badd89c181b0
  3. Back in the initial folder, download RepoResults2/typeorm.typeorm.replay.txt from the artifact folder
  4. npm install --no-save @typescript/server-replay
  5. npx tsreplay ./typeorm ./typeorm.typeorm.replay.txt path/to/tsserver.js
  6. npx tsreplay --help to learn about helpful switches for debugging, logging, etc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrewbranch
Andrew Branch (andrewbranch) requested a review from Anders Hejlsberg (ahejlsberg) February 7, 2023 17:19
@sandersn Nathan Shively-Sanders (sandersn) assigned Anders Hejlsberg (ahejlsberg) Mar 7, 2023
@sandersn
Nathan Shively-Sanders (sandersn) requested a review from Wesley Wigham (weswigham) March 7, 2023 23:36
@typescript-bot TypeScript Bot (typescript-bot) added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 7, 2023
@weswigham

Wesley Wigham (weswigham) commented Mar 16, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) run dt
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the parallelized Definitely Typed test suite on this PR at 8470be3. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the diff-based top-repos suite on this PR at 8470be3. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

Hey Wesley Wigham (@weswigham), it looks like the DT test run failed. Please check the log for more details.
You can check the log here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakebailey

Jake Bailey (jakebailey) commented Mar 16, 2023

Copy link
Copy Markdown
Member

Hm, looks like there's a conflict with main?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakebailey Jake Bailey (jakebailey) closed this Mar 16, 2023
@jakebailey Jake Bailey (jakebailey) reopened this Mar 16, 2023
@weswigham

Wesley Wigham (weswigham) commented Mar 16, 2023

Copy link
Copy Markdown
Member

Looks like it, yep.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Andarist
Merge remote-tracking branch 'origin/main' into fix/stop-inferring-fr…
af648b8 
…om-implied-index-infos-to-mapped-types
@Andarist

Mateusz Burzyński (Andarist) commented Mar 19, 2023

Copy link
Copy Markdown
Contributor Author

resolved the said conflict, Jake Bailey (@jakebailey) could you re-run the requested jobs?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakebailey

Jake Bailey (jakebailey) commented Mar 19, 2023

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) test top100
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt
TypeScript Bot (@typescript-bot) perf test this faster
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based top-repos suite on this PR at af648b8. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the abridged perf test suite on this PR at af648b8. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the parallelized Definitely Typed test suite on this PR at af648b8. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the diff-based user code test suite on this PR at af648b8. You can monitor the build here.

Update: The results are in!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Jake Bailey (@jakebailey), I've started to run the extended test suite on this PR at af648b8. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the user test suite comparing main and refs/pull/52632/merge:

Everything looks good!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52632

Metric main 52632 Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 361,043k (± 0.01%) 361,063k (± 0.01%) ~ 361,009k 361,092k p=0.109 n=6
Parse Time 3.53s (± 0.87%) 3.53s (± 0.64%) ~ 3.51s 3.57s p=0.685 n=6
Bind Time 1.18s (± 0.46%) 1.19s (± 0.53%) ~ 1.18s 1.20s p=0.201 n=6
Check Time 9.48s (± 0.49%) 9.45s (± 0.53%) ~ 9.38s 9.50s p=0.332 n=6
Emit Time 7.93s (± 0.82%) 7.91s (± 0.97%) ~ 7.81s 8.02s p=0.629 n=6
Total Time 22.13s (± 0.53%) 22.08s (± 0.43%) ~ 21.97s 22.22s p=0.574 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,558k (± 0.02%) 193,090k (± 0.66%) ~ 192,494k 195,699k p=0.298 n=6
Parse Time 1.59s (± 0.86%) 1.59s (± 0.94%) ~ 1.57s 1.61s p=0.933 n=6
Bind Time 0.82s (± 0.63%) 0.82s (± 0.92%) ~ 0.81s 0.83s p=0.784 n=6
Check Time 10.15s (± 0.87%) 10.10s (± 0.35%) ~ 10.04s 10.14s p=0.259 n=6
Emit Time 3.00s (± 0.25%) 3.01s (± 1.12%) ~ 2.95s 3.05s p=0.319 n=6
Total Time 15.56s (± 0.51%) 15.52s (± 0.20%) ~ 15.49s 15.56s p=0.332 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,570k (± 0.01%) 345,567k (± 0.01%) ~ 345,544k 345,607k p=0.471 n=6
Parse Time 2.73s (± 0.60%) 2.72s (± 0.30%) ~ 2.71s 2.73s p=0.284 n=6
Bind Time 1.09s (± 0.47%) 1.09s (± 0.37%) ~ 1.08s 1.09s p=0.114 n=6
Check Time 7.70s (± 0.41%) 7.70s (± 0.29%) ~ 7.67s 7.73s p=0.872 n=6
Emit Time 4.46s (± 0.49%) 4.44s (± 0.70%) ~ 4.39s 4.47s p=0.515 n=6
Total Time 15.98s (± 0.35%) 15.96s (± 0.25%) ~ 15.91s 16.01s p=0.421 n=6
TFS - node (v16.17.1, x64)
Memory used 299,817k (± 0.01%) 299,797k (± 0.01%) ~ 299,768k 299,824k p=0.521 n=6
Parse Time 2.17s (± 0.54%) 2.16s (± 0.24%) ~ 2.16s 2.17s p=0.191 n=6
Bind Time 1.24s (± 0.97%) 1.23s (± 0.61%) ~ 1.22s 1.24s p=0.111 n=6
Check Time 7.17s (± 0.54%) 7.15s (± 0.23%) ~ 7.13s 7.17s p=0.572 n=6
Emit Time 4.34s (± 0.63%) 4.34s (± 0.42%) ~ 4.32s 4.37s p=1.000 n=6
Total Time 14.93s (± 0.24%) 14.89s (± 0.23%) ~ 14.85s 14.95s p=0.108 n=6
material-ui - node (v16.17.1, x64)
Memory used 476,408k (± 0.01%) 476,401k (± 0.01%) ~ 476,348k 476,471k p=0.630 n=6
Parse Time 3.21s (± 0.61%) 3.23s (± 0.64%) ~ 3.20s 3.26s p=0.413 n=6
Bind Time 0.95s (± 0.43%) 0.95s (± 0.86%) ~ 0.94s 0.96s p=0.584 n=6
Check Time 17.91s (± 0.86%) 17.90s (± 0.59%) ~ 17.82s 18.08s p=0.809 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.08s (± 0.62%) 22.08s (± 0.56%) ~ 21.97s 22.29s p=0.574 n=6
xstate - node (v16.17.1, x64)
Memory used 550,624k (± 0.02%) 550,671k (± 0.02%) ~ 550,520k 550,807k p=0.298 n=6
Parse Time 3.95s (± 0.16%) 3.94s (± 0.49%) ~ 3.92s 3.97s p=0.191 n=6
Bind Time 1.80s (± 0.29%) 1.80s (± 0.55%) ~ 1.79s 1.81s p=0.348 n=6
Check Time 3.04s (± 0.34%) 3.03s (± 0.50%) ~ 3.02s 3.06s p=0.565 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 8.88s (± 0.17%) 8.87s (± 0.44%) ~ 8.83s 8.92s p=0.809 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52632 6
Baseline main 6

Developer Information:

Download Benchmark
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2023

Copy link
Copy Markdown
Contributor

Jake Bailey (@jakebailey) Here are the results of running the top-repos suite comparing main and refs/pull/52632/merge:

Everything looks good!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Mar 19, 2023

Copy link
Copy Markdown
Contributor

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
weswigham
Wesley Wigham (weswigham) approved these changes Mar 20, 2023
View reviewed changes
@weswigham
Wesley Wigham (weswigham) merged commit a5e6dee into microsoft:main Mar 20, 2023
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham approved these changes
@ahejlsberg Anders Hejlsberg (ahejlsberg) Awaiting requested review from ahejlsberg

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ahejlsberg Anders Hejlsberg (ahejlsberg)

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[4.9.5] Destructuring type inference fails on direct assignment, succeeds with intermediate variable

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Andarist @jakebailey @typescript-bot @weswigham @ahejlsberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.