GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [experiment] Run babel over output for let/const to var by jakebailey · Pull Request #52656 · microsoft/TypeScript

Conversation

Jake Bailey (jakebailey) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

This is a performance boost we already knew we'd be losing when switching to modules + esbuild, as the latter doesn't support this downleveling (yet?).

I want to retest to see how good this would be, it's probably going to be worth it to do some form of this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Run babel over output for let/const to var

1a42515

Jake Bailey (jakebailey) commented Feb 7, 2023

Copy link

Copy Markdown

Member Author

TypeScript Bot (@typescript-bot) perf test this

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Heya Jake Bailey (@jakebailey), I've started to run the perf test suite on this PR at 1a42515. You can monitor the build here.

Update: The results are in!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Feb 7, 2023

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52656

_Metric	_main	₅₂₆₅₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{359,797k (± 0.02%)}	_{358,447k (± 0.03%)}	_{-1,350k (- 0.38%)}	_358,300k	_358,548k	_{p=0.005 n=6}
_{Parse Time}	_{3.93s (± 0.90%)}	_{3.52s (± 0.45%)}	_{🟩-0.41s (-10.44%)}	_3.50s	_3.54s	_{p=0.005 n=6}
_{Bind Time}	_{1.17s (± 0.64%)}	_{1.13s (± 0.46%)}	_{🟩-0.04s (- 3.27%)}	_1.13s	_1.14s	_{p=0.004 n=6}
_{Check Time}	_{8.71s (± 0.72%)}	_{8.46s (± 0.43%)}	_{-0.25s (- 2.93%)}	_8.42s	_8.52s	_{p=0.005 n=6}
_{Emit Time}	_{7.61s (± 0.87%)}	_{7.39s (± 1.32%)}	_{-0.22s (- 2.91%)}	_7.26s	_7.55s	_{p=0.008 n=6}
_{Total Time}	_{21.42s (± 0.68%)}	_{20.50s (± 0.67%)}	_{🟩-0.92s (- 4.29%)}	_20.34s	_20.73s	_{p=0.005 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{193,220k (± 1.19%)}	_{194,214k (± 1.58%)}	_~	_191,380k	_197,145k	_{p=0.689 n=6}
_{Parse Time}	_{1.63s (± 1.32%)}	_{1.48s (± 0.35%)}	_{🟩-0.15s (- 9.28%)}	_1.48s	_1.49s	_{p=0.004 n=6}
_{Bind Time}	_{0.80s (± 0.65%)}	_{0.77s (± 0.67%)}	_{🟩-0.03s (- 3.77%)}	_0.76s	_0.77s	_{p=0.004 n=6}
_{Check Time}	_{9.75s (± 0.52%)}	_{9.56s (± 0.41%)}	_{-0.19s (- 1.97%)}	_9.51s	_9.61s	_{p=0.005 n=6}
_{Emit Time}	_{2.80s (± 1.01%)}	_{2.73s (± 1.05%)}	_{-0.07s (- 2.38%)}	_2.69s	_2.77s	_{p=0.008 n=6}
_{Total Time}	_{14.98s (± 0.46%)}	_{14.54s (± 0.40%)}	_{-0.44s (- 2.90%)}	_14.48s	_14.61s	_{p=0.005 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,965k (± 0.01%)}	_{342,807k (± 0.01%)}	_{-1,159k (- 0.34%)}	_342,750k	_342,834k	_{p=0.005 n=6}
_{Parse Time}	_{2.94s (± 0.84%)}	_{2.60s (± 1.13%)}	_{🟩-0.33s (-11.40%)}	_2.55s	_2.63s	_{p=0.005 n=6}
_{Bind Time}	_{1.04s (± 1.32%)}	_{1.02s (± 1.01%)}	_~	_1.01s	_1.04s	_{p=0.098 n=6}
_{Check Time}	_{7.07s (± 0.47%)}	_{6.89s (± 0.35%)}	_{-0.18s (- 2.57%)}	_6.86s	_6.91s	_{p=0.005 n=6}
_{Emit Time}	_{4.33s (± 1.22%)}	_{4.21s (± 0.32%)}	_{-0.12s (- 2.73%)}	_4.19s	_4.23s	_{p=0.005 n=6}
_{Total Time}	_{15.37s (± 0.45%)}	_{14.72s (± 0.33%)}	_{🟩-0.64s (- 4.19%)}	_14.68s	_14.79s	_{p=0.005 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,377k (± 0.01%)}	_{299,321k (± 0.01%)}	_{-1,055k (- 0.35%)}	_299,297k	_299,343k	_{p=0.005 n=6}
_{Parse Time}	_{2.27s (± 1.71%)}	_{2.10s (± 1.11%)}	_{🟩-0.18s (- 7.77%)}	_2.07s	_2.13s	_{p=0.005 n=6}
_{Bind Time}	_{1.17s (± 0.44%)}	_{1.14s (± 0.45%)}	_{-0.03s (- 2.57%)}	_1.13s	_1.14s	_{p=0.004 n=6}
_{Check Time}	_{6.54s (± 0.65%)}	_{6.47s (± 0.62%)}	_{-0.08s (- 1.20%)}	_6.41s	_6.51s	_{p=0.020 n=6}
_{Emit Time}	_{3.93s (± 1.01%)}	_{3.82s (± 0.66%)}	_{-0.11s (- 2.76%)}	_3.79s	_3.85s	_{p=0.005 n=6}
_{Total Time}	_{13.92s (± 0.51%)}	_{13.52s (± 0.35%)}	_{-0.40s (- 2.85%)}	_13.45s	_13.57s	_{p=0.005 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,782k (± 0.01%)}	_{475,737k (± 0.01%)}	_{-1,045k (- 0.22%)}	_475,696k	_475,792k	_{p=0.005 n=6}
_{Parse Time}	_{3.53s (± 0.46%)}	_{3.11s (± 0.24%)}	_{🟩-0.42s (-11.77%)}	_3.10s	_3.12s	_{p=0.005 n=6}
_{Bind Time}	_{0.97s (± 0.53%)}	_{0.93s (± 0.87%)}	_{🟩-0.03s (- 3.45%)}	_0.92s	_0.94s	_{p=0.004 n=6}
_{Check Time}	_{17.12s (± 0.55%)}	_{17.06s (± 0.63%)}	_~	_16.89s	_17.21s	_{p=0.469 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.61s (± 0.38%)}	_{21.11s (± 0.52%)}	_{-0.51s (- 2.35%)}	_20.93s	_21.25s	_{p=0.005 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{549,092k (± 0.03%)}	_{546,665k (± 0.02%)}	_{-2,426k (- 0.44%)}	_546,562k	_546,807k	_{p=0.005 n=6}
_{Parse Time}	_{4.58s (± 0.67%)}	_{4.03s (± 0.36%)}	_{🟩-0.55s (-12.07%)}	_4.01s	_4.05s	_{p=0.005 n=6}
_{Bind Time}	_{1.71s (± 1.26%)}	_{1.67s (± 0.82%)}	_{-0.05s (- 2.82%)}	_1.65s	_1.69s	_{p=0.006 n=6}
_{Check Time}	_{2.81s (± 0.54%)}	_{2.75s (± 0.92%)}	_{-0.06s (- 2.31%)}	_2.73s	_2.80s	_{p=0.007 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 6.19%)}	_~	_0.08s	_0.09s	_{p=0.174 n=6}
_{Total Time}	_{9.20s (± 0.25%)}	_{8.53s (± 0.38%)}	_{🟩-0.67s (- 7.32%)}	_8.49s	_8.59s	_{p=0.005 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,144k (± 0.01%)}	_{357,763k (± 0.01%)}	_{-1,381k (- 0.38%)}	_357,733k	_357,806k	_{p=0.005 n=6}
_{Parse Time}	_{4.17s (± 0.45%)}	_{3.69s (± 0.44%)}	_{🟩-0.47s (-11.32%)}	_3.68s	_3.72s	_{p=0.005 n=6}
_{Bind Time}	_{1.24s (± 0.41%)}	_{1.19s (± 0.86%)}	_{🟩-0.05s (- 4.02%)}	_1.18s	_1.21s	_{p=0.004 n=6}
_{Check Time}	_{9.49s (± 0.19%)}	_{9.23s (± 0.23%)}	_{-0.26s (- 2.72%)}	_9.21s	_9.27s	_{p=0.005 n=6}
_{Emit Time}	_{8.06s (± 0.35%)}	_{7.91s (± 0.73%)}	_{-0.15s (- 1.90%)}	_7.84s	_7.99s	_{p=0.004 n=6}
_{Total Time}	_{22.96s (± 0.23%)}	_{22.02s (± 0.32%)}	_{🟩-0.94s (- 4.07%)}	_21.96s	_22.14s	_{p=0.005 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,814k (± 0.04%)}	_{193,031k (± 0.02%)}	_{-783k (- 0.40%)}	_192,959k	_193,064k	_{p=0.005 n=6}
_{Parse Time}	_{1.80s (± 0.93%)}	_{1.57s (± 0.87%)}	_{🟩-0.23s (-12.96%)}	_1.55s	_1.59s	_{p=0.005 n=6}
_{Bind Time}	_{0.84s (± 0.00%)}	_{0.82s (± 0.50%)}	_{-0.02s (- 2.18%)}	_0.82s	_0.83s	_{p=0.002 n=6}
_{Check Time}	_{10.42s (± 0.35%)}	_{10.10s (± 0.73%)}	_{🟩-0.32s (- 3.04%)}	_10.01s	_10.20s	_{p=0.005 n=6}
_{Emit Time}	_{3.10s (± 4.70%)}	_{3.01s (± 0.91%)}	_{🟩-0.10s (- 3.17%)}	_2.97s	_3.05s	_{p=0.024 n=6}
_{Total Time}	_{16.17s (± 1.07%)}	_{15.50s (± 0.38%)}	_{🟩-0.67s (- 4.16%)}	_15.41s	_15.55s	_{p=0.005 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,232k (± 0.01%)}	_{342,073k (± 0.01%)}	_{-1,159k (- 0.34%)}	_342,035k	_342,106k	_{p=0.005 n=6}
_{Parse Time}	_{3.14s (± 1.50%)}	_{2.78s (± 1.13%)}	_{🟩-0.36s (-11.52%)}	_2.74s	_2.82s	_{p=0.005 n=6}
_{Bind Time}	_{1.11s (± 1.51%)}	_{1.08s (± 0.48%)}	_{-0.03s (- 2.40%)}	_1.08s	_1.09s	_{p=0.024 n=6}
_{Check Time}	_{7.73s (± 0.25%)}	_{7.50s (± 0.39%)}	_{🟩-0.23s (- 3.02%)}	_7.46s	_7.53s	_{p=0.005 n=6}
_{Emit Time}	_{4.54s (± 0.46%)}	_{4.46s (± 0.94%)}	_{-0.08s (- 1.73%)}	_4.40s	_4.51s	_{p=0.005 n=6}
_{Total Time}	_{16.51s (± 0.50%)}	_{15.82s (± 0.50%)}	_{🟩-0.70s (- 4.22%)}	_15.69s	_15.90s	_{p=0.005 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,706k (± 0.01%)}	_{298,645k (± 0.01%)}	_{-1,061k (- 0.35%)}	_298,626k	_298,663k	_{p=0.005 n=6}
_{Parse Time}	_{2.46s (± 0.99%)}	_{2.21s (± 0.50%)}	_{🟩-0.25s (-10.16%)}	_2.20s	_2.22s	_{p=0.004 n=6}
_{Bind Time}	_{1.26s (± 0.82%)}	_{1.23s (± 1.03%)}	_{-0.03s (- 2.12%)}	_1.22s	_1.25s	_{p=0.012 n=6}
_{Check Time}	_{7.21s (± 0.39%)}	_{7.09s (± 0.61%)}	_{-0.12s (- 1.66%)}	_7.05s	_7.15s	_{p=0.005 n=6}
_{Emit Time}	_{4.22s (± 0.21%)}	_{4.31s (± 0.76%)}	_{+0.09s (+ 2.05%)}	_4.27s	_4.35s	_{p=0.005 n=6}
_{Total Time}	_{15.15s (± 0.23%)}	_{14.84s (± 0.46%)}	_{-0.31s (- 2.04%)}	_14.76s	_14.94s	_{p=0.005 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,012k (± 0.01%)}	_{475,060k (± 0.01%)}	_{-952k (- 0.20%)}	_475,033k	_475,101k	_{p=0.005 n=6}
_{Parse Time}	_{3.68s (± 0.14%)}	_{3.29s (± 0.23%)}	_{🟩-0.39s (-10.47%)}	_3.28s	_3.30s	_{p=0.004 n=6}
_{Bind Time}	_{1.02s (± 0.40%)}	_{0.97s (± 0.78%)}	_{🟩-0.05s (- 4.91%)}	_0.96s	_0.98s	_{p=0.003 n=6}
_{Check Time}	_{18.21s (± 0.67%)}	_{17.91s (± 0.37%)}	_{-0.30s (- 1.66%)}	_17.81s	_17.97s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.91s (± 0.54%)}	_{22.17s (± 0.26%)}	_{🟩-0.74s (- 3.22%)}	_22.08s	_22.23s	_{p=0.005 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,665k (± 0.01%)}	_{544,187k (± 0.02%)}	_{-2,477k (- 0.45%)}	_544,121k	_544,373k	_{p=0.005 n=6}
_{Parse Time}	_{4.77s (± 0.22%)}	_{4.22s (± 0.30%)}	_{🟩-0.55s (-11.47%)}	_4.20s	_4.23s	_{p=0.004 n=6}
_{Bind Time}	_{1.84s (± 0.28%)}	_{1.73s (± 0.44%)}	_{🟩-0.11s (- 6.24%)}	_1.72s	_1.74s	_{p=0.004 n=6}
_{Check Time}	_{3.06s (± 0.65%)}	_{2.97s (± 0.56%)}	_{-0.09s (- 2.94%)}	_2.94s	_2.99s	_{p=0.005 n=6}
_{Emit Time}	_{0.09s (± 4.45%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=0.405 n=6}
_{Total Time}	_{9.76s (± 0.29%)}	_{9.01s (± 0.33%)}	_{🟩-0.75s (- 7.68%)}	_8.97s	_9.04s	_{p=0.005 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{352,818k (± 0.01%)}	_{351,944k (± 0.00%)}	_{-874k (- 0.25%)}	_351,918k	_351,956k	_{p=0.005 n=6}
_{Parse Time}	_{4.23s (± 0.35%)}	_{3.74s (± 0.53%)}	_{🟩-0.49s (-11.55%)}	_3.72s	_3.77s	_{p=0.005 n=6}
_{Bind Time}	_{1.28s (± 0.80%)}	_{1.25s (± 0.51%)}	_{-0.03s (- 2.60%)}	_1.24s	_1.26s	_{p=0.004 n=6}
_{Check Time}	_{9.74s (± 0.71%)}	_{9.66s (± 0.33%)}	_~	_9.62s	_9.70s	_{p=0.065 n=6}
_{Emit Time}	_{8.37s (± 0.54%)}	_{8.20s (± 0.64%)}	_{-0.17s (- 2.01%)}	_8.16s	_8.30s	_{p=0.006 n=6}
_{Total Time}	_{23.61s (± 0.42%)}	_{22.85s (± 0.22%)}	_{🟩-0.77s (- 3.24%)}	_22.77s	_22.92s	_{p=0.005 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{188,784k (± 0.05%)}	_{188,435k (± 0.01%)}	_{-348k (- 0.18%)}	_188,417k	_188,455k	_{p=0.005 n=6}
_{Parse Time}	_{1.83s (± 0.41%)}	_{1.59s (± 0.51%)}	_{🟩-0.25s (-13.38%)}	_1.58s	_1.60s	_{p=0.004 n=6}
_{Bind Time}	_{0.87s (± 0.97%)}	_{0.85s (± 0.61%)}	_{-0.02s (- 2.12%)}	_0.84s	_0.85s	_{p=0.004 n=6}
_{Check Time}	_{10.50s (± 0.59%)}	_{10.26s (± 0.37%)}	_{-0.24s (- 2.25%)}	_10.19s	_10.29s	_{p=0.005 n=6}
_{Emit Time}	_{3.39s (± 3.89%)}	_{3.08s (± 0.93%)}	_{🟩-0.31s (- 9.14%)}	_3.04s	_3.12s	_{p=0.005 n=6}
_{Total Time}	_{16.59s (± 1.03%)}	_{15.78s (± 0.32%)}	_{🟩-0.81s (- 4.89%)}	_15.70s	_15.85s	_{p=0.005 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{337,993k (± 0.00%)}	_{337,278k (± 0.01%)}	_{-715k (- 0.21%)}	_337,262k	_337,310k	_{p=0.005 n=6}
_{Parse Time}	_{3.20s (± 0.67%)}	_{2.87s (± 0.36%)}	_{🟩-0.33s (-10.16%)}	_2.86s	_2.89s	_{p=0.005 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.12s (± 0.49%)}	_~	_1.11s	_1.12s	_{p=0.640 n=6}
_{Check Time}	_{8.11s (± 0.56%)}	_{7.96s (± 0.81%)}	_{-0.15s (- 1.85%)}	_7.86s	_8.03s	_{p=0.005 n=6}
_{Emit Time}	_{4.80s (± 0.83%)}	_{4.55s (± 0.98%)}	_{🟩-0.25s (- 5.27%)}	_4.49s	_4.60s	_{p=0.005 n=6}
_{Total Time}	_{17.23s (± 0.34%)}	_{16.50s (± 0.51%)}	_{🟩-0.73s (- 4.22%)}	_16.33s	_16.56s	_{p=0.005 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,575k (± 0.01%)}	_{293,924k (± 0.01%)}	_{-651k (- 0.22%)}	_293,884k	_293,941k	_{p=0.005 n=6}
_{Parse Time}	_{2.74s (± 0.68%)}	_{2.42s (± 0.48%)}	_{🟩-0.32s (-11.78%)}	_2.41s	_2.44s	_{p=0.005 n=6}
_{Bind Time}	_{1.11s (± 0.95%)}	_{1.08s (± 0.50%)}	_{-0.02s (- 1.81%)}	_1.08s	_1.09s	_{p=0.008 n=6}
_{Check Time}	_{7.51s (± 0.47%)}	_{7.45s (± 0.40%)}	_{-0.07s (- 0.93%)}	_7.41s	_7.48s	_{p=0.013 n=6}
_{Emit Time}	_{4.63s (± 1.03%)}	_{4.29s (± 1.01%)}	_{🟩-0.34s (- 7.31%)}	_4.21s	_4.33s	_{p=0.005 n=6}
_{Total Time}	_{15.99s (± 0.44%)}	_{15.24s (± 0.43%)}	_{🟩-0.75s (- 4.69%)}	_15.12s	_15.31s	_{p=0.005 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,622k (± 0.00%)}	_{470,749k (± 0.01%)}	_{-873k (- 0.19%)}	_470,722k	_470,778k	_{p=0.005 n=6}
_{Parse Time}	_{3.88s (± 0.72%)}	_{3.44s (± 0.61%)}	_{🟩-0.44s (-11.26%)}	_3.42s	_3.48s	_{p=0.005 n=6}
_{Bind Time}	_{1.05s (± 0.00%)}	_{1.01s (± 0.40%)}	_{🟩-0.04s (- 3.97%)}	_1.00s	_1.01s	_{p=0.002 n=6}
_{Check Time}	_{19.14s (± 0.77%)}	_{18.92s (± 0.31%)}	_{-0.22s (- 1.16%)}	_18.82s	_18.99s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{24.07s (± 0.57%)}	_{23.37s (± 0.23%)}	_{-0.70s (- 2.89%)}	_23.27s	_23.42s	_{p=0.005 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{534,749k (± 0.00%)}	_{533,029k (± 0.02%)}	_{-1,721k (- 0.32%)}	_532,837k	_533,091k	_{p=0.005 n=6}
_{Parse Time}	_{5.12s (± 0.82%)}	_{4.36s (± 0.23%)}	_{🟩-0.76s (-14.87%)}	_4.35s	_4.37s	_{p=0.005 n=6}
_{Bind Time}	_{1.71s (± 0.60%)}	_{1.76s (± 0.78%)}	_{+0.06s (+ 3.42%)}	_1.74s	_1.78s	_{p=0.004 n=6}
_{Check Time}	_{3.13s (± 0.48%)}	_{3.14s (± 0.70%)}	_~	_3.11s	_3.17s	_{p=0.256 n=6}
_{Emit Time}	_{0.10s (± 4.01%)}	_{0.09s (± 0.00%)}	_{🟩-0.01s (-11.48%)}	_0.09s	_0.09s	_{p=0.002 n=6}
_{Total Time}	_{10.06s (± 0.36%)}	_{9.36s (± 0.34%)}	_{🟩-0.70s (- 6.96%)}	_9.32s	_9.40s	_{p=0.005 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₅₆	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52656

_Metric	_main	₅₂₆₅₆	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,496ms (± 1.28%)}	_{2,378ms (± 1.33%)}	_{🟩-118ms (- 4.73%)}	_2,338ms	_2,422ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,511ms (± 0.57%)}	_{5,413ms (± 0.51%)}	_{-98ms (- 1.77%)}	_5,375ms	_5,452ms	_{p=0.005 n=6}
_{Req 3 - references}	_{370ms (± 1.13%)}	_{345ms (± 1.33%)}	_{🟩-25ms (- 6.77%)}	_340ms	_353ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{284ms (± 0.99%)}	_{277ms (± 0.90%)}	_{-7ms (- 2.52%)}	_272ms	_279ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 1.03%)}	_{69ms (± 5.72%)}	_~	_67ms	_77ms	_{p=0.061 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,739ms (± 0.79%)}	_{2,494ms (± 0.89%)}	_{🟩-245ms (- 8.93%)}	_2,459ms	_2,522ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{4,059ms (± 0.64%)}	_{3,990ms (± 0.63%)}	_{-69ms (- 1.70%)}	_3,959ms	_4,035ms	_{p=0.008 n=6}
_{Req 3 - references}	_{368ms (± 0.72%)}	_{362ms (± 0.69%)}	_{-6ms (- 1.63%)}	_359ms	_366ms	_{p=0.013 n=6}
_{Req 4 - navto}	_{293ms (± 0.88%)}	_{293ms (± 0.91%)}	_~	_290ms	_298ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{66ms (± 0.79%)}	_{66ms (± 9.84%)}	_~	_62ms	_77ms	_{p=0.366 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,490ms (± 0.82%)}	_{3,181ms (± 0.70%)}	_{🟩-309ms (- 8.85%)}	_3,145ms	_3,204ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,648ms (± 0.66%)}	_{1,682ms (± 1.35%)}	_{+35ms (+ 2.09%)}	_1,657ms	_1,711ms	_{p=0.005 n=6}
_{Req 3 - references}	_{104ms (± 1.05%)}	_{103ms (± 2.07%)}	_~	_101ms	_106ms	_{p=0.566 n=6}
_{Req 4 - navto}	_{355ms (± 0.53%)}	_{367ms (± 0.93%)}	_{+13ms (+ 3.57%)}	_363ms	_373ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_{3,175 (± 0.00%)}	_{3,175 (± 0.00%)}	_~	_3,175	_3,175	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{450ms (± 0.90%)}	_{445ms (± 1.17%)}	_~	_439ms	_452ms	_{p=0.092 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,770ms (± 0.58%)}	_{2,529ms (± 0.91%)}	_{🟩-242ms (- 8.72%)}	_2,496ms	_2,554ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{5,930ms (± 0.53%)}	_{5,774ms (± 0.36%)}	_{-156ms (- 2.63%)}	_5,743ms	_5,800ms	_{p=0.005 n=6}
_{Req 3 - references}	_{377ms (± 0.76%)}	_{360ms (± 0.49%)}	_{🟩-18ms (- 4.64%)}	_357ms	_362ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{277ms (± 0.91%)}	_{265ms (± 0.67%)}	_{🟩-12ms (- 4.33%)}	_263ms	_268ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 2.70%)}	_{88ms (± 2.42%)}	_{+9ms (+11.37%)}	_84ms	_90ms	_{p=0.005 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,924ms (± 0.37%)}	_{2,654ms (± 1.00%)}	_{🟩-270ms (- 9.23%)}	_2,615ms	_2,692ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{4,412ms (± 0.53%)}	_{4,332ms (± 0.38%)}	_{-81ms (- 1.82%)}	_4,308ms	_4,352ms	_{p=0.005 n=6}
_{Req 3 - references}	_{382ms (± 1.07%)}	_{376ms (± 0.48%)}	_{-6ms (- 1.66%)}	_373ms	_378ms	_{p=0.036 n=6}
_{Req 4 - navto}	_{287ms (± 0.56%)}	_{284ms (± 0.36%)}	_{-4ms (- 1.22%)}	_282ms	_285ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{71ms (± 0.57%)}	_{67ms (± 1.26%)}	_{🟩-5ms (- 6.56%)}	_65ms	_67ms	_{p=0.003 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,626ms (± 0.35%)}	_{3,341ms (± 0.52%)}	_{🟩-285ms (- 7.86%)}	_3,319ms	_3,362ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,825ms (± 1.51%)}	_{2,014ms (± 2.38%)}	_{+189ms (+10.37%)}	_1,923ms	_2,049ms	_{p=0.005 n=6}
_{Req 3 - references}	_{113ms (± 1.42%)}	_{110ms (± 2.07%)}	_{-3ms (- 2.51%)}	_106ms	_112ms	_{p=0.034 n=6}
_{Req 4 - navto}	_{344ms (± 1.02%)}	_{355ms (± 0.95%)}	_{+11ms (+ 3.15%)}	_349ms	_358ms	_{p=0.006 n=6}
_{Req 5 - completionInfo count}	_{3,175 (± 0.00%)}	_{3,175 (± 0.00%)}	_~	_3,175	_3,175	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{457ms (± 0.99%)}	_{450ms (± 1.43%)}	_~	_443ms	_462ms	_{p=0.064 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,884ms (± 0.28%)}	_{2,589ms (± 0.51%)}	_{🟩-295ms (-10.22%)}	_2,572ms	_2,604ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{6,277ms (± 0.73%)}	_{6,207ms (± 0.59%)}	_{-70ms (- 1.11%)}	_6,156ms	_6,250ms	_{p=0.020 n=6}
_{Req 3 - references}	_{391ms (± 0.53%)}	_{368ms (± 0.48%)}	_{🟩-23ms (- 5.85%)}	_365ms	_370ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{280ms (± 1.31%)}	_{279ms (± 0.67%)}	_~	_278ms	_283ms	_{p=0.933 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{99ms (± 1.69%)}	_{98ms (± 2.29%)}	_~	_94ms	_100ms	_{p=0.676 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,038ms (± 0.96%)}	_{2,772ms (± 0.97%)}	_{🟩-266ms (- 8.75%)}	_2,735ms	_2,811ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{4,695ms (± 0.40%)}	_{4,642ms (± 1.86%)}	_~	_4,468ms	_4,700ms	_{p=0.093 n=6}
_{Req 3 - references}	_{404ms (± 0.43%)}	_{388ms (± 0.53%)}	_{🟩-16ms (- 3.96%)}	_386ms	_391ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{293ms (± 1.30%)}	_{287ms (± 1.15%)}	_{-6ms (- 1.94%)}	_284ms	_293ms	_{p=0.035 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 3.84%)}	_{82ms (± 7.67%)}	_~	_79ms	_95ms	_{p=0.230 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,955ms (± 0.60%)}	_{3,628ms (± 0.52%)}	_{🟩-327ms (- 8.27%)}	_3,600ms	_3,655ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,776ms (± 1.68%)}	_{1,804ms (± 0.78%)}	_~	_1,785ms	_1,825ms	_{p=0.066 n=6}
_{Req 3 - references}	_{133ms (± 1.99%)}	_{124ms (± 1.56%)}	_{🟩-9ms (- 6.88%)}	_121ms	_126ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{375ms (± 0.95%)}	_{383ms (± 0.47%)}	_{+8ms (+ 2.13%)}	_381ms	_386ms	_{p=0.005 n=6}
_{Req 5 - completionInfo count}	_{3,175 (± 0.00%)}	_{3,175 (± 0.00%)}	_~	_3,175	_3,175	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{470ms (± 2.40%)}	_{461ms (± 0.60%)}	_~	_457ms	_465ms	_{p=0.297 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₅₆	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52656

_Metric	_main	₅₂₆₅₆	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.53ms (± 0.21%)}	_{140.66ms (± 0.18%)}	_{-1.87ms (- 1.31%)}	_140.03ms	_143.81ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{227.47ms (± 0.18%)}	_{223.95ms (± 0.18%)}	_{-3.52ms (- 1.55%)}	_222.71ms	_227.24ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{228.98ms (± 0.13%)}	_{228.47ms (± 0.41%)}	_{-0.51ms (- 0.22%)}	_225.12ms	_239.95ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{209.74ms (± 0.15%)}	_{209.00ms (± 0.37%)}	_{-0.74ms (- 0.35%)}	_206.25ms	_214.83ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₆₅₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

SlurpTheo, guilhermesimoes, and q1blue reacted with eyes emoji

All reactions

👀 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) commented Feb 7, 2023

Copy link

Copy Markdown

Contributor

Not bad results 😉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 7, 2023

Copy link

Copy Markdown

Member Author

Yeah, though this was already known when we merged modules and gave up var downleveling. Really unfortunate that this helps so much; I'm trying to figure out if there's some subset of variables that can be changed or if it's just a million papercuts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

What’s the concern here though? Just the build time?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Well, I wouldn't merge this as-is because (in no particular order):

It introduces another third-party dep into the critical build chain, which right now is solely tsc and esbuild, and we have the ability to drop the latter if needed.
- Though, arguably, the latter wouldn't be great for performance either, so what's the point in avoiding it?
It slows down the build, and I don't really want to re-introduce the idea of a "release" build of TypeScript.
- But, we can just keep let/const for tests and catch violations not already caught by TS that way.
Loops get rewritten, which makes the files annoying to use while debugging; preferrably there would be a performance-focused variant of the transform which only did the "easy" ones.
- Again, could be non-test only.
babel deoptimizes the files because they're so big, which effectively makes them as hard to patch as minified versions of TypeScript, and we have an unreasonable number of people who do that. I half-mitigated this by rerunning the output through esbuild, though that was to try and avoid the perf diff showing a startup speed boots from the simple fact that the files are smaller.
- But, it could be implemented in esbuild directly.
Long term, I think it'd be bad to be ESM but have export var (which I believe is slower for consumers because they are live bindings and not const).
- Then again, esbuild already does this, so maybe it is something that can be pushed down to esbuild, much to everyone's chagrin.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Fix Node 14

0cf726a

Jake Bailey (jakebailey) commented Feb 7, 2023

Copy link

Copy Markdown

Member Author

It slows down the build

On the whole though, the "big" build tasks don't actually get longer because esbuild/babel are running in parallel with dts emit / bundling, but the actual bundle tasks go from half a second to 8 seconds, which isn't great for the debugging loop.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Feb 7, 2023

Module conversion tracking issue / notes #49332

Closed

Is TDZ avoidance still needed? evanw/esbuild#2889

Closed

Bruce Pascoe (fatcerberus) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

I assume the performance hit for let/const vs. var is down to TDZ tracking. Which is unfortunate because var has enough footguns that I’d never use it directly in a codebase and I’m not running babel over my code as a build step just to change all the lets to vars.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 7, 2023

Copy link

Copy Markdown

Member Author

Yep, it's TDZ. I'm trying to figure out if there's a limited subset that can be changed to make parsing faster but it's not really turning out well.

fatcerberus reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Bruce Pascoe (fatcerberus) commented Feb 7, 2023

Copy link

Copy Markdown

It’s weird because most potential TDZ violations can be detected syntactically so engines should have figured out how to optimize it away by now.

robpalme reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 7, 2023

Copy link

Copy Markdown

Member Author

I would certainly think. But at this point I'm having a hard time justifying not doing some form of this change.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey)

Feb 7, 2023

TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels

Feb 7, 2023

Jake Bailey (jakebailey) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

If people are stumbling on this, last time I tested this, it was 5-9%, and now it's more like 7-15%; the relative proportion has changed because we've increased the performance of the TS compiler since modules has merged meaning the fixed perf bump here is now a bigger overall proportion.

electron-space and guilhermesimoes reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Pass --compact false rather than rerunning through esbuild

56c226a

Jake Bailey (jakebailey) commented Feb 8, 2023

Copy link

Copy Markdown

Member Author

I hacked up TypeScript and ts-perf to run this PR against bun v0.5.5. It doesn't seem like the engine Bun uses (Apple's JavaScriptCore) is affected by the TDZ problem; I'd chalk up any perf differences below to noise.

Note that these benchmark results are not comparable to the ones earlier in this thread; I performed these tests on an entirely different perf-tuned machine in my office, not the corp-owned machine that we normally use. But, I probably will try and upstream my hacks to ts-perf as I've been wanting to test some more interesting hosts.

Details

Loading benchmark and comparing to baseline.
Comparison Report - main..HEAD

_Metric	_main	_HEAD	_Delta	_Best	_Worst	_p-value
_{Angular - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{2.57s (± 0.53%)}	_{2.53s (± 2.39%)}	_~	_2.49s	_2.65s	_{p=0.064 n=6}
_{Bind Time}	_{1.05s (± 0.85%)}	_{1.05s (± 1.55%)}	_~	_1.03s	_1.08s	_{p=0.801 n=6}
_{Check Time}	_{9.85s (± 0.58%)}	_{9.81s (± 0.49%)}	_~	_9.76s	_9.89s	_{p=0.261 n=6}
_{Emit Time}	_{8.69s (± 0.51%)}	_{8.58s (± 0.49%)}	_{-0.11s (- 1.27%)}	_8.51s	_8.63s	_{p=0.008 n=6}
_{Total Time}	_{22.15s (± 0.31%)}	_{21.98s (± 0.54%)}	_{-0.18s (- 0.80%)}	_21.82s	_22.17s	_{p=0.013 n=6}
_{Compiler - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{1.47s (± 0.93%)}	_{1.51s (± 1.37%)}	_{+0.03s (+ 2.26%)}	_1.49s	_1.54s	_{p=0.009 n=6}
_{Bind Time}	_{1.03s (± 1.13%)}	_{1.04s (± 1.16%)}	_~	_1.02s	_1.05s	_{p=0.131 n=6}
_{Check Time}	_{8.49s (± 0.72%)}	_{8.45s (± 0.40%)}	_~	_8.41s	_8.49s	_{p=0.332 n=6}
_{Emit Time}	_{3.68s (± 0.96%)}	_{3.61s (± 0.65%)}	_{-0.07s (- 1.81%)}	_3.59s	_3.64s	_{p=0.005 n=6}
_{Total Time}	_{14.67s (± 0.53%)}	_{14.62s (± 0.30%)}	_~	_14.57s	_14.68s	_{p=0.297 n=6}
_{Compiler-Unions - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{1.43s (± 2.27%)}	_{1.41s (± 2.00%)}	_~	_1.36s	_1.43s	_{p=0.346 n=6}
_{Bind Time}	_{0.98s (± 0.77%)}	_{0.96s (± 2.68%)}	_~	_0.94s	_1.01s	_{p=0.191 n=6}
_{Check Time}	_{11.62s (± 0.89%)}	_{11.69s (± 1.19%)}	_~	_11.50s	_11.85s	_{p=0.377 n=6}
_{Emit Time}	_{3.44s (± 1.07%)}	_{3.39s (± 1.48%)}	_~	_3.33s	_3.47s	_{p=0.106 n=6}
_{Total Time}	_{17.46s (± 0.46%)}	_{17.45s (± 0.72%)}	_~	_17.29s	_17.63s	_{p=0.936 n=6}
_{Monaco - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{2.41s (± 2.65%)}	_{2.35s (± 3.28%)}	_{-0.06s (- 2.35%)}	_2.31s	_2.51s	_{p=0.044 n=6}
_{Bind Time}	_{1.35s (± 1.89%)}	_{1.36s (± 1.90%)}	_~	_1.32s	_1.39s	_{p=0.872 n=6}
_{Check Time}	_{8.69s (± 0.35%)}	_{8.67s (± 0.31%)}	_~	_8.65s	_8.72s	_{p=0.406 n=6}
_{Emit Time}	_{4.75s (± 1.27%)}	_{4.72s (± 1.57%)}	_~	_4.64s	_4.84s	_{p=0.376 n=6}
_{Total Time}	_{17.20s (± 0.65%)}	_{17.10s (± 1.05%)}	_~	_16.96s	_17.45s	_{p=0.090 n=6}
_{TFS - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{2.08s (± 1.41%)}	_{2.05s (± 1.29%)}	_~	_2.03s	_2.10s	_{p=0.106 n=6}
_{Bind Time}	_{1.16s (± 2.59%)}	_{1.17s (± 1.13%)}	_~	_1.15s	_1.19s	_{p=0.220 n=6}
_{Check Time}	_{8.04s (± 0.36%)}	_{8.08s (± 0.52%)}	_~	_8.04s	_8.15s	_{p=0.087 n=6}
_{Emit Time}	_{4.35s (± 0.55%)}	_{4.27s (± 0.84%)}	_{-0.08s (- 1.80%)}	_4.21s	_4.32s	_{p=0.008 n=6}
_{Total Time}	_{15.62s (± 0.18%)}	_{15.58s (± 0.34%)}	_~	_15.51s	_15.65s	_{p=0.173 n=6}
_{material-ui - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{2.75s (± 1.58%)}	_{2.75s (± 2.03%)}	_~	_2.71s	_2.86s	_{p=0.684 n=6}
_{Bind Time}	_{0.92s (± 3.60%)}	_{0.94s (± 0.55%)}	_~	_0.94s	_0.95s	_{p=0.210 n=6}
_{Check Time}	_{21.98s (± 1.38%)}	_{21.26s (± 0.65%)}	_{🟩-0.72s (- 3.27%)}	_21.00s	_21.40s	_{p=0.008 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=0.405 n=6}
_{Total Time}	_{25.66s (± 1.32%)}	_{24.96s (± 0.55%)}	_{-0.70s (- 2.72%)}	_24.70s	_25.09s	_{p=0.020 n=6}
_{xstate - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{4.15s (± 0.72%)}	_{4.03s (± 0.30%)}	_{🟩-0.13s (- 3.01%)}	_4.01s	_4.04s	_{p=0.005 n=6}
_{Bind Time}	_{1.58s (± 0.89%)}	_{1.61s (± 0.94%)}	_{+0.03s (+ 1.69%)}	_1.59s	_1.63s	_{p=0.018 n=6}
_{Check Time}	_{4.03s (± 0.44%)}	_{4.08s (± 0.51%)}	_{+0.05s (+ 1.24%)}	_4.06s	_4.11s	_{p=0.010 n=6}
_{Emit Time}	_{0.23s (± 2.28%)}	_{0.22s (± 0.00%)}	_{-0.01s (- 2.94%)}	_0.22s	_0.22s	_{p=0.025 n=6}
_{Total Time}	_{9.99s (± 0.32%)}	_{9.94s (± 0.24%)}	_{-0.05s (- 0.52%)}	_9.90s	_9.96s	_{p=0.023 n=6}

System

_{Machine Name}	_elcheapo
_Platform	_{linux 6.1.9-arch1-2}
_Architecture	_x64
_{Available Memory}	_{8 GB}
_{Available Memory}	_{5 GB}
_CPUs	_{6 × Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz}

Hosts

bun (v0.5.5, x64)

Scenarios

Angular - bun (v0.5.5, x64)
Compiler - bun (v0.5.5, x64)
Compiler-Unions - bun (v0.5.5, x64)
Monaco - bun (v0.5.5, x64)
TFS - bun (v0.5.5, x64)
material-ui - bun (v0.5.5, x64)
xstate - bun (v0.5.5, x64)

_Benchmark	_Name	_Iterations
_Current	_HEAD	₆
_Baseline	_main	₆

robpalme reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 8, 2023

Copy link

Copy Markdown

Member Author

But, i'm going to rerun this just to be sure I didn't mess up somehow.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 8, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Nah, seems correct. A second go:

Details

Loading benchmark and comparing to baseline.
Comparison Report - main..HEAD

_Metric	_main	_HEAD	_Delta	_Best	_Worst	_p-value
_{Angular - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{2.57s (± 0.98%)}	_{2.54s (± 2.64%)}	_~	_2.50s	_2.67s	_{p=0.062 n=6}
_{Bind Time}	_{1.06s (± 1.10%)}	_{1.07s (± 3.01%)}	_~	_1.04s	_1.13s	_{p=0.806 n=6}
_{Check Time}	_{9.80s (± 0.54%)}	_{9.84s (± 0.68%)}	_~	_9.77s	_9.96s	_{p=0.573 n=6}
_{Emit Time}	_{8.71s (± 1.07%)}	_{8.62s (± 0.93%)}	_~	_8.55s	_8.76s	_{p=0.128 n=6}
_{Total Time}	_{22.14s (± 0.37%)}	_{22.07s (± 0.71%)}	_~	_21.86s	_22.30s	_{p=0.471 n=6}
_{Compiler - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{1.47s (± 1.27%)}	_{1.51s (± 1.62%)}	_{+0.04s (+ 2.95%)}	_1.49s	_1.55s	_{p=0.011 n=6}
_{Bind Time}	_{1.03s (± 1.50%)}	_{1.03s (± 1.84%)}	_~	_1.01s	_1.06s	_{p=0.799 n=6}
_{Check Time}	_{8.44s (± 0.59%)}	_{8.47s (± 0.66%)}	_~	_8.41s	_8.56s	_{p=0.261 n=6}
_{Emit Time}	_{3.67s (± 0.80%)}	_{3.63s (± 0.73%)}	_~	_3.59s	_3.66s	_{p=0.077 n=6}
_{Total Time}	_{14.60s (± 0.53%)}	_{14.65s (± 0.44%)}	_~	_14.56s	_14.73s	_{p=0.298 n=6}
_{Compiler-Unions - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{1.42s (± 1.06%)}	_{1.41s (± 3.28%)}	_~	_1.37s	_1.49s	_{p=0.368 n=6}
_{Bind Time}	_{0.97s (± 0.53%)}	_{0.96s (± 1.70%)}	_~	_0.94s	_0.98s	_{p=0.542 n=6}
_{Check Time}	_{11.66s (± 0.40%)}	_{11.63s (± 0.91%)}	_~	_11.47s	_11.77s	_{p=0.810 n=6}
_{Emit Time}	_{3.43s (± 1.19%)}	_{3.35s (± 1.50%)}	_{-0.08s (- 2.38%)}	_3.29s	_3.40s	_{p=0.015 n=6}
_{Total Time}	_{17.47s (± 0.38%)}	_{17.36s (± 0.40%)}	_{-0.12s (- 0.67%)}	_17.25s	_17.43s	_{p=0.019 n=6}
_{Monaco - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{2.39s (± 0.57%)}	_{2.35s (± 3.22%)}	_~	_2.30s	_2.50s	_{p=0.060 n=6}
_{Bind Time}	_{1.35s (± 5.27%)}	_{1.33s (± 7.58%)}	_~	_1.13s	_1.40s	_{p=0.870 n=6}
_{Check Time}	_{8.70s (± 1.09%)}	_{8.70s (± 0.83%)}	_~	_8.64s	_8.83s	_{p=0.809 n=6}
_{Emit Time}	_{4.75s (± 0.77%)}	_{4.71s (± 0.46%)}	_~	_4.68s	_4.74s	_{p=0.072 n=6}
_{Total Time}	_{17.18s (± 0.42%)}	_{17.08s (± 0.53%)}	_~	_17.01s	_17.22s	_{p=0.065 n=6}
_{TFS - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{2.07s (± 0.66%)}	_{2.05s (± 1.91%)}	_~	_2.03s	_2.13s	_{p=0.075 n=6}
_{Bind Time}	_{1.17s (± 2.28%)}	_{1.17s (± 0.44%)}	_~	_1.17s	_1.18s	_{p=0.667 n=6}
_{Check Time}	_{8.02s (± 0.38%)}	_{8.08s (± 0.26%)}	_{+0.06s (+ 0.79%)}	_8.05s	_8.10s	_{p=0.006 n=6}
_{Emit Time}	_{4.33s (± 1.72%)}	_{4.26s (± 1.05%)}	_~	_4.20s	_4.32s	_{p=0.054 n=6}
_{Total Time}	_{15.58s (± 0.57%)}	_{15.56s (± 0.37%)}	_~	_15.49s	_15.65s	_{p=0.873 n=6}
_{material-ui - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{2.75s (± 0.61%)}	_{2.76s (± 2.06%)}	_~	_2.72s	_2.87s	_{p=0.806 n=6}
_{Bind Time}	_{0.93s (± 4.07%)}	_{0.95s (± 0.79%)}	_~	_0.94s	_0.96s	_{p=0.081 n=6}
_{Check Time}	_{22.12s (± 0.61%)}	_{21.37s (± 0.38%)}	_{🟩-0.75s (- 3.39%)}	_21.27s	_21.51s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{25.80s (± 0.63%)}	_{25.09s (± 0.40%)}	_{-0.71s (- 2.75%)}	_24.97s	_25.23s	_{p=0.005 n=6}
_{xstate - bun (v0.5.5, x64)}
_{Memory used}	_{0k (± 0.00%)}	_{0k (± 0.00%)}	_~	_0k	_0k	_{p=1.000 n=6}
_{Parse Time}	_{4.15s (± 0.20%)}	_{4.02s (± 0.72%)}	_{🟩-0.13s (- 3.10%)}	_3.99s	_4.07s	_{p=0.005 n=6}
_{Bind Time}	_{1.57s (± 1.32%)}	_{1.63s (± 1.08%)}	_{+0.05s (+ 3.17%)}	_1.60s	_1.64s	_{p=0.006 n=6}
_{Check Time}	_{4.03s (± 0.30%)}	_{4.07s (± 0.39%)}	_{+0.04s (+ 0.95%)}	_4.06s	_4.10s	_{p=0.005 n=6}
_{Emit Time}	_{0.23s (± 3.88%)}	_{0.22s (± 1.84%)}	_~	_0.22s	_0.23s	_{p=0.086 n=6}
_{Total Time}	_{9.99s (± 0.22%)}	_{9.94s (± 0.45%)}	_{-0.05s (- 0.50%)}	_9.89s	_10.01s	_{p=0.044 n=6}

System

_{Machine Name}	_elcheapo
_Platform	_{linux 6.1.9-arch1-2}
_Architecture	_x64
_{Available Memory}	_{8 GB}
_{Available Memory}	_{5 GB}
_CPUs	_{6 × Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz}

Hosts

bun (v0.5.5, x64)

Scenarios

Angular - bun (v0.5.5, x64)
Compiler - bun (v0.5.5, x64)
Compiler-Unions - bun (v0.5.5, x64)
Monaco - bun (v0.5.5, x64)
TFS - bun (v0.5.5, x64)
material-ui - bun (v0.5.5, x64)
xstate - bun (v0.5.5, x64)

_Benchmark	_Name	_Iterations
_Current	_HEAD	₆
_Baseline	_main	₆

EDIT: Updated this table to say "bun"; I did that in the last one but forgot in this one. ts-perf doesn't currently support bun so this is a hack.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jarred Sumner (Jarred-Sumner) commented Feb 8, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Note that Bun runs the transpiler on every file loaded either via import or require (not eval, not new Function, etc). It doesn’t convert let/const variables to var. I wouldn’t expect the results to be different l. it might not work, but you could try BUN_DISABLE_TRANSPILER=1 & it would rule out the possibility of Bun’s transpiler changing the output before being evaluated

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 8, 2023

Copy link

Copy Markdown

Member Author

I'm not sure what you mean; the comparison is main versus this PR, i.e. let/const versus var. So if they don't do this transformation (as you say), then the comparison shows that their engine doesn't have this TDZ performance hit, at least not to any great extent.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 8, 2023

Copy link

Copy Markdown

Member Author

Unless you mean that I should try disabling the transpiler to make sure 100% they don't already do this transformation.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jarred Sumner (Jarred-Sumner) commented Feb 8, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

The environment variable which prevents the transpiler from running is here:

https://github.com/oven-sh/bun/blob/main/src/bundler.zig#L539

I think the results were already correct, just that since it’s two transpilers running it’s harder to be 100% sure. I sent the above message without re-reading the words I wrote very carefully. Bun doesn’t convert let or const to var, but does a bunch of other stuff. I do know that ESM imports bindings have virtually no overhead in JSC (there was a thread in Node’s issues about ESM imports being slower than var at some point)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Marvin Hagemeister (marvinhagemeister) commented Feb 8, 2023

Copy link

Copy Markdown

Looping in Evan Wallace (@evanw) because that may be an interesting optimization to do right in esbuild itself.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 8, 2023

Copy link

Copy Markdown

Member Author

Looping in Evan Wallace (@evanw) because that may be an interesting optimization to do right in esbuild itself.

See: evanw/esbuild#2889 (comment)

marvinhagemeister reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fmt

e67fbc0

This comment was marked as outdated.

Jake Bailey (jakebailey) commented Aug 30, 2023

Copy link

Copy Markdown

Member Author

TypeScript Bot (@typescript-bot) new perf test bun

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Aug 30, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Heya Jake Bailey (@jakebailey), I've started to run the bun perf test suite on this PR at e67fbc0. You can monitor the build here.

Update: The results are in!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Aug 30, 2023

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - bun (v0.7.3, x64)}
_{Memory used}	_{321,810k (± 0.23%)}	_{322,091k (± 0.28%)}	_~	_321,114k	_323,375k	_{p=0.689 n=6}
_{Parse Time}	_{2.32s (± 0.72%)}	_{2.35s (± 0.79%)}	_{+0.03s (+ 1.44%)}	_2.33s	_2.38s	_{p=0.012 n=6}
_{Bind Time}	_{0.95s (± 5.36%)}	_{0.94s (± 5.06%)}	_~	_0.90s	_1.01s	_{p=0.687 n=6}
_{Check Time}	_{7.94s (± 1.68%)}	_{8.04s (± 0.37%)}	_~	_8.00s	_8.07s	_{p=0.254 n=6}
_{Emit Time}	_{6.44s (± 0.42%)}	_{6.47s (± 0.77%)}	_~	_6.42s	_6.55s	_{p=0.466 n=6}
_{Total Time}	_{17.65s (± 0.56%)}	_{17.80s (± 0.38%)}	_{+0.15s (+ 0.84%)}	_17.73s	_17.90s	_{p=0.029 n=6}
_{Compiler-Unions - bun (v0.7.3, x64)}
_{Memory used}	_{246,169k (± 3.04%)}	_{243,993k (± 2.10%)}	_~	_237,438k	_249,524k	_{p=0.575 n=6}
_{Parse Time}	_{1.26s (± 0.71%)}	_{1.28s (± 1.74%)}	_~	_1.25s	_1.31s	_{p=0.164 n=6}
_{Bind Time}	_{0.85s (± 2.53%)}	_{0.85s (± 0.96%)}	_~	_0.84s	_0.86s	_{p=0.682 n=6}
_{Check Time}	_{8.90s (± 0.23%)}	_{9.00s (± 0.71%)}	_~	_8.88s	_9.06s	_{p=0.053 n=6}
_{Emit Time}	_{2.76s (± 0.86%)}	_{2.74s (± 0.64%)}	_~	_2.72s	_2.77s	_{p=0.072 n=6}
_{Total Time}	_{13.78s (± 0.29%)}	_{13.86s (± 0.35%)}	_{+0.09s (+ 0.63%)}	_13.77s	_13.91s	_{p=0.015 n=6}
_{Monaco - bun (v0.7.3, x64)}
_{Memory used}	_{370,241k (± 0.37%)}	_{370,192k (± 0.28%)}	_~	_369,196k	_371,592k	_{p=1.000 n=6}
_{Parse Time}	_{2.06s (± 0.57%)}	_{2.05s (± 0.85%)}	_~	_2.03s	_2.08s	_{p=0.084 n=6}
_{Bind Time}	_{1.11s (± 2.48%)}	_{1.11s (± 2.26%)}	_~	_1.08s	_1.14s	_{p=0.807 n=6}
_{Check Time}	_{7.19s (± 0.65%)}	_{7.21s (± 0.52%)}	_~	_7.17s	_7.28s	_{p=0.746 n=6}
_{Emit Time}	_{3.75s (± 1.08%)}	_{3.76s (± 0.93%)}	_~	_3.73s	_3.82s	_{p=0.571 n=6}
_{Total Time}	_{14.11s (± 0.29%)}	_{14.13s (± 0.51%)}	_~	_14.06s	_14.26s	_{p=0.936 n=6}
_{TFS - bun (v0.7.3, x64)}
_{Memory used}	_{317,835k (± 0.13%)}	_{317,724k (± 0.25%)}	_~	_316,647k	_319,042k	_{p=0.378 n=6}
_{Parse Time}	_{1.80s (± 0.67%)}	_{1.79s (± 0.55%)}	_~	_1.78s	_1.80s	_{p=0.138 n=6}
_{Bind Time}	_{1.00s (± 1.21%)}	_{0.98s (± 1.78%)}	_~	_0.96s	_1.01s	_{p=0.059 n=6}
_{Check Time}	_{6.62s (± 0.64%)}	_{6.68s (± 0.54%)}	_{+0.05s (+ 0.81%)}	_6.62s	_6.73s	_{p=0.045 n=6}
_{Emit Time}	_{3.44s (± 0.83%)}	_{3.50s (± 1.23%)}	_{+0.06s (+ 1.79%)}	_3.45s	_3.58s	_{p=0.013 n=6}
_{Total Time}	_{12.88s (± 0.38%)}	_{12.96s (± 0.53%)}	_~	_12.87s	_13.05s	_{p=0.065 n=6}
_{material-ui - bun (v0.7.3, x64)}
_{Memory used}	_{537,607k (± 0.25%)}	_{508,460k (± 7.12%)}	_~	_464,102k	_543,543k	_{p=0.471 n=6}
_{Parse Time}	_{2.50s (± 0.75%)}	_{2.45s (± 0.71%)}	_{-0.04s (- 1.67%)}	_2.44s	_2.48s	_{p=0.007 n=6}
_{Bind Time}	_{0.71s (± 1.06%)}	_{0.76s (± 3.70%)}	_{+0.05s (+ 6.82%)}	_0.73s	_0.80s	_{p=0.005 n=6}
_{Check Time}	_{15.76s (± 0.53%)}	_{15.80s (± 0.77%)}	_~	_15.66s	_15.99s	_{p=0.423 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=0.405 n=6}
_{Total Time}	_{18.97s (± 0.41%)}	_{19.02s (± 0.62%)}	_~	_18.88s	_19.19s	_{p=0.374 n=6}
_{xstate - bun (v0.7.3, x64)}
_{Memory used}	_{471,655k (± 9.65%)}	_{472,130k (± 8.15%)}	_~	_436,287k	_509,641k	_{p=1.000 n=6}
_{Parse Time}	_{3.60s (± 1.11%)}	_{3.58s (± 0.38%)}	_~	_3.56s	_3.60s	_{p=0.627 n=6}
_{Bind Time}	_{1.41s (± 2.84%)}	_{1.41s (± 1.17%)}	_~	_1.39s	_1.43s	_{p=0.870 n=6}
_{Check Time}	_{3.54s (± 0.81%)}	_{3.62s (± 0.33%)}	_{+0.08s (+ 2.31%)}	_3.60s	_3.63s	_{p=0.004 n=6}
_{Emit Time}	_{0.22s (± 9.08%)}	_{0.21s (± 3.55%)}	_~	_0.20s	_0.22s	_{p=0.652 n=6}
_{Total Time}	_{8.77s (± 0.51%)}	_{8.83s (± 0.30%)}	_{+0.06s (+ 0.74%)}	_8.80s	_8.86s	_{p=0.029 n=6}

System info unknown

Hosts

bun (v0.7.3, x64)

Scenarios

Angular - bun (v0.7.3, x64)
Compiler-Unions - bun (v0.7.3, x64)
Monaco - bun (v0.7.3, x64)
TFS - bun (v0.7.3, x64)
material-ui - bun (v0.7.3, x64)
xstate - bun (v0.7.3, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - bun (v0.7.3, x64)}
_{Execution time}	_{425.30ms (± 0.10%)}	_{423.55ms (± 0.11%)}	_{-1.75ms (- 0.41%)}	_422.65ms	_432.93ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - bun (v0.7.3, x64)}
_{Execution time}	_{661.41ms (± 0.14%)}	_{656.76ms (± 0.13%)}	_{-4.65ms (- 0.70%)}	_655.22ms	_678.21ms	_{p=0.000 n=600}
_{typescript-startup - bun (v0.7.3, x64)}
_{Execution time}	_{662.40ms (± 0.11%)}	_{654.86ms (± 0.14%)}	_{-7.54ms (- 1.14%)}	_653.45ms	_672.29ms	_{p=0.000 n=600}

System info unknown

Hosts

bun (v0.7.3, x64)

Scenarios

tsc-startup - bun (v0.7.3, x64)
tsserverlibrary-startup - bun (v0.7.3, x64)
typescript-startup - bun (v0.7.3, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) mentioned this pull request

Aug 30, 2023

Expand Perf Suite Codebases, Expand Perf Suite Operations #44033

Closed

Jake Bailey (jakebailey) added 2 commits

January 10, 2024 20:59


          Merge branch 'main' into babel-let-const

141b40b


          Update deps

0c249d9

Jake Bailey (jakebailey) commented Jan 11, 2024

Copy link

Copy Markdown

Member Author

TypeScript Bot (@typescript-bot) perf test public

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jan 11, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Heya Jake Bailey (@jakebailey), I've started to run the public perf test suite on this PR at 0c249d9. You can monitor the build here.

Update: The results are in!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jan 11, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{mui-docs - node (v20.5.1, x64)}
_{Memory used}	_{1,735,248k (± 0.00%)}	_{1,734,982k (± 0.00%)}	_{-266k (- 0.02%)}	_1,734,964k	_1,735,005k	_{p=0.005 n=6}
_{Parse Time}	_{6.83s (± 0.46%)}	_{6.81s (± 0.44%)}	_~	_6.77s	_6.85s	_{p=0.333 n=6}
_{Bind Time}	_{2.42s (± 1.10%)}	_{2.42s (± 0.56%)}	_~	_2.41s	_2.44s	_{p=0.459 n=6}
_{Check Time}	_{52.39s (± 0.40%)}	_{52.55s (± 0.60%)}	_~	_51.97s	_52.91s	_{p=0.128 n=6}
_{Emit Time}	_{0.15s (± 0.00%)}	_{0.15s (± 0.00%)}	_~	_0.15s	_0.15s	_{p=1.000 n=6}
_{Total Time}	_{61.78s (± 0.30%)}	_{61.94s (± 0.51%)}	_~	_61.35s	_62.28s	_{p=0.149 n=6}
_{self-build-src - node (v20.5.1, x64)}
_{Memory used}	_{2,751,144k (± 6.91%)}	_{2,571,396k (± 0.03%)}	_{🟩-179,748k (- 6.53%)}	_2,570,753k	_2,573,098k	_{p=0.005 n=6}
_{Parse Time}	_{5.05s (± 0.81%)}	_{5.04s (± 0.58%)}	_~	_4.99s	_5.07s	_{p=0.748 n=6}
_{Bind Time}	_{1.99s (± 0.49%)}	_{2.03s (± 1.35%)}	_{+0.04s (+ 1.84%)}	_1.99s	_2.07s	_{p=0.016 n=6}
_{Check Time}	_{32.12s (± 0.35%)}	_{32.20s (± 0.16%)}	_~	_32.12s	_32.26s	_{p=0.298 n=6}
_{Emit Time}	_{2.79s (± 3.97%)}	_{2.79s (± 4.04%)}	_~	_2.62s	_2.94s	_{p=0.936 n=6}
_{Total Time}	_{41.97s (± 0.22%)}	_{42.07s (± 0.19%)}	_~	_41.97s	_42.17s	_{p=0.093 n=6}
_{self-compiler - node (v20.5.1, x64)}
_{Memory used}	_{419,228k (± 0.01%)}	_{419,355k (± 0.29%)}	_~	_418,746k	_421,793k	_{p=0.066 n=6}
_{Parse Time}	_{2.88s (± 0.48%)}	_{2.87s (± 0.97%)}	_~	_2.84s	_2.91s	_{p=1.000 n=6}
_{Bind Time}	_{1.13s (± 0.74%)}	_{1.14s (± 0.36%)}	_~	_1.13s	_1.14s	_{p=0.285 n=6}
_{Check Time}	_{14.12s (± 0.33%)}	_{14.10s (± 0.41%)}	_~	_14.03s	_14.17s	_{p=0.688 n=6}
_{Emit Time}	_{1.05s (± 1.17%)}	_{1.04s (± 0.72%)}	_~	_1.03s	_1.05s	_{p=1.000 n=6}
_{Total Time}	_{19.17s (± 0.33%)}	_{19.15s (± 0.28%)}	_~	_19.08s	_19.22s	_{p=0.467 n=6}
_{vscode - node (v20.5.1, x64)}
_{Memory used}	_{2,828,007k (± 0.01%)}	_{2,827,290k (± 0.01%)}	_{-717k (- 0.03%)}	_2,827,184k	_2,827,570k	_{p=0.005 n=6}
_{Parse Time}	_{10.72s (± 0.17%)}	_{10.71s (± 0.22%)}	_~	_10.67s	_10.73s	_{p=0.324 n=6}
_{Bind Time}	_{3.41s (± 0.82%)}	_{3.45s (± 0.15%)}	_{+0.04s (+ 1.22%)}	_3.45s	_3.46s	_{p=0.010 n=6}
_{Check Time}	_{56.23s (± 0.45%)}	_{56.64s (± 0.41%)}	_{+0.41s (+ 0.73%)}	_56.25s	_56.88s	_{p=0.031 n=6}
_{Emit Time}	_{16.81s (± 8.95%)}	_{19.10s (± 7.87%)}	_~	_16.03s	_19.77s	_{p=0.297 n=6}
_{Total Time}	_{87.17s (± 1.84%)}	_{89.90s (± 1.88%)}	_~	_86.47s	_90.79s	_{p=0.066 n=6}
_{webpack - node (v20.5.1, x64)}
_{Memory used}	_{390,786k (± 0.01%)}	_{390,445k (± 0.01%)}	_{-341k (- 0.09%)}	_390,395k	_390,505k	_{p=0.005 n=6}
_{Parse Time}	_{3.32s (± 0.40%)}	_{3.30s (± 0.49%)}	_~	_3.28s	_3.32s	_{p=0.067 n=6}
_{Bind Time}	_{1.43s (± 0.82%)}	_{1.44s (± 0.84%)}	_~	_1.42s	_1.45s	_{p=0.323 n=6}
_{Check Time}	_{12.78s (± 0.21%)}	_{12.70s (± 0.31%)}	_{-0.08s (- 0.66%)}	_12.64s	_12.74s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{17.54s (± 0.13%)}	_{17.44s (± 0.18%)}	_{-0.10s (- 0.57%)}	_17.40s	_17.47s	_{p=0.005 n=6}

System info unknown

Hosts

node (v20.5.1, x64)

Scenarios

mui-docs - node (v20.5.1, x64)
self-build-src - node (v20.5.1, x64)
self-compiler - node (v20.5.1, x64)
vscode - node (v20.5.1, x64)
webpack - node (v20.5.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) added 2 commits

January 19, 2024 20:08


          Merge branch 'main' into babel-let-const

bb135e5


          Merge branch 'main' into babel-let-const

e8c6a71

Jake Bailey (jakebailey) commented Mar 19, 2024

Copy link

Copy Markdown

Member Author

TypeScript Bot (@typescript-bot) perf test this

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 19, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 19, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,740k (± 0.01%)}	_{295,106k (± 0.00%)}	_{-633k (- 0.21%)}	_295,088k	_295,124k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.19%)}	_{2.62s (± 0.24%)}	_{-0.04s (- 1.63%)}	_2.61s	_2.63s	_{p=0.004 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.83s (± 0.62%)}	_{+0.01s (+ 1.01%)}	_0.83s	_0.84s	_{p=0.038 n=6}
_{Check Time}	_{8.21s (± 0.30%)}	_{8.06s (± 0.38%)}	_{-0.15s (- 1.79%)}	_8.01s	_8.09s	_{p=0.005 n=6}
_{Emit Time}	_{7.13s (± 0.71%)}	_{6.98s (± 0.47%)}	_{-0.16s (- 2.20%)}	_6.95s	_7.03s	_{p=0.005 n=6}
_{Total Time}	_{18.83s (± 0.31%)}	_{18.50s (± 0.30%)}	_{-0.33s (- 1.77%)}	_18.41s	_18.57s	_{p=0.005 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,791k (± 0.99%)}	_{191,565k (± 0.06%)}	_{-2,226k (- 1.15%)}	_191,485k	_191,801k	_{p=0.005 n=6}
_{Parse Time}	_{1.36s (± 1.23%)}	_{1.36s (± 2.25%)}	_~	_1.30s	_1.38s	_{p=0.681 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_{0.72s (± 0.57%)}	_~	_0.72s	_0.73s	_{p=1.000 n=6}
_{Check Time}	_{9.51s (± 0.82%)}	_{9.31s (± 0.57%)}	_{-0.20s (- 2.10%)}	_9.24s	_9.38s	_{p=0.005 n=6}
_{Emit Time}	_{2.66s (± 0.46%)}	_{2.64s (± 0.41%)}	_~	_2.63s	_2.66s	_{p=0.062 n=6}
_{Total Time}	_{14.24s (± 0.53%)}	_{14.03s (± 0.58%)}	_{-0.21s (- 1.50%)}	_13.90s	_14.13s	_{p=0.005 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,366k (± 0.00%)}	_{347,008k (± 0.01%)}	_{-358k (- 0.10%)}	_346,990k	_347,042k	_{p=0.005 n=6}
_{Parse Time}	_{2.48s (± 0.21%)}	_{2.48s (± 0.59%)}	_~	_2.46s	_2.50s	_{p=0.451 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.44%)}	_~	_0.93s	_0.94s	_{p=0.218 n=6}
_{Check Time}	_{7.02s (± 0.28%)}	_{7.04s (± 0.47%)}	_~	_7.01s	_7.10s	_{p=0.413 n=6}
_{Emit Time}	_{4.07s (± 0.34%)}	_{4.06s (± 0.55%)}	_~	_4.03s	_4.08s	_{p=1.000 n=6}
_{Total Time}	_{14.49s (± 0.24%)}	_{14.51s (± 0.26%)}	_~	_14.44s	_14.54s	_{p=0.332 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,727k (± 0.00%)}	_{302,256k (± 0.01%)}	_{-471k (- 0.16%)}	_302,214k	_302,312k	_{p=0.005 n=6}
_{Parse Time}	_{2.01s (± 1.02%)}	_{2.00s (± 0.55%)}	_~	_1.98s	_2.01s	_{p=0.503 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{1.00s (± 0.82%)}	_~	_0.99s	_1.01s	_{p=0.394 n=6}
_{Check Time}	_{6.32s (± 0.60%)}	_{6.30s (± 0.33%)}	_~	_6.27s	_6.33s	_{p=0.258 n=6}
_{Emit Time}	_{3.60s (± 0.48%)}	_{3.54s (± 0.52%)}	_{-0.06s (- 1.53%)}	_3.52s	_3.57s	_{p=0.006 n=6}
_{Total Time}	_{12.93s (± 0.41%)}	_{12.84s (± 0.17%)}	_{-0.09s (- 0.71%)}	_12.80s	_12.86s	_{p=0.008 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{509,922k (± 0.00%)}	_{509,549k (± 0.00%)}	_{-373k (- 0.07%)}	_509,531k	_509,568k	_{p=0.005 n=6}
_{Parse Time}	_{2.66s (± 0.41%)}	_{2.70s (± 0.20%)}	_{+0.04s (+ 1.32%)}	_2.69s	_2.70s	_{p=0.004 n=6}
_{Bind Time}	_{0.98s (± 1.06%)}	_{0.98s (± 1.00%)}	_~	_0.97s	_0.99s	_{p=0.673 n=6}
_{Check Time}	_{17.23s (± 0.39%)}	_{17.26s (± 0.27%)}	_~	_17.18s	_17.30s	_{p=0.336 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.88s (± 0.38%)}	_{20.93s (± 0.23%)}	_~	_20.86s	_20.99s	_{p=0.198 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,718,974k (± 0.00%)}	_{1,718,497k (± 0.00%)}	_{-477k (- 0.03%)}	_1,718,463k	_1,718,524k	_{p=0.005 n=6}
_{Parse Time}	_{6.51s (± 0.40%)}	_{6.58s (± 0.53%)}	_{+0.07s (+ 1.08%)}	_6.56s	_6.65s	_{p=0.005 n=6}
_{Bind Time}	_{2.36s (± 0.27%)}	_{2.34s (± 0.66%)}	_{-0.02s (- 0.85%)}	_2.32s	_2.36s	_{p=0.024 n=6}
_{Check Time}	_{56.12s (± 0.36%)}	_{56.40s (± 0.56%)}	_~	_55.92s	_56.77s	_{p=0.128 n=6}
_{Emit Time}	_{0.13s (± 0.00%)}	_{0.14s (± 4.05%)}	_~	_0.13s	_0.14s	_{p=0.071 n=6}
_{Total Time}	_{65.12s (± 0.33%)}	_{65.45s (± 0.53%)}	_~	_64.94s	_65.89s	_{p=0.093 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,394,975k (± 0.02%)}	_{2,389,428k (± 0.02%)}	_{-5,547k (- 0.23%)}	_2,388,869k	_2,390,500k	_{p=0.005 n=6}
_{Parse Time}	_{4.98s (± 1.40%)}	_{5.06s (± 1.19%)}	_{+0.08s (+ 1.64%)}	_4.98s	_5.12s	_{p=0.037 n=6}
_{Bind Time}	_{1.91s (± 1.32%)}	_{1.88s (± 1.34%)}	_~	_1.85s	_1.92s	_{p=0.063 n=6}
_{Check Time}	_{33.57s (± 0.32%)}	_{33.36s (± 0.21%)}	_{-0.21s (- 0.64%)}	_33.27s	_33.45s	_{p=0.013 n=6}
_{Emit Time}	_{2.71s (± 1.16%)}	_{2.61s (± 1.03%)}	_{🟩-0.10s (- 3.57%)}	_2.57s	_2.64s	_{p=0.005 n=6}
_{Total Time}	_{43.18s (± 0.38%)}	_{42.93s (± 0.26%)}	_{-0.25s (- 0.58%)}	_42.73s	_43.04s	_{p=0.013 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{416,056k (± 0.01%)}	_{415,592k (± 0.01%)}	_{-464k (- 0.11%)}	_415,533k	_415,665k	_{p=0.005 n=6}
_{Parse Time}	_{2.83s (± 0.68%)}	_{2.74s (± 2.71%)}	_{🟩-0.09s (- 3.06%)}	_2.64s	_2.81s	_{p=0.005 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.11s (± 5.71%)}	_~	_1.07s	_1.22s	_{p=0.070 n=6}
_{Check Time}	_{15.33s (± 0.50%)}	_{15.19s (± 0.39%)}	_{-0.14s (- 0.91%)}	_15.13s	_15.25s	_{p=0.010 n=6}
_{Emit Time}	_{1.14s (± 0.92%)}	_{1.11s (± 0.57%)}	_{🟩-0.03s (- 3.06%)}	_1.10s	_1.12s	_{p=0.004 n=6}
_{Total Time}	_{20.37s (± 0.38%)}	_{20.15s (± 0.32%)}	_{-0.22s (- 1.10%)}	_20.07s	_20.22s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,884,074k (± 0.00%)}	_{2,883,374k (± 0.00%)}	_{-700k (- 0.02%)}	_2,883,258k	_2,883,414k	_{p=0.005 n=6}
_{Parse Time}	_{10.81s (± 0.26%)}	_{10.78s (± 0.32%)}	_~	_10.74s	_10.82s	_{p=0.212 n=6}
_{Bind Time}	_{3.47s (± 0.30%)}	_{3.48s (± 0.56%)}	_~	_3.46s	_3.51s	_{p=0.263 n=6}
_{Check Time}	_{61.41s (± 0.47%)}	_{61.47s (± 0.34%)}	_~	_61.09s	_61.69s	_{p=0.872 n=6}
_{Emit Time}	_{16.44s (± 0.32%)}	_{16.22s (± 0.49%)}	_{-0.22s (- 1.35%)}	_16.13s	_16.34s	_{p=0.005 n=6}
_{Total Time}	_{92.12s (± 0.30%)}	_{91.94s (± 0.30%)}	_~	_91.47s	_92.28s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,028k (± 0.01%)}	_{407,754k (± 0.01%)}	_{-274k (- 0.07%)}	_407,690k	_407,820k	_{p=0.005 n=6}
_{Parse Time}	_{3.23s (± 0.23%)}	_{3.20s (± 0.25%)}	_{-0.03s (- 0.88%)}	_3.19s	_3.21s	_{p=0.004 n=6}
_{Bind Time}	_{1.38s (± 0.30%)}	_{1.40s (± 0.74%)}	_{+0.02s (+ 1.57%)}	_1.39s	_1.42s	_{p=0.004 n=6}
_{Check Time}	_{14.27s (± 0.20%)}	_{14.23s (± 0.35%)}	_~	_14.19s	_14.30s	_{p=0.169 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.88s (± 0.19%)}	_{18.84s (± 0.25%)}	_~	_18.79s	_18.91s	_{p=0.198 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,080k (± 0.01%)}	_{512,180k (± 0.01%)}	_{-900k (- 0.18%)}	_512,089k	_512,258k	_{p=0.005 n=6}
_{Parse Time}	_{3.28s (± 0.37%)}	_{3.25s (± 0.45%)}	_{-0.03s (- 0.81%)}	_3.23s	_3.27s	_{p=0.018 n=6}
_{Bind Time}	_{1.54s (± 0.35%)}	_{1.55s (± 0.26%)}	_~	_1.55s	_1.56s	_{p=0.054 n=6}
_{Check Time}	_{2.86s (± 0.29%)}	_{2.88s (± 0.36%)}	_{+0.03s (+ 0.99%)}	_2.87s	_2.90s	_{p=0.005 n=6}
_{Emit Time}	_{0.07s (± 7.03%)}	_{0.07s (± 7.03%)}	_~	_0.07s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.33%)}	_{7.76s (± 0.16%)}	_~	_7.75s	_7.78s	_{p=0.518 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,336ms (± 0.78%)}	_{2,337ms (± 0.78%)}	_~	_2,315ms	_2,359ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{5,794ms (± 0.37%)}	_{5,677ms (± 0.53%)}	_{-117ms (- 2.01%)}	_5,656ms	_5,738ms	_{p=0.005 n=6}
_{Req 3 - references}	_{325ms (± 1.04%)}	_{332ms (± 0.82%)}	_{+7ms (+ 2.00%)}	_330ms	_337ms	_{p=0.032 n=6}
_{Req 4 - navto}	_{272ms (± 0.19%)}	_{265ms (± 0.15%)}	_{-7ms (- 2.63%)}	_265ms	_266ms	_{p=0.003 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{95ms (± 0.43%)}	_{94ms (± 1.16%)}	_~	_93ms	_96ms	_{p=0.090 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,499ms (± 0.89%)}	_{2,469ms (± 0.53%)}	_{-30ms (- 1.19%)}	_2,443ms	_2,480ms	_{p=0.016 n=6}
_{Req 2 - geterr}	_{4,264ms (± 0.33%)}	_{4,159ms (± 0.49%)}	_{-105ms (- 2.45%)}	_4,132ms	_4,184ms	_{p=0.005 n=6}
_{Req 3 - references}	_{332ms (± 0.12%)}	_{335ms (± 0.22%)}	_{+3ms (+ 0.90%)}	_334ms	_336ms	_{p=0.003 n=6}
_{Req 4 - navto}	_{283ms (± 0.45%)}	_{278ms (± 0.44%)}	_{-6ms (- 1.94%)}	_276ms	_279ms	_{p=0.004 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 0.81%)}	_{85ms (± 6.80%)}	_{🔻+7ms (+ 8.33%)}	_78ms	_90ms	_{p=0.020 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,618ms (± 0.11%)}	_{2,590ms (± 0.31%)}	_{-28ms (- 1.06%)}	_2,579ms	_2,598ms	_{p=0.005 n=6}
_{Req 2 - geterr}	_{1,725ms (± 1.98%)}	_{1,720ms (± 1.64%)}	_~	_1,682ms	_1,759ms	_{p=0.689 n=6}
_{Req 3 - references}	_{115ms (±10.05%)}	_{119ms (± 6.94%)}	_~	_102ms	_123ms	_{p=0.683 n=6}
_{Req 4 - navto}	_{371ms (± 0.20%)}	_{375ms (± 0.90%)}	_{+4ms (+ 0.99%)}	_372ms	_380ms	_{p=0.011 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{308ms (± 1.42%)}	_{308ms (± 1.41%)}	_~	_301ms	_313ms	_{p=0.517 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.76ms (± 0.17%)}	_{151.55ms (± 0.17%)}	_{-2.20ms (- 1.43%)}	_150.52ms	_154.90ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.85ms (± 0.16%)}	_{229.69ms (± 0.19%)}	_{+0.84ms (+ 0.37%)}	_228.13ms	_236.57ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{222.61ms (± 0.15%)}	_{220.92ms (± 0.19%)}	_{-1.70ms (- 0.76%)}	_219.44ms	_227.40ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{223.53ms (± 0.15%)}	_{222.11ms (± 0.20%)}	_{-1.42ms (- 0.64%)}	_220.38ms	_228.18ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

7nik mentioned this pull request

Apr 23, 2024

fix: avoid hoisting error by using 'let' instead of 'var' sveltejs/svelte#11291

Merged

5 tasks done

Jake Bailey (jakebailey) added 2 commits

June 29, 2024 21:06


          Merge branch 'main' into babel-let-const

4a41ffc


          bump

75582fc

Jake Bailey (jakebailey) commented Jun 30, 2024

Copy link

Copy Markdown

Member Author

TypeScript Bot (@typescript-bot) perf test this
TypeScript Bot (@typescript-bot) perf test this faster [email protected]

typescript-bot reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jun 30, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results
`perf test this faster [email protected]`	✅ Started	👀 Results

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jun 30, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - bun (v1.1.17, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{247,002k (± 4.81%)}	_{255,207k (± 2.37%)}	_~	_251,606k	_267,364k	_{p=0.230 n=6}
_{Parse Time}	_{1.31s (± 1.33%)}	_{1.31s (± 1.65%)}	_~	_1.29s	_1.35s	_{p=0.405 n=6}
_{Bind Time}	_{0.98s (± 1.50%)}	_{0.97s (± 2.49%)}	_~	_0.94s	_1.01s	_{p=0.871 n=6}
_{Check Time}	_{10.22s (± 0.57%)}	_{10.30s (± 0.93%)}	_~	_10.21s	_10.43s	_{p=0.077 n=6}
_{Emit Time}	_{3.43s (± 1.58%)}	_{3.50s (± 1.07%)}	_{+0.06s (+ 1.89%)}	_3.44s	_3.54s	_{p=0.045 n=6}
_{Total Time}	_{15.94s (± 0.53%)}	_{16.08s (± 0.46%)}	_{+0.14s (+ 0.87%)}	_15.97s	_16.17s	_{p=0.020 n=6}
_{angular-1 - bun (v1.1.17, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,280,711k (± 0.16%)}	_{1,280,677k (± 0.40%)}	_~	_1,270,826k	_1,285,058k	_{p=0.298 n=6}
_{Parse Time}	_{4.76s (± 0.42%)}	_{4.74s (± 0.36%)}	_~	_4.72s	_4.76s	_{p=0.124 n=6}
_{Bind Time}	_{1.95s (± 0.43%)}	_{1.96s (± 0.84%)}	_~	_1.93s	_1.98s	_{p=0.170 n=6}
_{Check Time}	_{29.56s (± 0.44%)}	_{29.87s (± 0.84%)}	_{+0.31s (+ 1.05%)}	_29.62s	_30.34s	_{p=0.020 n=6}
_{Emit Time}	_{11.17s (± 1.13%)}	_{11.41s (± 1.01%)}	_{+0.24s (+ 2.13%)}	_11.28s	_11.57s	_{p=0.016 n=6}
_{Total Time}	_{47.44s (± 0.45%)}	_{47.97s (± 0.63%)}	_{+0.54s (+ 1.13%)}	_47.68s	_48.48s	_{p=0.013 n=6}
_{mui-docs - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,133,039	_2,133,039	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,444	_926,444	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,313,268k (± 0.32%)}	_{2,321,468k (± 0.42%)}	_~	_2,307,305k	_2,332,902k	_{p=0.230 n=6}
_{Parse Time}	_{5.52s (± 0.88%)}	_{5.48s (± 0.34%)}	_~	_5.46s	_5.51s	_{p=0.295 n=6}
_{Bind Time}	_{1.54s (± 2.28%)}	_{1.53s (± 3.33%)}	_~	_1.46s	_1.61s	_{p=0.518 n=6}
_{Check Time}	_{64.67s (± 0.90%)}	_{65.20s (± 0.92%)}	_~	_64.19s	_65.98s	_{p=0.230 n=6}
_{Emit Time}	_0.15s	_0.15s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{71.87s (± 0.86%)}	_{72.36s (± 0.86%)}	_~	_71.35s	_73.15s	_{p=0.230 n=6}
_{self-build-src - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,260	_1,225,260	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,341	_261,341	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{9,024,980k (± 0.05%)}	_{8,986,079k (± 0.37%)}	_{-38,901k (- 0.43%)}	_8,922,529k	_9,011,426k	_{p=0.005 n=6}
_{Parse Time}	_{4.06s (± 0.71%)}	_{4.12s (± 0.99%)}	_{+0.06s (+ 1.60%)}	_4.05s	_4.16s	_{p=0.037 n=6}
_{Bind Time}	_{1.71s (± 1.17%)}	_{1.73s (± 0.70%)}	_{+0.02s (+ 1.36%)}	_1.72s	_1.75s	_{p=0.041 n=6}
_{Check Time}	_{31.67s (± 0.17%)}	_{30.91s (± 4.16%)}	_~	_29.24s	_31.87s	_{p=0.936 n=6}
_{Emit Time}	_{1.76s (± 0.84%)}	_{1.75s (± 4.54%)}	_~	_1.61s	_1.84s	_{p=1.000 n=6}
_{Total Time}	_{39.22s (± 0.16%)}	_{38.53s (± 3.50%)}	_~	_36.79s	_39.53s	_{p=0.378 n=6}
_{self-build-src-public-api - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,260	_1,225,260	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,341	_261,341	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{4,383,876k (± 3.45%)}	_{5,556,996k (±34.14%)}	_~	_4,417,514k	_9,025,179k	_{p=0.689 n=6}
_{Parse Time}	_{3.90s (± 0.88%)}	_{3.91s (± 1.28%)}	_~	_3.87s	_4.00s	_{p=1.000 n=6}
_{Bind Time}	_{1.82s (± 1.73%)}	_{1.91s (± 2.98%)}	_{🔻+0.09s (+ 5.05%)}	_1.85s	_2.00s	_{p=0.008 n=6}
_{Check Time}	_{33.57s (± 2.08%)}	_{33.06s (± 1.99%)}	_~	_31.91s	_33.61s	_{p=0.810 n=6}
_{Emit Time}	_{1.75s (± 3.37%)}	_{1.70s (± 6.15%)}	_~	_1.49s	_1.77s	_{p=0.471 n=6}
_{Total Time}	_{41.06s (± 1.78%)}	_{40.60s (± 1.69%)}	_~	_39.46s	_41.14s	_{p=1.000 n=6}
_{self-compiler - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,194	_258,194	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,737	_104,737	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{422,498k (± 1.07%)}	_{414,716k (± 1.26%)}	_{-7,783k (- 1.84%)}	_411,644k	_425,304k	_{p=0.031 n=6}
_{Parse Time}	_{3.28s (± 1.52%)}	_{3.28s (± 0.60%)}	_~	_3.26s	_3.31s	_{p=0.936 n=6}
_{Bind Time}	_{1.65s (± 1.52%)}	_{1.66s (± 2.07%)}	_~	_1.60s	_1.70s	_{p=0.223 n=6}
_{Check Time}	_{20.63s (± 0.49%)}	_{20.77s (± 0.48%)}	_~	_20.66s	_20.94s	_{p=0.065 n=6}
_{Emit Time}	_{1.26s (± 2.29%)}	_{1.25s (± 3.59%)}	_~	_1.19s	_1.30s	_{p=0.748 n=6}
_{Total Time}	_{26.81s (± 0.42%)}	_{26.96s (± 0.48%)}	_~	_26.81s	_27.17s	_{p=0.092 n=6}
_{ts-pre-modules - bun (v1.1.17, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{355,399k (± 0.35%)}	_{356,775k (± 0.26%)}	_{+1,376k (+ 0.39%)}	_355,710k	_358,199k	_{p=0.045 n=6}
_{Parse Time}	_{2.31s (± 0.59%)}	_{2.34s (± 1.44%)}	_~	_2.31s	_2.40s	_{p=0.183 n=6}
_{Bind Time}	_{1.44s (± 0.95%)}	_{1.43s (± 1.20%)}	_~	_1.41s	_1.45s	_{p=0.282 n=6}
_{Check Time}	_{14.35s (± 0.39%)}	_{14.52s (± 0.45%)}	_{+0.16s (+ 1.14%)}	_14.44s	_14.61s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.11s (± 0.33%)}	_{18.29s (± 0.35%)}	_{+0.18s (+ 0.98%)}	_18.22s	_18.41s	_{p=0.005 n=6}
_{vscode - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,879,835	_2,879,835	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,372	_975,372	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,105,899k (± 0.27%)}	_{3,137,837k (± 0.15%)}	_{+31,938k (+ 1.03%)}	_3,132,157k	_3,143,317k	_{p=0.005 n=6}
_{Parse Time}	_{13.67s (± 0.37%)}	_{13.74s (± 0.52%)}	_{+0.07s (+ 0.52%)}	_13.64s	_13.86s	_{p=0.037 n=6}
_{Bind Time}	_{4.64s (± 1.26%)}	_{4.56s (± 0.71%)}	_{-0.08s (- 1.76%)}	_4.50s	_4.59s	_{p=0.005 n=6}
_{Check Time}	_{79.24s (± 0.74%)}	_{79.48s (± 0.24%)}	_~	_79.23s	_79.74s	_{p=0.092 n=6}
_{Emit Time}	_{24.14s (± 0.89%)}	_{23.81s (± 0.43%)}	_{-0.32s (- 1.34%)}	_23.70s	_23.97s	_{p=0.008 n=6}
_{Total Time}	_{121.69s (± 0.53%)}	_{121.59s (± 0.20%)}	_~	_121.25s	_121.85s	_{p=0.689 n=6}
_{webpack - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,430k (± 0.17%)}	_{425,739k (± 0.46%)}	_{-3,691k (- 0.86%)}	_422,664k	_428,124k	_{p=0.005 n=6}
_{Parse Time}	_{3.10s (± 0.34%)}	_{3.10s (± 1.02%)}	_~	_3.06s	_3.15s	_{p=0.625 n=6}
_{Bind Time}	_{1.38s (± 1.25%)}	_{1.42s (± 2.56%)}	_{+0.04s (+ 2.66%)}	_1.38s	_1.48s	_{p=0.043 n=6}
_{Check Time}	_{13.84s (± 0.67%)}	_{13.77s (± 0.59%)}	_~	_13.66s	_13.84s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_{0.01s (±154.76%)}	_~	_0.00s	_0.02s	_{p=0.174 n=6}
_{Total Time}	_{18.32s (± 0.43%)}	_{18.28s (± 0.34%)}	_~	_18.17s	_18.34s	_{p=0.936 n=6}
_{xstate-main - bun (v1.1.17, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,436k (± 0.42%)}	_{458,406k (± 0.11%)}	_{-5,029k (- 1.09%)}	_458,071k	_459,306k	_{p=0.005 n=6}
_{Parse Time}	_{2.73s (± 0.91%)}	_{2.70s (± 0.51%)}	_{-0.04s (- 1.34%)}	_2.68s	_2.71s	_{p=0.007 n=6}
_{Bind Time}	_{1.02s (± 6.60%)}	_{1.07s (± 2.20%)}	_~	_1.04s	_1.10s	_{p=0.191 n=6}
_{Check Time}	_{15.85s (± 0.46%)}	_{15.88s (± 0.23%)}	_~	_15.83s	_15.94s	_{p=0.296 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.61s (± 0.47%)}	_{19.64s (± 0.25%)}	_~	_19.59s	_19.71s	_{p=0.335 n=6}

System info unknown

Hosts

bun (v1.1.17, x64)

Scenarios

Compiler-Unions - bun (v1.1.17, x64)
angular-1 - bun (v1.1.17, x64)
mui-docs - bun (v1.1.17, x64)
self-build-src - bun (v1.1.17, x64)
self-build-src-public-api - bun (v1.1.17, x64)
self-compiler - bun (v1.1.17, x64)
ts-pre-modules - bun (v1.1.17, x64)
vscode - bun (v1.1.17, x64)
webpack - bun (v1.1.17, x64)
xstate-main - bun (v1.1.17, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jun 30, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,831k (± 0.76%)}	_{192,968k (± 0.88%)}	_~	_191,649k	_195,158k	_{p=0.230 n=6}
_{Parse Time}	_{1.57s (± 1.24%)}	_{1.58s (± 0.48%)}	_~	_1.57s	_1.59s	_{p=0.383 n=6}
_{Bind Time}	_{0.85s (± 1.05%)}	_{0.85s (± 0.89%)}	_~	_0.84s	_0.86s	_{p=0.798 n=6}
_{Check Time}	_{11.16s (± 0.42%)}	_{11.06s (± 0.25%)}	_{-0.10s (- 0.87%)}	_11.05s	_11.12s	_{p=0.009 n=6}
_{Emit Time}	_{3.29s (± 0.85%)}	_{3.16s (± 0.49%)}	_{🟩-0.13s (- 3.85%)}	_3.13s	_3.17s	_{p=0.005 n=6}
_{Total Time}	_{16.87s (± 0.25%)}	_{16.65s (± 0.20%)}	_{-0.22s (- 1.29%)}	_16.61s	_16.70s	_{p=0.005 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,358k (± 0.00%)}	_{1,217,900k (± 0.00%)}	_{-458k (- 0.04%)}	_1,217,836k	_1,217,960k	_{p=0.005 n=6}
_{Parse Time}	_{7.95s (± 0.56%)}	_{7.92s (± 0.46%)}	_~	_7.88s	_7.97s	_{p=0.170 n=6}
_{Bind Time}	_{2.23s (± 0.79%)}	_{2.25s (± 0.59%)}	_~	_2.24s	_2.27s	_{p=0.241 n=6}
_{Check Time}	_{35.77s (± 0.45%)}	_{35.66s (± 0.37%)}	_~	_35.55s	_35.90s	_{p=0.298 n=6}
_{Emit Time}	_{16.15s (± 0.31%)}	_{15.93s (± 0.89%)}	_{-0.22s (- 1.34%)}	_15.68s	_16.07s	_{p=0.006 n=6}
_{Total Time}	_{62.10s (± 0.33%)}	_{61.76s (± 0.25%)}	_{-0.34s (- 0.55%)}	_61.52s	_61.99s	_{p=0.020 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,133,039	_2,133,039	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,444	_926,444	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,376k (± 0.01%)}	_{2,115,228k (± 0.00%)}	_{-148k (- 0.01%)}	_2,115,209k	_2,115,240k	_{p=0.005 n=6}
_{Parse Time}	_{6.65s (± 0.11%)}	_{6.62s (± 0.15%)}	_{-0.03s (- 0.40%)}	_6.61s	_6.63s	_{p=0.004 n=6}
_{Bind Time}	_{2.33s (± 0.90%)}	_{2.30s (± 0.22%)}	_{-0.03s (- 1.14%)}	_2.30s	_2.31s	_{p=0.036 n=6}
_{Check Time}	_{70.61s (± 0.58%)}	_{71.01s (± 0.30%)}	_~	_70.63s	_71.20s	_{p=0.128 n=6}
_{Emit Time}	_{0.14s (± 3.77%)}	_{0.14s (± 4.05%)}	_~	_0.13s	_0.14s	_{p=0.640 n=6}
_{Total Time}	_{79.73s (± 0.52%)}	_{80.07s (± 0.27%)}	_~	_79.69s	_80.27s	_{p=0.128 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,260	_1,225,260	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,341	_261,341	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,341,363k (± 0.06%)}	_{2,336,365k (± 0.05%)}	_{-4,998k (- 0.21%)}	_2,334,569k	_2,337,630k	_{p=0.005 n=6}
_{Parse Time}	_{6.05s (± 1.26%)}	_{6.02s (± 1.37%)}	_~	_5.91s	_6.14s	_{p=0.470 n=6}
_{Bind Time}	_{2.25s (± 0.81%)}	_{2.26s (± 0.54%)}	_~	_2.24s	_2.27s	_{p=0.572 n=6}
_{Check Time}	_{40.24s (± 0.58%)}	_{39.97s (± 0.29%)}	_{-0.27s (- 0.68%)}	_39.79s	_40.12s	_{p=0.045 n=6}
_{Emit Time}	_{3.13s (± 5.82%)}	_{3.05s (± 2.39%)}	_~	_2.99s	_3.18s	_{p=0.471 n=6}
_{Total Time}	_{51.67s (± 0.71%)}	_{51.30s (± 0.38%)}	_~	_50.98s	_51.59s	_{p=0.093 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,260	_1,225,260	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,341	_261,341	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,414,683k (± 0.03%)}	_{2,414,002k (± 0.06%)}	_~	_2,412,449k	_2,415,824k	_{p=0.471 n=6}
_{Parse Time}	_{6.26s (± 0.79%)}	_{6.28s (± 1.44%)}	_~	_6.15s	_6.35s	_{p=0.471 n=6}
_{Bind Time}	_{2.01s (± 1.13%)}	_{2.24s (± 4.48%)}	_{🔻+0.23s (+11.44%)}	_2.04s	_2.31s	_{p=0.005 n=6}
_{Check Time}	_{40.72s (± 0.29%)}	_{40.11s (± 0.46%)}	_{-0.61s (- 1.49%)}	_39.91s	_40.45s	_{p=0.005 n=6}
_{Emit Time}	_{3.19s (± 3.15%)}	_{3.17s (± 4.13%)}	_~	_3.05s	_3.34s	_{p=0.748 n=6}
_{Total Time}	_{52.18s (± 0.27%)}	_{51.80s (± 0.48%)}	_{-0.38s (- 0.72%)}	_51.51s	_52.11s	_{p=0.020 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,194	_258,194	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,737	_104,737	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,458k (± 0.00%)}	_{427,007k (± 0.01%)}	_{-451k (- 0.11%)}	_426,970k	_427,035k	_{p=0.005 n=6}
_{Parse Time}	_{4.08s (± 0.75%)}	_{4.05s (± 0.36%)}	_{-0.04s (- 0.86%)}	_4.03s	_4.07s	_{p=0.042 n=6}
_{Bind Time}	_{1.61s (± 0.85%)}	_{1.62s (± 1.00%)}	_~	_1.60s	_1.64s	_{p=0.328 n=6}
_{Check Time}	_{22.01s (± 0.51%)}	_{21.88s (± 0.47%)}	_~	_21.73s	_22.03s	_{p=0.066 n=6}
_{Emit Time}	_{1.54s (± 0.80%)}	_{1.60s (± 2.22%)}	_{🔻+0.07s (+ 4.56%)}	_1.57s	_1.66s	_{p=0.005 n=6}
_{Total Time}	_{29.24s (± 0.41%)}	_{29.15s (± 0.22%)}	_~	_29.08s	_29.26s	_{p=0.170 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,455k (± 0.01%)}	_{369,013k (± 0.01%)}	_{-442k (- 0.12%)}	_368,953k	_369,089k	_{p=0.005 n=6}
_{Parse Time}	_{2.76s (± 0.70%)}	_{2.75s (± 0.84%)}	_~	_2.71s	_2.78s	_{p=0.462 n=6}
_{Bind Time}	_{1.58s (± 0.40%)}	_{1.59s (± 0.83%)}	_~	_1.57s	_1.61s	_{p=0.081 n=6}
_{Check Time}	_{15.45s (± 0.50%)}	_{15.27s (± 0.14%)}	_{-0.18s (- 1.18%)}	_15.24s	_15.30s	_{p=0.005 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.79s (± 0.40%)}	_{19.61s (± 0.12%)}	_{-0.18s (- 0.90%)}	_19.57s	_19.64s	_{p=0.005 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,879,835	_2,879,835	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,372	_975,372	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,042,553k (± 0.00%)}	_{3,042,051k (± 0.00%)}	_{-502k (- 0.02%)}	_3,041,973k	_3,042,131k	_{p=0.005 n=6}
_{Parse Time}	_{13.63s (± 0.66%)}	_{13.59s (± 0.28%)}	_~	_13.54s	_13.64s	_{p=0.747 n=6}
_{Bind Time}	_{4.20s (± 2.06%)}	_{4.20s (± 0.48%)}	_~	_4.17s	_4.23s	_{p=0.102 n=6}
_{Check Time}	_{74.31s (± 2.29%)}	_{74.18s (± 2.58%)}	_~	_72.59s	_76.83s	_{p=0.810 n=6}
_{Emit Time}	_{22.65s (± 6.40%)}	_{22.39s (± 8.36%)}	_~	_20.12s	_24.24s	_{p=0.810 n=6}
_{Total Time}	_{114.79s (± 0.28%)}	_{114.37s (± 0.29%)}	_~	_113.97s	_114.81s	_{p=0.066 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,571k (± 0.01%)}	_{411,215k (± 0.02%)}	_{-356k (- 0.09%)}	_411,140k	_411,334k	_{p=0.005 n=6}
_{Parse Time}	_{3.83s (± 0.46%)}	_{3.80s (± 0.61%)}	_~	_3.77s	_3.83s	_{p=0.076 n=6}
_{Bind Time}	_{1.70s (± 0.44%)}	_{1.68s (± 0.53%)}	_{-0.02s (- 1.08%)}	_1.67s	_1.69s	_{p=0.011 n=6}
_{Check Time}	_{16.73s (± 0.45%)}	_{16.84s (± 0.37%)}	_{+0.11s (+ 0.67%)}	_16.75s	_16.94s	_{p=0.025 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.25s (± 0.34%)}	_{22.32s (± 0.26%)}	_~	_22.24s	_22.42s	_{p=0.092 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,869k (± 0.07%)}	_{462,639k (± 0.03%)}	_~	_462,522k	_462,869k	_{p=0.128 n=6}
_{Parse Time}	_{2.65s (± 0.52%)}	_{2.66s (± 0.31%)}	_~	_2.65s	_2.67s	_{p=0.094 n=6}
_{Bind Time}	_{0.98s (± 0.42%)}	_{0.99s (± 0.41%)}	_{+0.01s (+ 0.68%)}	_0.98s	_0.99s	_{p=0.034 n=6}
_{Check Time}	_{15.15s (± 0.26%)}	_{15.10s (± 0.44%)}	_~	_15.00s	_15.20s	_{p=0.170 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.02s	_{p=0.405 n=6}
_{Total Time}	_{18.77s (± 0.23%)}	_{18.75s (± 0.39%)}	_~	_18.64s	_18.86s	_{p=0.470 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,425ms (± 0.52%)}	_{3,425ms (± 0.31%)}	_~	_3,411ms	_3,437ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{7,551ms (± 0.72%)}	_{7,245ms (± 0.61%)}	_{🟩-306ms (- 4.05%)}	_7,205ms	_7,318ms	_{p=0.005 n=6}
_{Req 3 - references}	_{394ms (± 0.38%)}	_{403ms (± 0.22%)}	_{+9ms (+ 2.20%)}	_402ms	_404ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{341ms (± 0.19%)}	_{338ms (± 0.66%)}	_{-3ms (- 0.83%)}	_335ms	_342ms	_{p=0.046 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{130ms (± 1.19%)}	_{117ms (± 0.47%)}	_{🟩-14ms (-10.38%)}	_116ms	_117ms	_{p=0.004 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,420ms (± 0.51%)}	_{2,413ms (± 0.61%)}	_~	_2,396ms	_2,439ms	_{p=0.574 n=6}
_{Req 2 - geterr}	_{3,798ms (± 0.33%)}	_{3,729ms (± 0.53%)}	_{-69ms (- 1.81%)}	_3,707ms	_3,758ms	_{p=0.005 n=6}
_{Req 3 - references}	_{277ms (± 0.42%)}	_{283ms (± 0.37%)}	_{+6ms (+ 2.11%)}	_281ms	_284ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{226ms (± 0.36%)}	_{226ms (± 0.43%)}	_~	_225ms	_227ms	_{p=0.394 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 8.98%)}	_{77ms (± 6.65%)}	_~	_73ms	_84ms	_{p=0.195 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{6,472ms (± 5.99%)}	_{6,237ms (± 0.47%)}	_~	_6,219ms	_6,297ms	_{p=0.470 n=6}
_{Req 2 - geterr}	_{1,632ms (± 7.37%)}	_{1,626ms (± 8.19%)}	_~	_1,354ms	_1,692ms	_{p=1.000 n=6}
_{Req 3 - references}	_{109ms (± 9.13%)}	_{104ms (± 0.86%)}	_~	_103ms	_105ms	_{p=0.062 n=6}
_{Req 4 - navto}	_{579ms (± 7.13%)}	_{594ms (± 2.58%)}	_~	_566ms	_606ms	_{p=0.574 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,248ms (± 1.48%)}	_{1,249ms (± 1.25%)}	_~	_1,232ms	_1,276ms	_{p=0.810 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{189.19ms (± 0.16%)}	_{186.70ms (± 0.20%)}	_{-2.49ms (- 1.32%)}	_185.34ms	_193.79ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{283.68ms (± 0.27%)}	_{281.96ms (± 0.28%)}	_{-1.72ms (- 0.61%)}	_274.83ms	_290.72ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{277.05ms (± 0.27%)}	_{275.43ms (± 0.27%)}	_{-1.62ms (- 0.58%)}	_268.60ms	_278.71ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{276.32ms (± 0.28%)}	_{274.82ms (± 0.28%)}	_{-1.50ms (- 0.54%)}	_268.22ms	_278.28ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) closed this

Jun 30, 2024

Jacob Groß (kurtextrem) commented Jun 30, 2024

Copy link

Copy Markdown

For the curious why this has been closed, see Jake's reply on X: https://x.com/andhaveaniceday/status/1775243613506867262?t=dzeDZE6NiL6MgjodaKIUIA&s=19

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Jun 30, 2024

Copy link

Copy Markdown

Member Author

Well, mainly that we manually var'd everything critical and anything else seems to just be noise.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Microsoft (microsoft) locked as resolved and limited conversation to collaborators

Oct 16, 2025

Jake Bailey (jakebailey) deleted the babel-let-const branch

August 20, 2026 05:22

Reviewers

Copilot code review Copilot

Copilot will automatically review once the pull request is marked ready for review

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Jake Bailey (jakebailey)

Labels

Author: Team For Uncommitted Bug

PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Jake Bailey (jakebailey) commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Feb 7, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Feb 7, 2023

Compiler

TSServer

Startup

Uh oh!

Mateusz Burzyński (Andarist) commented Feb 7, 2023

Uh oh!

Jake Bailey (jakebailey) commented Feb 7, 2023

Uh oh!

Mateusz Burzyński (Andarist) commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Feb 7, 2023

Uh oh!

Bruce Pascoe (fatcerberus) commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Feb 7, 2023

Uh oh!

Bruce Pascoe (fatcerberus) commented Feb 7, 2023

Uh oh!

Jake Bailey (jakebailey) commented Feb 7, 2023

Uh oh!

Jake Bailey (jakebailey) commented Feb 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Feb 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Feb 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jarred Sumner (Jarred-Sumner) commented Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Feb 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Feb 8, 2023

Uh oh!

Jarred Sumner (Jarred-Sumner) commented Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marvin Hagemeister (marvinhagemeister) commented Feb 8, 2023

Uh oh!

Jake Bailey (jakebailey) commented Feb 8, 2023

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Jake Bailey (jakebailey) commented Aug 30, 2023

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Aug 30, 2023

Compiler

Startup

Uh oh!

Jake Bailey (jakebailey) commented Jan 11, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Jan 11, 2024

tsc

Uh oh!

Jake Bailey (jakebailey) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Bruce Pascoe (fatcerberus) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 7, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Feb 8, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Jarred Sumner (Jarred-Sumner) commented Feb 8, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Jarred Sumner (Jarred-Sumner) commented Feb 8, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Aug 30, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jan 11, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 19, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Jun 30, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.