GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Cherry pick PR #57887 into release-5.4 by jakebailey · Pull Request #57898 · microsoft/TypeScript

Conversation

@jakebailey

@jakebailey Jake Bailey (jakebailey) commented Mar 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See #57887

I have no idea why the baselines are so big in the cherry pick compared to main, but they're all improvements?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Wesley Wigham (weswigham) and others added 2 commits March 21, 2024 15:49
@weswigham @jakebailey
Lookup retained type nodes in the node builder using correct, specifi…
a9375fd
…c SymbolFlags meaning (microsoft#57887)
@jakebailey
Update baselines
dd43d0e
@jakebailey
Jake Bailey (jakebailey) requested a review from Wesley Wigham (weswigham) March 21, 2024 22:55
@typescript-bot TypeScript Bot (typescript-bot) assigned Jake Bailey (jakebailey) Mar 21, 2024
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 21, 2024
@jakebailey Jake Bailey (jakebailey) mentioned this pull request Mar 21, 2024
Lookup retained type nodes in the node builder using correct, specific SymbolFlags meaning #57887
Merged
weswigham
Wesley Wigham (weswigham) reviewed Mar 22, 2024
View reviewed changes
Comment thread tests/baselines/reference/ParameterList5.types
=== ParameterList5.ts ===
function A(): (public B) => C {
>A : () => (B: any) => C
>A : () => (public B) => C

@weswigham Wesley Wigham (weswigham) Mar 22, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes like this one aren't in main because #57772 added checks/transforms to prevent them. Here, for example, now we lookup B successfully and think "hey, I'll just reuse the node" (which also happens with the isDeclarationName fix added in #57772, for this specific case), but the node's got a modifier that needs deleting and a : any that needs adding that it doesn't add, while in #57772 I added a line to the visitor to add the missing : any and drop the public from existing nodes in the node builder. There's a couple changes like this in here. They're not that bad a change because it's not like this node's form nowhere - it's the input, so it's at least no worse than the input - but seeing an error in the input (like this) and just dumping the erroneous node into the output is something we usually try to avoid. We could also backport the changes to visitExistingNodeTreeSymbols from that PR if we want to minimize the diff.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@jakebailey Jake Bailey (jakebailey) Mar 22, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that this PR is wrong without that other PR? Or is this PR safe to include in a patch by itself?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jakebailey Jake Bailey (jakebailey) assigned Daniel Rosenwasser (DanielRosenwasser) Mar 28, 2024
@jakebailey
Jake Bailey (jakebailey) requested a review from Daniel Rosenwasser (DanielRosenwasser) March 28, 2024 17:53
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit 3caec2c into microsoft:release-5.4 Mar 28, 2024
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Mar 28, 2024
A shadowed variable is generated in a an async function with a default parameter declared as a static property of a class when targeting ES5. #57897
Closed
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) added this to the TypeScript 5.4.32 milestone Mar 28, 2024
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) changed the title Cherry pick PR 57887 into release-5.4 Cherry pick PR #57887 into release-5.4 Mar 28, 2024
@jakebailey
Jake Bailey (jakebailey) deleted the release-5.4-57887 branch June 17, 2024 21:09
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham left review comments
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser)

@jakebailey Jake Bailey (jakebailey)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

TypeScript 5.4.4

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jakebailey @weswigham @DanielRosenwasser @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.