GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Improve logic that chooses co- vs. contra-variant inferences by Andarist · Pull Request #57909 · microsoft/TypeScript

Conversation

Mateusz Burzyński (Andarist) commented Mar 22, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

To review this it might be helpful to see how this evolved over time:
#27028
#46392
#52123
#52180
#54072

The reason why this inference fails today is that isTypeSubtypeOf leads to requireOptionalProperties === true. This has such inferences:

inferredCovariantType // { query: string }
inferredContravariantType // { query?: unknown; body?: unknown; }

So the covariant inference lacks body property and thus it fails the check and the contravariant inference gets chosen at the end.

fixes #57908
fixes #58468

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Improve logic that chooses co- vs. contra-variant inferences

80491eb

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label

Mar 22, 2024

TypeScript Bot (typescript-bot) commented Mar 22, 2024

Copy link

Copy Markdown

Contributor

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented Mar 22, 2024

Copy link

Copy Markdown

Member

TypeScript Bot (@typescript-bot) test top800
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (@typescript-bot) perf test this faster

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 22, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top800`	✅ Started
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) commented

Mar 22, 2024

View reviewed changes

Comment thread

src/compiler/checker.ts

		const preferCovariantType = inferredCovariantType && (!inferredContravariantType \|\|
		!(inferredCovariantType.flags & TypeFlags.Never) &&
		some(inference.contraCandidates, t => isTypeSubtypeOf(inferredCovariantType, t)) &&
		some(inference.contraCandidates, t => isTypeAssignableTo(inferredCovariantType, t)) &&

Mateusz Burzyński (Andarist) Mar 22, 2024

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not the correct change then at the very least a test case should be proposed that shows how the isTypeSubtypeOf is better.

When this check was originally introduced by Anders Hejlsberg (@ahejlsberg) here it was states that:

Furthermore, knowing that an error will result when the co-variant inference is not a subtype of the contra-variant inference, we now prefer the contra-variant inference because it is likely to have come from an explicit type annotation on a function. This improves our error reporting.

An alternative idea to fix this example would be to keep coAndContraRelationCheck on inferenceContext. From what I understand, the subtypeRelation in this context is mainly used when dealing with multiple overloads - a single signature case uses assignableRelation with chooseOverload. So perhaps the used relation should determine what is being used here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

TypeScript Bot (typescript-bot) commented Mar 22, 2024

Copy link

Copy Markdown

Contributor

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: react
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/react/test/index.ts
  794:5  error  TypeScript@local compile error: 
Unused '@ts-expect-error' directive  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: styled-theming
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/styled-theming/styled-theming-tests.tsx
  72:47  error  TypeScript@local compile error: 
No overload matches this call.
  The last overload gave the following error.
    Type '"wrong variant"' is not assignable to type '"primary" | "secondary" | undefined'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 22, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey) Here are the results of running the user tests comparing main and refs/pull/57909/merge:

Something interesting changed - please have a look.

Details

uglify-js

/mnt/ts_downloads/_/m/uglify-js/tsconfig.json

[NEW] error TS2684: The 'this' context of type '(...items: never[]) => number' is not assignable to method's 'this' of type '(this: any[], ...args: any) => number'.
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(293,17)
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(2472,29)
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(7469,47)
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(14005,13)
[NEW] error TS2684: The 'this' context of type '(...items: never[]) => number' is not assignable to method's 'this' of type '(this: any, ...args: any) => number'.
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(1867,13)
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(7298,64)
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(7981,33)
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(8012,29)
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/compress.js(14002,17)
- /mnt/ts_downloads/_/m/uglify-js/node_modules/uglify-js/lib/parse.js(1863,17)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 22, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,529k (± 0.00%)}	_{295,524k (± 0.00%)}	_~	_295,506k	_295,544k	_{p=0.423 n=6}
_{Parse Time}	_{2.66s (± 0.31%)}	_{2.66s (± 0.28%)}	_~	_2.65s	_2.67s	_{p=0.209 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.82s (± 0.99%)}	_~	_0.81s	_0.83s	_{p=0.859 n=6}
_{Check Time}	_{8.20s (± 0.37%)}	_{8.20s (± 0.15%)}	_~	_8.18s	_8.21s	_{p=0.809 n=6}
_{Emit Time}	_{7.04s (± 0.20%)}	_{7.09s (± 0.88%)}	_~	_7.00s	_7.18s	_{p=0.107 n=6}
_{Total Time}	_{18.72s (± 0.16%)}	_{18.76s (± 0.32%)}	_~	_18.69s	_18.86s	_{p=0.225 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,964k (± 0.06%)}	_{193,733k (± 0.95%)}	_~	_191,878k	_195,497k	_{p=0.128 n=6}
_{Parse Time}	_{1.36s (± 0.89%)}	_{1.36s (± 1.21%)}	_~	_1.33s	_1.38s	_{p=1.000 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.56s (± 0.60%)}	_{9.49s (± 0.37%)}	_{-0.08s (- 0.80%)}	_9.44s	_9.54s	_{p=0.045 n=6}
_{Emit Time}	_{2.62s (± 0.51%)}	_{2.63s (± 0.64%)}	_~	_2.61s	_2.65s	_{p=0.227 n=6}
_{Total Time}	_{14.26s (± 0.40%)}	_{14.19s (± 0.39%)}	_~	_14.11s	_14.28s	_{p=0.090 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,372k (± 0.01%)}	_{347,374k (± 0.01%)}	_~	_347,324k	_347,407k	_{p=0.873 n=6}
_{Parse Time}	_{2.47s (± 0.33%)}	_{2.48s (± 0.40%)}	_~	_2.47s	_2.49s	_{p=0.498 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.92s (± 0.59%)}	_~	_0.92s	_0.93s	_{p=0.282 n=6}
_{Check Time}	_{7.00s (± 0.41%)}	_{7.02s (± 0.49%)}	_~	_6.97s	_7.07s	_{p=0.465 n=6}
_{Emit Time}	_{4.08s (± 0.37%)}	_{4.07s (± 0.40%)}	_~	_4.04s	_4.08s	_{p=0.157 n=6}
_{Total Time}	_{14.49s (± 0.26%)}	_{14.49s (± 0.23%)}	_~	_14.45s	_14.55s	_{p=0.872 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,726k (± 0.02%)}	_{302,708k (± 0.01%)}	_~	_302,678k	_302,760k	_{p=0.575 n=6}
_{Parse Time}	_{2.41s (± 0.68%)}	_{2.39s (± 1.72%)}	_~	_2.34s	_2.44s	_{p=0.571 n=6}
_{Bind Time}	_{1.19s (± 0.53%)}	_{1.19s (± 1.02%)}	_~	_1.17s	_1.20s	_{p=0.673 n=6}
_{Check Time}	_{7.44s (± 0.56%)}	_{7.45s (± 0.46%)}	_~	_7.41s	_7.50s	_{p=0.376 n=6}
_{Emit Time}	_{4.28s (± 0.41%)}	_{4.29s (± 0.58%)}	_~	_4.26s	_4.33s	_{p=1.000 n=6}
_{Total Time}	_{15.33s (± 0.34%)}	_{15.32s (± 0.48%)}	_~	_15.24s	_15.42s	_{p=0.688 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{509,876k (± 0.01%)}	_{509,895k (± 0.00%)}	_~	_509,875k	_509,907k	_{p=0.125 n=6}
_{Parse Time}	_{2.64s (± 0.37%)}	_{2.65s (± 0.65%)}	_~	_2.63s	_2.67s	_{p=0.215 n=6}
_{Bind Time}	_{0.99s (± 0.99%)}	_{0.98s (± 0.56%)}	_~	_0.98s	_0.99s	_{p=0.322 n=6}
_{Check Time}	_{17.23s (± 0.22%)}	_{17.23s (± 0.37%)}	_~	_17.15s	_17.32s	_{p=1.000 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.86s (± 0.19%)}	_{20.87s (± 0.29%)}	_~	_20.81s	_20.98s	_{p=0.746 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,737,544k (± 0.00%)}	_{1,737,524k (± 0.00%)}	_~	_1,737,491k	_1,737,554k	_{p=0.230 n=6}
_{Parse Time}	_{7.78s (± 0.38%)}	_{7.80s (± 0.61%)}	_~	_7.74s	_7.88s	_{p=0.373 n=6}
_{Bind Time}	_{2.80s (± 0.32%)}	_{2.81s (± 0.83%)}	_~	_2.78s	_2.84s	_{p=0.806 n=6}
_{Check Time}	_{66.38s (± 0.34%)}	_{66.49s (± 0.45%)}	_~	_66.11s	_66.91s	_{p=0.521 n=6}
_{Emit Time}	_{0.15s (± 3.53%)}	_{0.16s (± 3.29%)}	_~	_0.15s	_0.16s	_{p=0.640 n=6}
_{Total Time}	_{77.12s (± 0.32%)}	_{77.25s (± 0.34%)}	_~	_76.98s	_77.63s	_{p=0.471 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,394,217k (± 0.02%)}	_{2,393,952k (± 0.04%)}	_~	_2,392,566k	_2,394,786k	_{p=0.471 n=6}
_{Parse Time}	_{6.07s (± 0.90%)}	_{6.07s (± 0.68%)}	_~	_6.02s	_6.11s	_{p=0.688 n=6}
_{Bind Time}	_{2.26s (± 0.52%)}	_{2.24s (± 1.68%)}	_~	_2.17s	_2.28s	_{p=0.415 n=6}
_{Check Time}	_{39.48s (± 0.29%)}	_{39.61s (± 0.22%)}	_{+0.14s (+ 0.34%)}	_39.48s	_39.73s	_{p=0.045 n=6}
_{Emit Time}	_{3.12s (± 0.48%)}	_{3.15s (± 1.61%)}	_~	_3.08s	_3.21s	_{p=0.520 n=6}
_{Total Time}	_{50.94s (± 0.22%)}	_{51.08s (± 0.20%)}	_{+0.14s (+ 0.27%)}	_50.89s	_51.20s	_{p=0.045 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,185k (± 0.01%)}	_{415,193k (± 0.01%)}	_~	_415,144k	_415,226k	_{p=0.936 n=6}
_{Parse Time}	_{3.43s (± 0.96%)}	_{3.42s (± 0.75%)}	_~	_3.39s	_3.45s	_{p=0.807 n=6}
_{Bind Time}	_{1.29s (± 0.76%)}	_{1.29s (± 0.82%)}	_~	_1.27s	_1.30s	_{p=0.547 n=6}
_{Check Time}	_{18.02s (± 0.35%)}	_{18.01s (± 0.43%)}	_~	_17.89s	_18.11s	_{p=0.872 n=6}
_{Emit Time}	_{1.31s (± 1.12%)}	_{1.32s (± 0.88%)}	_~	_1.31s	_1.34s	_{p=0.324 n=6}
_{Total Time}	_{24.06s (± 0.35%)}	_{24.04s (± 0.30%)}	_~	_23.94s	_24.16s	_{p=0.806 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,889,942k (± 0.00%)}	_{2,889,412k (± 0.00%)}	_{-531k (- 0.02%)}	_2,889,325k	_2,889,479k	_{p=0.005 n=6}
_{Parse Time}	_{12.95s (± 0.27%)}	_{12.94s (± 0.27%)}	_~	_12.91s	_13.00s	_{p=0.683 n=6}
_{Bind Time}	_{4.13s (± 0.82%)}	_{4.14s (± 0.64%)}	_~	_4.10s	_4.17s	_{p=0.746 n=6}
_{Check Time}	_{71.13s (± 0.24%)}	_{71.45s (± 0.31%)}	_{+0.32s (+ 0.45%)}	_71.14s	_71.74s	_{p=0.045 n=6}
_{Emit Time}	_{19.50s (± 0.88%)}	_{19.40s (± 0.79%)}	_~	_19.18s	_19.60s	_{p=0.336 n=6}
_{Total Time}	_{107.71s (± 0.35%)}	_{107.93s (± 0.32%)}	_~	_107.57s	_108.40s	_{p=0.378 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,193k (± 0.03%)}	_{408,153k (± 0.01%)}	_~	_408,080k	_408,221k	_{p=0.810 n=6}
_{Parse Time}	_{3.89s (± 0.72%)}	_{3.90s (± 0.67%)}	_~	_3.86s	_3.94s	_{p=0.623 n=6}
_{Bind Time}	_{1.67s (± 0.49%)}	_{1.69s (± 0.89%)}	_{+0.02s (+ 1.20%)}	_1.67s	_1.70s	_{p=0.031 n=6}
_{Check Time}	_{16.80s (± 0.32%)}	_{16.72s (± 0.20%)}	_{-0.08s (- 0.46%)}	_16.67s	_16.77s	_{p=0.037 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.36s (± 0.18%)}	_{22.31s (± 0.20%)}	_~	_22.25s	_22.36s	_{p=0.077 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,982k (± 0.01%)}	_{513,035k (± 0.02%)}	_~	_512,919k	_513,174k	_{p=0.471 n=6}
_{Parse Time}	_{3.96s (± 0.43%)}	_{3.94s (± 0.42%)}	_~	_3.92s	_3.97s	_{p=0.052 n=6}
_{Bind Time}	_{1.85s (± 0.90%)}	_{1.85s (± 1.15%)}	_~	_1.82s	_1.87s	_{p=1.000 n=6}
_{Check Time}	_{3.37s (± 0.55%)}	_{3.37s (± 0.24%)}	_~	_3.36s	_3.38s	_{p=0.870 n=6}
_{Emit Time}	_{0.08s (± 6.19%)}	_{0.09s (± 6.44%)}	_~	_0.08s	_0.09s	_{p=0.640 n=6}
_{Total Time}	_{9.28s (± 0.19%)}	_{9.25s (± 0.33%)}	_~	_9.22s	_9.30s	_{p=0.090 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ryan Cavanaugh (RyanCavanaugh) mentioned this pull request

Mar 22, 2024

Add missing test coverage found in #57909 #57911

Closed

1 task done

Jake Bailey (jakebailey) commented Mar 22, 2024

Copy link

Copy Markdown

Member

TypeScript Bot (@typescript-bot) pack this

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 22, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 22, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160700/artifacts?artifactName=tgz&fileId=09532E0BDDB3EF1D0C0185CBFA531EE829D75833400D06C510FCB93118E30D0C02&fileName=/typescript-5.5.0-insiders.20240322.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) added 2 commits

March 23, 2024 10:14


          rename test file

f78cea6


          ignore covariant any inferences when contravariant candidates are ava…

237aba6

…ilable

TypeScript Bot (typescript-bot) added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels

Mar 23, 2024

Mateusz Burzyński (Andarist) commented Mar 23, 2024

Copy link

Copy Markdown

Contributor Author

Jake Bailey (@jakebailey) could you rerun top800, dt and perf suites? a new playground would also be appreciated :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) mentioned this pull request

Mar 23, 2024

Add nested call and new expressions as potential intra expression inference sites #54183

Closed

Jake Bailey (jakebailey) commented Mar 23, 2024

Copy link

Copy Markdown

Member

TypeScript Bot (@typescript-bot) test top800
TypeScript Bot (@typescript-bot) user test this
TypeScript Bot (@typescript-bot) run dt

TypeScript Bot (@typescript-bot) perf test this faster
TypeScript Bot (@typescript-bot) pack this

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 23, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top800`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 23, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Hey Jake Bailey (@jakebailey), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/160702/artifacts?artifactName=tgz&fileId=C476EBF980531EB5F87264AF4D7EFD709FC10481D708D1A72266850B714544B902&fileName=/typescript-5.5.0-insiders.20240323.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 23, 2024

Copy link

Copy Markdown

Contributor

Hey Jake Bailey (@jakebailey), the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: styled-theming
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/styled-theming/styled-theming-tests.tsx
  72:47  error  TypeScript@local compile error: 
No overload matches this call.
  The last overload gave the following error.
    Type '"wrong variant"' is not assignable to type '"primary" | "secondary" | undefined'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 23, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey) Here are the results of running the user tests comparing main and refs/pull/57909/merge:

Everything looks good!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 23, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,530k (± 0.01%)}	_{295,537k (± 0.01%)}	_~	_295,512k	_295,555k	_{p=1.000 n=6}
_{Parse Time}	_{2.66s (± 0.37%)}	_{2.66s (± 0.28%)}	_~	_2.65s	_2.67s	_{p=0.652 n=6}
_{Bind Time}	_{0.82s (± 0.66%)}	_{0.83s (± 0.49%)}	_~	_0.83s	_0.84s	_{p=0.054 n=6}
_{Check Time}	_{8.20s (± 0.32%)}	_{8.22s (± 0.60%)}	_~	_8.17s	_8.29s	_{p=0.872 n=6}
_{Emit Time}	_{7.07s (± 0.35%)}	_{7.05s (± 0.64%)}	_~	_7.02s	_7.14s	_{p=0.222 n=6}
_{Total Time}	_{18.76s (± 0.19%)}	_{18.76s (± 0.33%)}	_~	_18.68s	_18.84s	_{p=1.000 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,468k (± 0.73%)}	_{194,259k (± 0.94%)}	_~	_191,886k	_195,602k	_{p=0.093 n=6}
_{Parse Time}	_{1.37s (± 0.97%)}	_{1.36s (± 1.52%)}	_~	_1.33s	_1.39s	_{p=0.250 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.51s (± 0.66%)}	_{9.52s (± 0.57%)}	_~	_9.43s	_9.59s	_{p=1.000 n=6}
_{Emit Time}	_{2.63s (± 0.95%)}	_{2.62s (± 0.96%)}	_~	_2.58s	_2.64s	_{p=0.461 n=6}
_{Total Time}	_{14.23s (± 0.53%)}	_{14.21s (± 0.41%)}	_~	_14.11s	_14.26s	_{p=0.573 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,373k (± 0.01%)}	_{347,383k (± 0.00%)}	_~	_347,358k	_347,402k	_{p=0.575 n=6}
_{Parse Time}	_{2.48s (± 0.33%)}	_{2.48s (± 0.30%)}	_~	_2.47s	_2.49s	_{p=0.729 n=6}
_{Bind Time}	_{0.93s (± 0.88%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.929 n=6}
_{Check Time}	_{7.00s (± 0.49%)}	_{7.00s (± 0.38%)}	_~	_6.97s	_7.04s	_{p=0.686 n=6}
_{Emit Time}	_{4.07s (± 0.34%)}	_{4.07s (± 0.26%)}	_~	_4.05s	_4.08s	_{p=1.000 n=6}
_{Total Time}	_{14.48s (± 0.28%)}	_{14.48s (± 0.18%)}	_~	_14.45s	_14.52s	_{p=0.808 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,725k (± 0.01%)}	_{302,715k (± 0.02%)}	_~	_302,659k	_302,798k	_{p=0.575 n=6}
_{Parse Time}	_{2.40s (± 1.41%)}	_{2.51s (± 8.80%)}	_~	_2.39s	_2.96s	_{p=0.260 n=6}
_{Bind Time}	_{1.21s (± 0.68%)}	_{1.24s (±10.13%)}	_~	_1.18s	_1.50s	_{p=0.230 n=6}
_{Check Time}	_{7.46s (± 0.50%)}	_{7.75s (± 9.17%)}	_~	_7.43s	_9.20s	_{p=0.574 n=6}
_{Emit Time}	_{4.29s (± 0.54%)}	_{4.45s (± 9.53%)}	_~	_4.25s	_5.31s	_{p=0.571 n=6}
_{Total Time}	_{15.35s (± 0.38%)}	_{15.95s (± 9.29%)}	_~	_15.32s	_18.97s	_{p=0.748 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{509,900k (± 0.00%)}	_{509,884k (± 0.00%)}	_~	_509,859k	_509,917k	_{p=0.128 n=6}
_{Parse Time}	_{2.66s (± 0.63%)}	_{2.65s (± 0.70%)}	_~	_2.62s	_2.67s	_{p=0.325 n=6}
_{Bind Time}	_{0.99s (± 1.05%)}	_{0.99s (± 0.82%)}	_~	_0.98s	_1.00s	_{p=0.270 n=6}
_{Check Time}	_{17.22s (± 0.44%)}	_{17.23s (± 0.53%)}	_~	_17.17s	_17.41s	_{p=0.936 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.86s (± 0.41%)}	_{20.87s (± 0.48%)}	_~	_20.81s	_21.07s	_{p=0.936 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,737,562k (± 0.00%)}	_{1,737,442k (± 0.00%)}	_{-120k (- 0.01%)}	_1,737,418k	_1,737,479k	_{p=0.005 n=6}
_{Parse Time}	_{7.77s (± 0.27%)}	_{7.79s (± 0.86%)}	_~	_7.73s	_7.92s	_{p=0.746 n=6}
_{Bind Time}	_{2.80s (± 0.27%)}	_{2.80s (± 0.42%)}	_~	_2.79s	_2.82s	_{p=0.933 n=6}
_{Check Time}	_{66.67s (± 0.41%)}	_{66.46s (± 0.27%)}	_~	_66.19s	_66.65s	_{p=0.229 n=6}
_{Emit Time}	_{0.15s (± 2.69%)}	_{0.15s (± 3.36%)}	_~	_0.15s	_0.16s	_{p=0.595 n=6}
_{Total Time}	_{77.40s (± 0.34%)}	_{77.21s (± 0.22%)}	_~	_76.94s	_77.36s	_{p=0.173 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,393,895k (± 0.05%)}	_{2,393,977k (± 0.02%)}	_~	_2,393,272k	_2,394,910k	_{p=0.471 n=6}
_{Parse Time}	_{6.10s (± 0.95%)}	_{6.05s (± 1.13%)}	_~	_5.96s	_6.14s	_{p=0.261 n=6}
_{Bind Time}	_{2.26s (± 0.78%)}	_{2.25s (± 1.21%)}	_~	_2.20s	_2.27s	_{p=1.000 n=6}
_{Check Time}	_{39.45s (± 0.41%)}	_{39.49s (± 0.41%)}	_~	_39.38s	_39.81s	_{p=0.810 n=6}
_{Emit Time}	_{3.10s (± 2.12%)}	_{3.11s (± 1.39%)}	_~	_3.04s	_3.17s	_{p=0.936 n=6}
_{Total Time}	_{50.90s (± 0.36%)}	_{50.93s (± 0.40%)}	_~	_50.74s	_51.30s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{415,116k (± 0.01%)}	_{415,122k (± 0.01%)}	_~	_415,083k	_415,153k	_{p=0.936 n=6}
_{Parse Time}	_{4.19s (± 0.63%)}	_{4.20s (± 0.53%)}	_~	_4.17s	_4.23s	_{p=0.864 n=6}
_{Bind Time}	_{1.58s (± 1.36%)}	_{1.60s (± 1.62%)}	_~	_1.56s	_1.63s	_{p=0.421 n=6}
_{Check Time}	_{22.33s (± 0.38%)}	_{22.27s (± 0.47%)}	_~	_22.16s	_22.46s	_{p=0.228 n=6}
_{Emit Time}	_{1.65s (± 0.99%)}	_{1.66s (± 0.62%)}	_~	_1.65s	_1.67s	_{p=0.242 n=6}
_{Total Time}	_{29.76s (± 0.35%)}	_{29.72s (± 0.32%)}	_~	_29.62s	_29.88s	_{p=0.575 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,891,049k (± 0.00%)}	_{2,891,279k (± 0.00%)}	_{+230k (+ 0.01%)}	_2,891,226k	_2,891,343k	_{p=0.005 n=6}
_{Parse Time}	_{12.93s (± 0.35%)}	_{12.92s (± 0.26%)}	_~	_12.88s	_12.98s	_{p=1.000 n=6}
_{Bind Time}	_{4.13s (± 0.54%)}	_{4.13s (± 0.32%)}	_~	_4.12s	_4.15s	_{p=0.807 n=6}
_{Check Time}	_{71.47s (± 0.29%)}	_{71.67s (± 0.34%)}	_~	_71.32s	_71.99s	_{p=0.230 n=6}
_{Emit Time}	_{19.43s (± 0.95%)}	_{19.41s (± 0.84%)}	_~	_19.25s	_19.64s	_{p=0.872 n=6}
_{Total Time}	_{107.96s (± 0.27%)}	_{108.12s (± 0.24%)}	_~	_107.85s	_108.59s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{408,129k (± 0.01%)}	_{408,163k (± 0.01%)}	_~	_408,104k	_408,215k	_{p=0.173 n=6}
_{Parse Time}	_{3.90s (± 0.70%)}	_{3.89s (± 0.23%)}	_~	_3.88s	_3.90s	_{p=0.934 n=6}
_{Bind Time}	_{1.68s (± 0.58%)}	_{1.67s (± 0.76%)}	_~	_1.65s	_1.69s	_{p=0.116 n=6}
_{Check Time}	_{16.78s (± 0.24%)}	_{16.74s (± 0.20%)}	_~	_16.69s	_16.77s	_{p=0.086 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.36s (± 0.24%)}	_{22.31s (± 0.19%)}	_~	_22.25s	_22.36s	_{p=0.064 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,044k (± 0.02%)}	_{513,043k (± 0.02%)}	_~	_512,923k	_513,149k	_{p=0.936 n=6}
_{Parse Time}	_{3.95s (± 0.55%)}	_{3.94s (± 0.30%)}	_~	_3.92s	_3.95s	_{p=0.747 n=6}
_{Bind Time}	_{1.84s (± 0.95%)}	_{1.85s (± 0.99%)}	_~	_1.83s	_1.87s	_{p=0.508 n=6}
_{Check Time}	_{3.37s (± 0.99%)}	_{3.37s (± 0.55%)}	_~	_3.35s	_3.40s	_{p=0.515 n=6}
_{Emit Time}	_{0.09s (± 6.44%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=0.282 n=6}
_{Total Time}	_{9.24s (± 0.61%)}	_{9.25s (± 0.38%)}	_~	_9.19s	_9.29s	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 23, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey) Here are the results of running the top 800 repos comparing main and refs/pull/57909/merge:

Everything looks good!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) commented Mar 23, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

The only reported error here is actually desired! See the comment here. I didn't look into this one before because of that and because it just involves multiple libraries with complicated type. I plan to reduce it to a test case now and add it here.

EDIT:// From this initial repro: TS playground to this TS playground. It's pretty lengthy but I already have problems with removing from it just about anything.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) mentioned this pull request

Mar 25, 2024

[react] React 18 types DefinitelyTyped/DefinitelyTyped#56210

Merged

6 tasks done

Mateusz Burzyński (Andarist) added 2 commits

March 25, 2024 21:12


          Merge remote-tracking branch 'origin/main' into tweak-co-contra-infer…

6688f3c

…ence


          Merge remote-tracking branch 'origin/main' into tweak-co-contra-infer…

03d0eb1

…ence

Mateusz Burzyński (Andarist) commented May 9, 2024

Copy link

Copy Markdown

Contributor Author

Still just one error :p and I have commented on it already here

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented May 9, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,795k (± 0.76%)}	_{192,759k (± 0.78%)}	_~	_192,109k	_195,825k	_{p=0.378 n=6}
_{Parse Time}	_{1.29s (± 1.74%)}	_{1.30s (± 1.16%)}	_~	_1.28s	_1.31s	_{p=0.864 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.52s (± 0.32%)}	_{9.51s (± 0.19%)}	_~	_9.49s	_9.54s	_{p=0.419 n=6}
_{Emit Time}	_{2.65s (± 0.19%)}	_{2.64s (± 0.31%)}	_{-0.01s (- 0.38%)}	_2.63s	_2.65s	_{p=0.050 n=6}
_{Total Time}	_{14.19s (± 0.36%)}	_{14.16s (± 0.13%)}	_~	_14.13s	_14.18s	_{p=0.294 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,120	_{+10 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_407,141	_407,148	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,221,999k (± 0.00%)}	_{1,222,003k (± 0.00%)}	_~	_1,221,955k	_1,222,042k	_{p=1.000 n=6}
_{Parse Time}	_{6.80s (± 0.71%)}	_{6.81s (± 0.66%)}	_~	_6.75s	_6.87s	_{p=0.810 n=6}
_{Bind Time}	_{1.88s (± 0.48%)}	_{1.88s (± 0.88%)}	_~	_1.85s	_1.89s	_{p=0.803 n=6}
_{Check Time}	_{31.09s (± 0.34%)}	_{31.15s (± 0.53%)}	_~	_31.03s	_31.47s	_{p=0.630 n=6}
_{Emit Time}	_{14.72s (± 0.66%)}	_{14.78s (± 0.29%)}	_~	_14.72s	_14.84s	_{p=0.377 n=6}
_{Total Time}	_{54.49s (± 0.17%)}	_{54.61s (± 0.34%)}	_~	_54.42s	_54.93s	_{p=0.173 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,961,290	_1,961,274	_{-16 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_696,905	_696,860	_{-45 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,778,074k (± 0.00%)}	_{1,778,019k (± 0.00%)}	_{-56k (- 0.00%)}	_1,778,006k	_1,778,038k	_{p=0.005 n=6}
_{Parse Time}	_{6.77s (± 0.38%)}	_{6.78s (± 0.24%)}	_~	_6.76s	_6.81s	_{p=0.332 n=6}
_{Bind Time}	_{2.31s (± 1.11%)}	_{2.31s (± 0.22%)}	_~	_2.31s	_2.32s	_{p=0.928 n=6}
_{Check Time}	_{57.01s (± 0.32%)}	_{56.97s (± 0.34%)}	_~	_56.74s	_57.28s	_{p=0.575 n=6}
_{Emit Time}	_0.14s	_0.14s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{66.23s (± 0.29%)}	_{66.20s (± 0.28%)}	_~	_65.97s	_66.49s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,220,247	_1,220,280	_{+33 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_258,932	_258,941	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,334,478k (± 0.04%)}	_{2,334,608k (± 0.03%)}	_~	_2,333,545k	_2,335,230k	_{p=0.936 n=6}
_{Parse Time}	_{4.99s (± 1.79%)}	_{4.96s (± 1.57%)}	_~	_4.85s	_5.07s	_{p=0.810 n=6}
_{Bind Time}	_{1.86s (± 0.63%)}	_{1.88s (± 1.00%)}	_~	_1.86s	_1.91s	_{p=0.187 n=6}
_{Check Time}	_{33.48s (± 0.32%)}	_{33.37s (± 0.32%)}	_~	_33.26s	_33.54s	_{p=0.109 n=6}
_{Emit Time}	_{2.61s (± 2.40%)}	_{2.64s (± 1.82%)}	_~	_2.55s	_2.68s	_{p=0.228 n=6}
_{Total Time}	_{42.94s (± 0.46%)}	_{42.86s (± 0.41%)}	_~	_42.72s	_43.20s	_{p=0.630 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,220,247	_1,220,280	_{+33 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_258,932	_258,941	_{+9 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,410,887k (± 0.02%)}	_{2,411,704k (± 0.03%)}	_{+817k (+ 0.03%)}	_2,410,948k	_2,412,348k	_{p=0.045 n=6}
_{Parse Time}	_{7.68s (± 0.84%)}	_{7.73s (± 1.46%)}	_~	_7.58s	_7.91s	_{p=0.378 n=6}
_{Bind Time}	_{2.50s (± 1.87%)}	_{2.50s (± 0.93%)}	_~	_2.46s	_2.53s	_{p=0.575 n=6}
_{Check Time}	_{49.26s (± 0.48%)}	_{49.38s (± 0.34%)}	_~	_49.07s	_49.57s	_{p=0.336 n=6}
_{Emit Time}	_{3.85s (± 3.34%)}	_{3.81s (± 1.33%)}	_~	_3.74s	_3.86s	_{p=0.810 n=6}
_{Total Time}	_{63.28s (± 0.39%)}	_{63.42s (± 0.43%)}	_~	_62.89s	_63.64s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,476	_256,479	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,239	_104,238	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{425,330k (± 0.00%)}	_{425,345k (± 0.01%)}	_~	_425,313k	_425,384k	_{p=0.471 n=6}
_{Parse Time}	_{3.38s (± 0.16%)}	_{3.35s (± 0.82%)}	_~	_3.32s	_3.39s	_{p=0.250 n=6}
_{Bind Time}	_{1.30s (± 0.90%)}	_{1.31s (± 0.89%)}	_~	_1.29s	_1.32s	_{p=0.185 n=6}
_{Check Time}	_{17.79s (± 0.23%)}	_{17.75s (± 0.58%)}	_~	_17.56s	_17.86s	_{p=0.630 n=6}
_{Emit Time}	_{1.35s (± 0.89%)}	_{1.36s (± 2.18%)}	_~	_1.33s	_1.41s	_{p=1.000 n=6}
_{Total Time}	_{23.82s (± 0.21%)}	_{23.78s (± 0.48%)}	_~	_23.58s	_23.91s	_{p=0.521 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,747k (± 0.02%)}	_{369,852k (± 0.03%)}	_~	_369,702k	_370,016k	_{p=0.093 n=6}
_{Parse Time}	_{2.83s (± 0.86%)}	_{2.82s (± 1.47%)}	_~	_2.77s	_2.88s	_{p=0.686 n=6}
_{Bind Time}	_{1.58s (± 0.66%)}	_{1.60s (± 0.94%)}	_~	_1.57s	_1.61s	_{p=0.142 n=6}
_{Check Time}	_{15.57s (± 0.36%)}	_{15.57s (± 0.42%)}	_~	_15.47s	_15.67s	_{p=0.571 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.98s (± 0.41%)}	_{19.99s (± 0.41%)}	_~	_19.88s	_20.13s	_{p=0.687 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,809,653	_2,809,890	_{+237 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_953,438	_953,461	_{+23 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,981,399k (± 0.00%)}	_{2,981,559k (± 0.00%)}	_~	_2,981,474k	_2,981,687k	_{p=0.054 n=6}
_{Parse Time}	_{13.69s (± 0.41%)}	_{13.72s (± 0.61%)}	_~	_13.60s	_13.83s	_{p=0.575 n=6}
_{Bind Time}	_{4.10s (± 2.02%)}	_{4.14s (± 2.62%)}	_~	_4.06s	_4.28s	_{p=0.570 n=6}
_{Check Time}	_{72.99s (± 2.66%)}	_{72.30s (± 0.56%)}	_~	_71.85s	_73.03s	_{p=0.575 n=6}
_{Emit Time}	_{22.97s (± 7.08%)}	_{23.57s (± 0.88%)}	_~	_23.37s	_23.84s	_{p=0.936 n=6}
_{Total Time}	_{113.75s (± 0.44%)}	_{113.72s (± 0.49%)}	_~	_113.04s	_114.32s	_{p=1.000 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,424	_108,424	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,525k (± 0.02%)}	_{410,556k (± 0.01%)}	_~	_410,483k	_410,640k	_{p=0.575 n=6}
_{Parse Time}	_{4.75s (± 0.74%)}	_{4.73s (± 0.80%)}	_~	_4.68s	_4.79s	_{p=0.198 n=6}
_{Bind Time}	_{2.07s (± 0.61%)}	_{2.05s (± 1.33%)}	_~	_2.01s	_2.08s	_{p=0.285 n=6}
_{Check Time}	_{20.89s (± 0.18%)}	_{20.91s (± 0.51%)}	_~	_20.73s	_21.03s	_{p=0.471 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{27.72s (± 0.16%)}	_{27.69s (± 0.50%)}	_~	_27.49s	_27.85s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,576	_524,841	_{+265 (+ 0.05%)}	_~	_~	_{p=0.001 n=6}
_Types	_178,847	_178,899	_{+52 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{462,531k (± 0.01%)}	_{462,674k (± 0.02%)}	_{+144k (+ 0.03%)}	_462,549k	_462,824k	_{p=0.031 n=6}
_{Parse Time}	_{3.89s (± 0.41%)}	_{3.89s (± 0.25%)}	_~	_3.88s	_3.90s	_{p=1.000 n=6}
_{Bind Time}	_{1.45s (± 1.40%)}	_{1.44s (± 1.16%)}	_~	_1.42s	_1.46s	_{p=0.367 n=6}
_{Check Time}	_{22.46s (± 0.63%)}	_{22.41s (± 0.56%)}	_~	_22.27s	_22.57s	_{p=0.521 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.80s (± 0.49%)}	_{27.74s (± 0.42%)}	_~	_27.62s	_27.89s	_{p=0.423 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented May 9, 2024

Copy link

Copy Markdown

Contributor

Jake Bailey (@jakebailey) Here are the results of running the top 400 repos comparing main and refs/pull/57909/merge:

Everything looks good!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) commented May 9, 2024

Copy link

Copy Markdown

Member

Indeed, just rechecking since this is old and also we have new perf benchmarks / stats.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Nathan Shively-Sanders (sandersn) assigned Jake Bailey (jakebailey)

Jun 14, 2024

Nathan Shively-Sanders (sandersn) requested review from Jake Bailey (jakebailey) and Wesley Wigham (weswigham)

June 14, 2024 17:41

Wesley Wigham (weswigham) approved these changes

Jun 14, 2024

View reviewed changes

Wesley Wigham (weswigham) left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the tests are good, I'm fine with this (nice cheeky PR title that copies the title given to two other PRs that have edited this), but I do want to take a moment to write about this function at a conceptual level. The comment in the code does a poor job of this - it's literally restating what the code below does, rather than really expounding on the why it's doing what it does.

We're trying to pick between the covariant position inference result and the contravariant position inference result. Strictly speaking, when the results differ, you can easily be in a situation where there simply is no correct inference. For example, if we're inferring from (x: number) => string to (x: T) => T. Picking either number or string instead is basically just a choice of which error to produce at the argument site - there is no single T that the input type will be assignable to (except any). However, if you're a bit lucky, one of the two results will work in both positions and produce a type for which the overall argument is assignable. For example, if you have (x: number) => 0, 0 will work for T in both positions. So will number. Ideally, we'd just note all the possible inferences and try them all to see if any choice results in a valid assignment of the argument, then pick that one. Instead we hem and haw a bit because we don't really want to do all that backtracking (it's costly), and try to find a local heuristic to pick one or the other for each type argument. And, moreover, when multiple results are valid, determining a useful "ranking" of them for the "best" match is helpful, since users typically have an intent or expectation for how we bias our choices in situations like these.

As of this PR, that ranking is:

Covariant result if not never or any, assignable to all contravariant candidates, and the variable being inferred isn't referred to by another variable's constraint directly and every covariant inference candidate is assignable to the chosen covariant inference result
Contravariant result, if present
Covariant result

Why is this the ranking? Uh... I dunno. Mostly just empirical testing of "this gives good results". I really wish I could point to more rigor here. Certainly, I cannot point to an algebra from which this algorithm arises. Heck, I'd argue it's kinda wrong and bad - in the (x: number) => 0 example above, it picks 0, but number would be a more reasonable pick. By what metric? Feels. Literals are constraining, and I'd feel you should only pick them as a last resort.

But at least over our current implementation, assignability over subtyping makes sense, since arguments are ultimately compared via assignability and not subtyping (though using the compareTypes on the inference context may be better still, since that would allow the subtype overload pass to use subtypes for its heuristic as those arguments are compared via subtype, while the second pass can use assignment), and excepting Any in the same way as Never from the ranking also tracks (since they're basically the same on the source side of a relationship, as is compared in the first step here).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RyanCavanaugh and ehoogeveen-medweb reacted with thumbs up emoji

All reactions

👍 2 reactions

Jake Bailey (jakebailey) reviewed

Jun 14, 2024

View reviewed changes

Comment thread

src/compiler/checker.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) added 3 commits

June 14, 2024 23:13


          tweak comment

2226e0b


          Merge remote-tracking branch 'origin/main' into tweak-co-contra-infer…

1c3f6c9

…ence


          update baseline

169d720

Jake Bailey (jakebailey) approved these changes

Jun 14, 2024

View reviewed changes

Jake Bailey (jakebailey) commented Jun 14, 2024

Copy link

Copy Markdown

Member

Hm, baselines don't seem to be fully up to date.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          update a baseline

91d69a1

Mateusz Burzyński (Andarist) commented Jun 15, 2024

Copy link

Copy Markdown

Contributor Author

Jake Bailey (@jakebailey) fixed that :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jake Bailey (jakebailey) merged commit a71841c into microsoft:main

Jun 17, 2024

Mateusz Burzyński (Andarist) mentioned this pull request

Aug 16, 2024

5.6 regression: Incorrect param type inference for type with all optional props #59656

Open

Mateusz Burzyński (Andarist) commented Aug 21, 2024

Copy link

Copy Markdown

Contributor Author

though using the compareTypes on the inference context may be better still, since that would allow the subtype overload pass to use subtypes for its heuristic as those arguments are compared via subtype, while the second pass can use assignment

I see why you mention this but I failed to create a reasonable test case showing this is better in practice. I could apply this change blindly as it doesn't make a difference for the existing test suite. I also don't think it would surface anything in the extended test suite since that would essentially move the needle closer to the state before this PR for some cases. So I'm hesitant to make this change as I'd prefer to do it with a test case at hand.

At the same time, I see a risk in introducing this change (and funny enough I failed to create a test case showing this too, even a contrived one) since contextual parameter types (cached!) would be assigned based on the proposed subtyped check from the first overload pass. This could potentially yield worse results for them when the secondary pass (using assignableRelation) could still succeed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Aug 21, 2024

Improve logic that chooses co- vs. contra-variant return type inferences #59709

Closed

The order of values in a union affects the correct type inference #59729

Closed

Trevor Florence (trevorade) mentioned this pull request

Aug 23, 2024

Google feedback on TS 5.6-beta #59733

Open

1 task done

Mateusz Burzyński (Andarist) mentioned this pull request

Aug 26, 2024

5.6 regression: Array.prototype.reduce type inference regression #59763

Closed

Ryan Cavanaugh (RyanCavanaugh) mentioned this pull request

Aug 27, 2024

5.6 regression: Inference with mixed in type intersection no longer compiles #59765

Closed

Mateusz Burzyński (Andarist) deleted the tweak-co-contra-inference branch

August 27, 2024 05:50

Mateusz Burzyński (Andarist) mentioned this pull request

Aug 27, 2024

Tweak logic that chooses co- vs. contra-variant inferences when covariant inference is an empty object type #59772

Closed

Trevor Florence (trevorade) commented Aug 27, 2024

Copy link

Copy Markdown

Contributor

Should this PR be mentioned in the 5.6 Announcements under Notable Behavioral Changes?

I realize the Beta and RC announcements have already gone out.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Dan Vanderkam (danvk) mentioned this pull request

Sep 26, 2024

Inferred type changes from 5.5 to 5.6 #60077

Closed

Nathan Shively-Sanders (sandersn) removed this from PR Backlog

Apr 22, 2025

Microsoft (microsoft) locked as resolved and limited conversation to collaborators

Oct 16, 2025

Reviewers

Wesley Wigham (weswigham)

weswigham approved these changes

Jake Bailey (jakebailey)

jakebailey approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

Jake Bailey (jakebailey)

Labels

For Backlog Bug

PRs that fix a backlog bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.call on an union with different arguments counts fails when passing any Contravariant inference gets picked when a a better covariant candidate exists

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Mateusz Burzyński (Andarist) commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2024

Uh oh!

Jake Bailey (jakebailey) commented Mar 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mateusz Burzyński (Andarist) Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2024

uglify-js

/mnt/ts_downloads/_/m/uglify-js/tsconfig.json

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2024

tsc

Uh oh!

Jake Bailey (jakebailey) commented Mar 22, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mateusz Burzyński (Andarist) commented Mar 23, 2024

Uh oh!

Jake Bailey (jakebailey) commented Mar 23, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 23, 2024

Uh oh!

Mateusz Burzyński (Andarist) commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mateusz Burzyński (Andarist) commented May 9, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented May 9, 2024

tsc

Uh oh!

TypeScript Bot (typescript-bot) commented May 9, 2024

Uh oh!

Jake Bailey (jakebailey) commented May 9, 2024

Uh oh!

Wesley Wigham (weswigham) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jake Bailey (jakebailey) commented Jun 14, 2024

Uh oh!

Mateusz Burzyński (Andarist) commented Jun 15, 2024

Uh oh!

Mateusz Burzyński (Andarist) commented Aug 21, 2024

Uh oh!

Trevor Florence (trevorade) commented Aug 27, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Mateusz Burzyński (Andarist) commented Mar 22, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 22, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 22, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 22, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 23, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

TypeScript Bot (typescript-bot) commented Mar 23, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Mateusz Burzyński (Andarist) commented Mar 23, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Wesley Wigham (weswigham) left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.