GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add test for fixed declaration emit type parameter leak by jakebailey · Pull Request #58208 · microsoft/TypeScript

Conversation

@jakebailey

@jakebailey Jake Bailey (jakebailey) commented Apr 15, 2024

Copy link
Copy Markdown
Member

Closes #44727, which was actually fixed by #57772.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jakebailey
Add test for fixed declaration emit type parameter leak
50bb524
@jakebailey

Jake Bailey (jakebailey) commented Apr 15, 2024

Copy link
Copy Markdown
Member Author

That or it's not fixed, if this type were to be inferred somehow?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakebailey
Jake Bailey (jakebailey) requested a review from Wesley Wigham (weswigham) April 15, 2024 22:58
@weswigham

Wesley Wigham (weswigham) commented Apr 16, 2024

Copy link
Copy Markdown
Member

That or it's not fixed, if this type were to be inferred somehow?

If you add a , prop = [null as any as BrokenType<any>][0] does it repro? Looks like it does on the playground.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakebailey

Jake Bailey (jakebailey) commented Apr 16, 2024

Copy link
Copy Markdown
Member Author

Sure does, so, not fixed. Oh well!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakebailey Jake Bailey (jakebailey) closed this Apr 16, 2024
@jakebailey
Jake Bailey (jakebailey) deleted the fix-44727 branch April 16, 2024 00:11
@weswigham

Wesley Wigham (weswigham) commented Apr 16, 2024

Copy link
Copy Markdown
Member

If you want a fix, the first block in the old related PR (replacing Independent type parameters in the emit with unknown) is probably still the way to go; I don't think the emit's changed all that much.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jakebailey
Jake Bailey (jakebailey) restored the fix-44727 branch April 16, 2024 01:52
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) Awaiting requested review from weswigham

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Declaration emit incorrectly prints uninstantiated generic type

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jakebailey @weswigham
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.