GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — use string as type of variable in ForInStatement by vladima · Pull Request #6302 · microsoft/TypeScript

Conversation

@vladima

@vladima Vladimir Matveev (vladima) commented Dec 31, 2015

Copy link
Copy Markdown
Contributor

per discussion in #4518

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vladima
use string as type of variable in ForInStatement
c1dbd7b
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Dec 31, 2015
DanielRosenwasser
DanielRosenwasser reviewed Dec 31, 2015
View reviewed changes
Comment thread src/compiler/checker.ts Outdated

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Dec 31, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not allowed?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vladima Vladimir Matveev (vladima) Dec 31, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we have not implemented this yet: #3715. I think I'll remove this check so it won't be missed once #3715 is addresssed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vladima
check destructuring in variable declaration of ForInStatement
9a2e42c
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Jan 1, 2016

Copy link
Copy Markdown
Member

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg Anders Hejlsberg (ahejlsberg) mentioned this pull request Jan 7, 2016
For var in object: Var is implicitly any without error #4518
Closed
@mhegazy

Mohamed Hegazy (mhegazy) commented Jan 7, 2016

Copy link
Copy Markdown
Contributor

closing this in favor of #6379
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy Mohamed Hegazy (mhegazy) closed this Jan 7, 2016
@vladima
Vladimir Matveev (vladima) deleted the stringInForIn branch January 7, 2016 23:04
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vladima @RyanCavanaugh @mhegazy @DanielRosenwasser @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.