GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — Report self-references in parameter property initializers by bodapatisaikrishna · Pull Request #65401 · microsoft/TypeScript ConversationFixes #62414 Problem Cause Change Testing This patch was written with AI assistance (Claude Code). I have read it, understand it, and will handle review myself.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions`constructor(private f = f) {}` compiled without an error and threw a
ReferenceError at runtime, while the same code with a plain parameter
reported TS2372.
The binder declares a parameter property twice, as a parameter symbol
in the constructor's locals and as a property symbol in the class
members, and the node's symbol ends up being the property. The
self-reference check compared the resolved parameter symbol with the
declaration's symbol, so the two never matched.
Compare the resolved symbol's value declaration with the parameter
declaration instead.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note Copilot was unable to run its full agentic suite in this review. Copilot review overviewNo open issues 🎉 What changed in this PRAdds a compiler regression test for resolving self-references inside parameter properties, and adjusts the checker logic to correctly detect self-references for parameter properties (where the “parameter” symbol can actually be represented by the synthesized class property symbol). Changes:
Review effort: Lite
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThis branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
At least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
For Backlog Bug
MilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. TypeScript fails to detect self-reference issue in "Parameter Properties" of constructorsUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |