GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix display for literal members by DanielRosenwasser · Pull Request #8125 · microsoft/TypeScript

Conversation

@DanielRosenwasser

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) commented Apr 17, 2016

Copy link
Copy Markdown
Member

Fixes #606 (comment)

A picture of the old behavior for convenience:
image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
weswigham reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Daniel Rosenwasser (DanielRosenwasser) added 4 commits April 16, 2016 12:57
@DanielRosenwasser
Added tests for quick-info on string-named enum members.
5814261
@DanielRosenwasser
Use an element access when displaying literal members.
c05fac7
@DanielRosenwasser
Added another fourslash test.
a07e25a
@DanielRosenwasser
Accepted symbol baselines.
ac1d218
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Apr 17, 2016
weswigham
weswigham reviewed Apr 17, 2016
View reviewed changes
Comment thread src/compiler/checker.ts

function writeTypeofSymbol(type: ObjectType, typeFormatFlags?: TypeFormatFlags) {
function writeTypeOSymbol(type: ObjectType, typeFormatFlags?: TypeFormatFlags) {
writeKeyword(writer, SyntaxKind.TypeOfKeyword);

@weswigham Wesley Wigham (weswigham) Apr 17, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you meant to rename this function like this. 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Apr 17, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't use an apostrophe. 😉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat

Sheetal Nandi (sheetalkamat) commented Apr 18, 2016

Copy link
Copy Markdown
Member

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser
O -> Of
25d7229
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit 0a2a8cc into master Apr 18, 2016
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) deleted the fixDisplayForStringyMembers branch April 18, 2016 17:33
@danquirk Dan Quirk (danquirk) mentioned this pull request Apr 18, 2016
Provide completion lists for string literals #606
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@DanielRosenwasser @sheetalkamat @weswigham @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.