GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update of glob-style pattern matching by riknoll · Pull Request #8841 · microsoft/TypeScript

Conversation

@riknoll

@riknoll Richard Knoll (riknoll) commented May 26, 2016

Copy link
Copy Markdown
Member

This is a resubmission of #5980 that has been brought up to date with master (the old PR had a lot of non-trivial merge conflicts with the current master). The behavior differs somewhat from the specification in #5980 to better reflect the current behavior of the compiler. Excluded patterns now default to the common package directories (node_modules, bower_components, etc.) when "exclude" is not found in tsconfig.json. Additionally, the out directory is always excluded unless explicitly included in "files".

Mohamed Hegazy (@mhegazy) Ron Buckton (@rbuckton) Bill Ticehurst (@billti) please take a look when you have a moment!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
svieira, igrayson, nevir, glen-84, spion, yortus, vbfox, jagt, and plwalters reacted with thumbs up emoji svieira, basarat, igrayson, spion, yortus, jagt, pwnall, plwalters, guncha, andregs, and IAMtheIAM reacted with hooray emoji
All reactions
  • 👍 9 reactions
  • 🎉 11 reactions
Ron Buckton (rbuckton) and others added 19 commits December 3, 2015 10:44
@rbuckton
Initial support for globs in tsconfig.json
f9ae3e4
@rbuckton
Added caching, more tests
30575db
@rbuckton
Merge branch 'master' into glob2
5de2fcc
@rbuckton
Added stubs to ChakraHost interface for readDirectoryNames/readFileNames
def3ba1
@rbuckton
Fixed typos in comments
c3c3bca
@rbuckton
Changed name of 'reduce' method added to FileSet
bf9af46
@rbuckton
Heavily revised implementation that relies on an updated 'readDirecto…
d857250 
…ry' API.
@rbuckton
Merge branch 'master' into glob2
247657f
@rbuckton
more tests
94a5327
@rbuckton
Minor update to shims.ts for forthcoming VS support for globs.
6f85fe9
@rbuckton
Detailed comments for regular expressions and renamed some files.
d23df34
@rbuckton
Comment cleanup
c224917
@rbuckton
Merge branch 'master' into glob2
cde12ef
@rbuckton
Fixed new linter warnings
c1205eb
@riknoll
Merge branch 'master' into glob2
084b94c 
Conflicts:
	Jakefile.js
	src/compiler/commandLineParser.ts
	src/compiler/core.ts
	src/compiler/sys.ts
	src/harness/harness.ts
	src/server/editorServices.ts
	src/services/shims.ts
	tests/cases/unittests/cachingInServerLSHost.ts
@riknoll
Fixing linter and test errors
db85643
@riknoll
Bringing back excludes error and fixing faulty test
c340c88
@riknoll
Merge branch 'master' into glob2_merged
50f0033 
Conflicts:
	src/compiler/sys.ts
	src/harness/harnessLanguageService.ts
	tests/cases/unittests/cachingInServerLSHost.ts
	tests/cases/unittests/tsconfigParsing.ts
@riknoll
Fixing lint errors
aa5c51c
@msftclas

Microsoft Contribution License Agreements (msftclas) commented May 26, 2016

Copy link
Copy Markdown

Hi Richard Knoll (@riknoll), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Richard Knoll). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label May 26, 2016
@dbaeumer Dirk Bäumer (dbaeumer) mentioned this pull request May 31, 2016
Intellisense stuck indexing when file is in an uncommon path microsoft/vscode#7017
Closed
@riknoll
Passing regular expressions to native hosts
0415b95
@mhegazy Mohamed Hegazy (mhegazy) mentioned this pull request Jun 9, 2016
Add upper limit for the program size to prevent tsserver from crashing #7486
Merged
@riknoll Richard Knoll (riknoll) mentioned this pull request Jun 14, 2016
Update tsconfig schema to include glob support SchemaStore/schemastore#186
Merged
@riknoll

Richard Knoll (riknoll) commented Jun 17, 2016

Copy link
Copy Markdown
Member Author

Ron Buckton (@rbuckton) could you take a look when you have a moment?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rbuckton
rbuckton reviewed Jun 17, 2016
View reviewed changes
Comment thread src/compiler/commandLineParser.ts Outdated
continue;
}

if (IgnoreFileNamePattern.test(file)) {

@rbuckton Ron Buckton (rbuckton) Jun 17, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: capitalization - ignoreFileNamePattern

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@riknoll

Richard Knoll (riknoll) commented Jun 20, 2016

Copy link
Copy Markdown
Member Author

Ron Buckton (@rbuckton) thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@riknoll
Merge branch 'master' into glob2_merged
b49acd5
@riknoll
Richard Knoll (riknoll) merged commit 6d99b2f into master Jun 20, 2016
@basarat

Basarat Ali Syed (basarat) commented Jun 20, 2016

Copy link
Copy Markdown
Contributor

wow 🎉 🌹
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy
Mohamed Hegazy (mhegazy) deleted the glob2_merged branch June 20, 2016 23:25
@mhegazy

Mohamed Hegazy (mhegazy) commented Jun 20, 2016

Copy link
Copy Markdown
Contributor

//CC: Basarat Ali Syed (@basarat), Johannes Rieken (@jrieken), Blake Embrey (@blakeembrey) James Brantly (@jbrantly), Adi Dahiya (@adidahiya), Alex Eagle (@alexeagle), martine

this change has a breaking change to the public API, changing the arguments to ParseConfigHost.readDirectory and System.readDirectory, from

readDirectory(rootDir: string, extension: string, exclude: string[]): string[];

to:

readDirectory(rootDir: string, extensions: string[], excludes: string[], includes: string[]): string[];

Please do let us know if this is something that manageable on your side or more changes needs to be done on the TS side.
basarat, blakeembrey, adidahiya, and alexeagle reacted with heart emoji
All reactions
  • ❤️ 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy Mohamed Hegazy (mhegazy) added the Breaking Change Would introduce errors in existing code label Jun 20, 2016
@mhegazy Mohamed Hegazy (mhegazy) modified the milestones: Community, TypeScript 2.0 Jun 20, 2016
@mhegazy Mohamed Hegazy (mhegazy) added the Domain: API Relates to the public API for TypeScript label Jun 20, 2016
@mhegazy Mohamed Hegazy (mhegazy) mentioned this pull request Jun 22, 2016
support globs in tsconfig.json files property (or just file/directory exclusions) #1927
Closed
@johnnyreilly

John Reilly (johnnyreilly) commented Jun 22, 2016

Copy link
Copy Markdown

Awesome!😃
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evmar

Evan Martin (evmar) commented Jun 22, 2016

Copy link
Copy Markdown
Contributor

Mohamed Hegazy (@mhegazy) thanks for thinking of me! I didn't see any use/impl of readDirectory in Google code.

In Angular2 I found one use Alex Eagle (@alexeagle) , but it's likely easy to update:
https://github.com/angular/angular/blob/3d5bb2318454ba428b816f6aee6e6aaf427d70a7/tools/%40angular/tsc-wrapped/src/tsc.ts#L51

In general I think we (Google) don't mind too much when you change APIs, especially when it's a small change that the compiler can easily spot when we update. And usually the only reason to change an API in a large way is because it's important so we'll likely be able to make that work as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy

Mohamed Hegazy (mhegazy) commented Jun 22, 2016

Copy link
Copy Markdown
Contributor

thanks martine for getting to us back on this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Alex Eagle (alexeagle) added a commit to alexeagle/angular that referenced this pull request Jun 23, 2016
@alexeagle
fix(ngc): work with typescript@next
5eddbd3 
This is required due to breaking change in TS, see
microsoft/TypeScript#8841 (comment)
Alex Eagle (alexeagle) added a commit to angular/angular that referenced this pull request Jun 24, 2016
@alexeagle
fix(ngc): work with typescript@next
f463e09 
This is required due to breaking change in TS, see
microsoft/TypeScript#8841 (comment)
@ananthakumaran Anantha Kumaran (ananthakumaran) mentioned this pull request Jun 25, 2016
tide does not pick up .d.ts file in tsconfig.json ananthakumaran/tide#37
Closed
@glen-84 Glen (glen-84) mentioned this pull request Jun 25, 2016
Add an equivalent to gulp.watch on tsproject ivogabe/gulp-typescript#191
Open
@glen-84 Glen (glen-84) mentioned this pull request Jul 3, 2016
Add support for the glob-style pattern matching in TypeScript 2.0 ivogabe/gulp-typescript#375
Closed
@pwnall Victor Costan (pwnall) mentioned this pull request Jul 5, 2016
Since TypeScript now supports filesGlob natively we definitely shouldn't expand it by default TypeStrong/atom-typescript#992
Closed
@texastoland

Texas Toland (texastoland) commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

I'm having trouble excluding arbitrarily deep node_modules. Should **/node_modules or **/node_modules/**/* do the trick?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@basarat

Basarat Ali Syed (basarat) commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

I'm having trouble excluding arbitrarily deep node_modules.

they might still get pulled in because of import statements 🌹
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@riknoll

Richard Knoll (riknoll) commented Jul 7, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

**/node_modules should work, but Basarat Ali Syed (@basarat)'s comment about imports is also correct
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@glen-84 Glen (glen-84) mentioned this pull request Jul 9, 2016
Support for tsconfig.json palantir/eclipse-typescript#268
Closed
@jasongrout Jason Grout (jasongrout) mentioned this pull request Jul 21, 2016
Use markdown-it for rendering markdown jupyterlab/jupyterlab#499
Closed
@sandersn Nathan Shively-Sanders (sandersn) mentioned this pull request Apr 27, 2017
Exclude node_modules in module resolution vuejs/vetur#161
Merged
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Breaking Change Would introduce errors in existing code Domain: API Relates to the public API for TypeScript

Projects

None yet

Milestone

TypeScript 2.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@riknoll @msftclas @rbuckton @basarat @mhegazy @johnnyreilly @evmar @texastoland @mihailik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.