GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Merge JSDoc of assignments from function expressions by sandersn · Pull Request #9010 · microsoft/TypeScript

Conversation

@sandersn

@sandersn Nathan Shively-Sanders (sandersn) commented Jun 7, 2016

Copy link
Copy Markdown
Member

Fixes #7586

Ryan Cavanaugh (@RyanCavanaugh) I'm not sure this is the correct direction for this fix. Can you take a look?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sandersn
Merge JSDoc of assignments from function expressions
17cc206
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jun 7, 2016
DanielRosenwasser
DanielRosenwasser reviewed Jun 7, 2016
View reviewed changes
Comment thread tests/cases/fourslash/commentsFunction.ts Outdated
//// return s.length;
////}
////assig/*34*/ned/*35*/(/*36*/"hey");

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Jun 7, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this into a separate file? These tests are specific enough and it would lend well to pinpointing future issues if they start failing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sandersn Nathan Shively-Sanders (sandersn) Jun 8, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I can break it up even more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sandersn Nathan Shively-Sanders (sandersn) Jun 8, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. I split it in half -- one for testing function declarations and one for function expressions. There's still a lot of redundancy in there, but testing => vs function might someday expose a bug. I guess.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sandersn
Improve order of parameter's merged jsdoc
6bf5f11
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Jun 8, 2016

Copy link
Copy Markdown
Member

Looks good
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn
Split commentsFunction test into expr/decl
9832f62 
And renumber.
@sandersn Nathan Shively-Sanders (sandersn) mentioned this pull request Jun 8, 2016
No intellisense when exporting es3 style class #8144
Closed
@sandersn
Remove TODO comments
1fe6626
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 179d423 into master Jun 8, 2016
@sandersn
Nathan Shively-Sanders (sandersn) deleted the merge-jsdoc-of-assignment-and-function-expression branch June 8, 2016 20:03
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IntelliSense / JSDoc - function declaration not same as function expression

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sandersn @RyanCavanaugh @DanielRosenwasser @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.