GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Load js from modules 2.0 by billti · Pull Request #9384 · microsoft/TypeScript

Conversation

Bill Ticehurst (billti) commented Jun 28, 2016

Copy link

Copy Markdown

Member

Port of pull request for #7075 to load JavaScript files from node_modules if allowJs is set.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Bill Ticehurst (billti) added 21 commits

February 13, 2016 07:48


          Load JS from node_modules

dfb0dcd


          Added tests

6126f7b


          Updated tests

e2df645


          Merge remote-tracking branch 'upstream/master' into loadJsFromModules

c76dc72


          Fixed diagnostic message wording

ac54194


          Merge remote-tracking branch 'upstream/master' into loadJsFromModules

75d84dc


          Updated test

dd31bf9


          Fixed whitespace

073f16e


          Merge branch 'master' into loadJsFromModules

4d4f679


          Changed implementation to use closure

07bfbab


          Updated tests

d01d5b1


          Fixed linting error

8ff2c1a


          Remove extra baselines

6fba804


          Fixed bugs and linting

e9a0c56


          Added project tests for node_modules JavaScript searches

885b0e9


          Merge branch 'master' into loadJsFromModules

0174bda


          Removed old TODO comment

1b43bd8


          Fixed the regexp for removing full paths

de559fb


          Added emitHost method to return source from node modules

d8e3bd9


          Marked new method internal

ddad35a


          Merge branch 'loadJsFromModules' into loadJsFromModules-2.0

3ccb8b2

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label

Jun 28, 2016

Mohamed Hegazy (mhegazy) commented Jun 28, 2016

Copy link

Copy Markdown

Contributor

👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Bill Ticehurst (billti) merged commit 2182051 into release-2.0

Jun 28, 2016

Bill Ticehurst (billti) deleted the loadJsFromModules-2.0 branch

June 28, 2016 02:56

Wesley Wigham (weswigham) mentioned this pull request

Jun 29, 2016

Typescript LS is preferring .js to @types .d.ts when loading types #9427

Closed

Microsoft (microsoft) locked and limited conversation to collaborators

Jun 19, 2018

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.