GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix crash in async functions when targetting ES5. by sandersn · Pull Request #9397 · microsoft/TypeScript

Conversation

@sandersn

@sandersn Nathan Shively-Sanders (sandersn) commented Jun 28, 2016

Copy link
Copy Markdown
Member

Fixes #9320

When targetting ES5 and with --noImplicitReturns, an async function whose return type could not be determined would cause a compiler crash.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sandersn
Fix crash in async functions when targetting ES5.
8ff873e 
When targetting ES5 and with --noImplicitReturns,
an async function whose return type could not be determined would cause
a compiler crash.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jun 28, 2016
@sandersn

Nathan Shively-Sanders (sandersn) commented Jun 29, 2016

Copy link
Copy Markdown
Member Author

Anders Hejlsberg (@ahejlsberg) do you want to take a look? This fix is pretty ad-hoc. But it's also only occurring when stacking a couple of wrong things on top of each other (It targets ES5 and references 'window' which doesn't exist)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jun 30, 2016

Copy link
Copy Markdown
Member

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 7b77f6b into master Jun 30, 2016
@sandersn
Nathan Shively-Sanders (sandersn) deleted the fix-crash-in-async-and-no-implicit-returns-targeting-es5 branch June 30, 2016 01:40
@texastoland

Texas Toland (texastoland) commented Jun 30, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

But it's also only occurring when stacking a couple of wrong things on top of each other (It targets ES5 and references window which doesn't exist)

I was just trying to provide the most streamlined case possible. I'll test in the next nightly!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn

Nathan Shively-Sanders (sandersn) commented Jun 30, 2016

Copy link
Copy Markdown
Member Author

Not a problem. I'm not sure why it didn't crash when targeting ES6 or when I substituted this for window. (Well, in the latter case, I think it was able to get a proper Promise<void> type.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@texastoland

Texas Toland (texastoland) commented Jun 30, 2016

Copy link
Copy Markdown
Contributor

In any case thanks for the patch 👏
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sandersn @ahejlsberg @texastoland @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.