GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Port #9421 to not compile files under from node_modules by billti · Pull Request #9459 · microsoft/TypeScript

Conversation

@billti

@billti Bill Ticehurst (billti) commented Jul 1, 2016

Copy link
Copy Markdown
Member

This is a port of #9421 which stops the compiling or source code loaded from a node_modules search (#6964) and also includes the fix for the bug of preferring JavaScript files from node_modules over @types packages when allowJs is set (#9427).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Bill Ticehurst (billti) added 4 commits June 30, 2016 17:11
@billti
Don't emit source files found under node_modules
bfd2801 
(cherry picked from commit 5f8cf1a)
@billti
Dont load JavaScript if types packages are present
d93e0a6 
(cherry picked from commit 5a45c44)
@billti
Renamed API
5a4cd83 
(cherry picked from commit d8047b6)
@billti
Removed one error to avoid full path issues
2dc84a8 
(cherry picked from commit 5e4f13f)
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jul 1, 2016
@mhegazy

Mohamed Hegazy (mhegazy) commented Jul 1, 2016

Copy link
Copy Markdown
Contributor

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@billti
Bill Ticehurst (billti) merged commit f7c9a77 into release-2.0 Jul 1, 2016
@billti
Bill Ticehurst (billti) deleted the dontEmitNodeModules-2.0 branch July 1, 2016 02:48
@markvandenbrink Mark van den Brink (markvandenbrink) mentioned this pull request Jul 6, 2016
TypeScript 2.0: index.js not generated for source files in node_modules (since 2.0.0-dev.20160701) #9542
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@billti @mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.