GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Create separate constructors for Tokens and Identifiers by sheetalkamat · Pull Request #9529 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Jul 5, 2016

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sheetal Nandi (sheetalkamat) added 2 commits July 5, 2016 11:37
@sheetalkamat
Create tokens using different constructor
4a77c97
@sheetalkamat
Identifier constructor
a2ff4ea
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jul 5, 2016
@sheetalkamat
Set default flags on all nodes
08a0137
DanielRosenwasser
DanielRosenwasser reviewed Jul 6, 2016
View reviewed changes
Comment thread src/compiler/types.ts Outdated
flags: NodeFlags;
}

export interface Token extends Node { }

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Jul 6, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider a __tokenTag

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sheetal Nandi (sheetalkamat) added 2 commits July 11, 2016 11:03
@sheetalkamat
Make sure the order of setting pos, end, flags, parent, kind is consi…
0764590 
…stent among nodes, tokens and identifiers
@sheetalkamat
Add __tokentag to Token
767da71
mhegazy
mhegazy reviewed Jul 11, 2016
View reviewed changes
Comment thread src/services/services.ts Outdated
public jsDocComments: JSDocComment[];
public __tokenTag: any;

constructor(public pos: number, public end: number) {

@mhegazy Mohamed Hegazy (mhegazy) Jul 11, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you list all assignments to properties in the same order as in the NodeObject ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sheetalkamat Sheetal Nandi (sheetalkamat) Jul 11, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are in same order as node object

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhegazy Mohamed Hegazy (mhegazy) Jul 11, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i understand. it just took me a bit to verify that by looking at the ones done in the constructor explicitly and the ones done because they are parameter properties.

my comment is to not use parameter properties just to make it clear what the order is.

also worth adding a comment that these need to stay in sync on all three classes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sheetalkamat Sheetal Nandi (sheetalkamat) Jul 11, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will do.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Jul 11, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that's my fault. :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat
Make setting properties explicit instead of using parameter properties
78a1ca7
@mhegazy

Mohamed Hegazy (mhegazy) commented Jul 14, 2016

Copy link
Copy Markdown
Contributor

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit f16f276 into master Jul 14, 2016
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the identifierAndTokenConstructor branch July 14, 2016 20:35
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sheetalkamat @mhegazy @DanielRosenwasser @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.