GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix #9550: exclude 'this' type parameters from unusedParameters checks. by tetsuharuohzeki · Pull Request #9557 · microsoft/TypeScript

Conversation

@tetsuharuohzeki

@tetsuharuohzeki Tetsuharu Ohzeki (tetsuharuohzeki) commented Jul 7, 2016

Copy link
Copy Markdown

Fix #9550

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Tetsuharu OHZEKI
Fix microsoft#9550: exclude 'this' type parameters from unusedParamet…
1ee3f99 
…ers checks.
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Jul 7, 2016

Copy link
Copy Markdown

Hi saneyuki, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-required label Jul 7, 2016
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Jul 7, 2016

Copy link
Copy Markdown

saneyuki, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msftclas Microsoft Contribution License Agreements (msftclas) added cla-signed and removed cla-required labels Jul 7, 2016
@tetsuharuohzeki Tetsuharu Ohzeki (tetsuharuohzeki) mentioned this pull request Jul 7, 2016
'noUnusedParameters' compiler options warn the specified 'this' type as 'never used' parameter #9550
Closed
@mhegazy

Mohamed Hegazy (mhegazy) commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

nice. thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy

Mohamed Hegazy (mhegazy) commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy
Mohamed Hegazy (mhegazy) merged commit 99748a2 into microsoft:master Jul 7, 2016
@tetsuharuohzeki
Tetsuharu Ohzeki (tetsuharuohzeki) deleted the fix-unusedparam-this branch July 7, 2016 19:28
@DickvdBrink Dick van den Brink (DickvdBrink) mentioned this pull request Jul 8, 2016
noImplicitThis + noUnusedLocals = impossible to use together #9567
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tetsuharuohzeki @msftclas @mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.