GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Classes.md: Update description for getter and setter member visibility by foxcaulfield · Pull Request #3097 · microsoft/TypeScript-Website

Conversation

@foxcaulfield

@foxcaulfield Maxim R (foxcaulfield) commented May 11, 2024

Copy link
Copy Markdown
Contributor

Got some updates for the TypeScript documentation, specifically regarding member visibility for getters and setters:

  • Tightened up the documentation to clarify that set accessors might have lower visibility compared to their get counterparts.

Related merged pull request (Differing Visibility)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@foxcaulfield
Classes.md: Update description for getter and setter member visibility
4afb184
jakebailey
Jake Bailey (jakebailey) reviewed Jun 2, 2024
View reviewed changes
Comment thread packages/documentation/copy/en/handbook-v2/Classes.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@foxcaulfield
Get rid of the line
16d9e9c
jakebailey
Jake Bailey (jakebailey) approved these changes Jun 5, 2024
View reviewed changes
@jakebailey
Jake Bailey (jakebailey) enabled auto-merge (squash) June 5, 2024 20:00
@jakebailey
Jake Bailey (jakebailey) merged commit f5d04b2 into microsoft:v2 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakebailey Jake Bailey (jakebailey) jakebailey approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@foxcaulfield @jakebailey
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.