GeezerVison is showing github.com — Move FluentThemeable implementation to FluentUI_common by mischreiber · Pull Request #2174 · microsoft/fluentui-apple
Conversation
Platforms Impacted
Description of changes
This moves the duplicate implementations of FluentThemeable for NSView and UIView into a shared file in FluentUI_common.
No more duplcation, and also preemptively solves a problem with Swift 6 that would require @retroactive.
Verification
No functionality changes. Code builds and demos run as expected on all platforms.
Pull request checklist
This PR has considered:
- Light and Dark appearances
- iOS supported versions (all major versions greater than or equal current target deployment version)
- VoiceOver and Keyboard Accessibility
- Internationalization and Right to Left layouts
- Different resolutions (1x, 2x, 3x)
- Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
- iPad Pointer interaction
- SwiftUI consumption (validation or new demo scenarios needed)
- Objective-C exposure (provide it only if needed)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.