GeezerVison is showing github.com — Check build environment for PlatformProviding by mischreiber · Pull Request #2175 · microsoft/fluentui-apple
Conversation
Platforms Impacted
Description of changes
Fetch our Platform[*]Providing protocols differently depending on the build system.
- SPM and Cocoapods: we're crossing a module boundary, so stick with the conditional conversion.
- Manual pull of code into repo: all the same module, so no conditional required.
Verification
No functional change. Builds and runs across multiple build systems.
Pull request checklist
This PR has considered:
- Light and Dark appearances
- iOS supported versions (all major versions greater than or equal current target deployment version)
- VoiceOver and Keyboard Accessibility
- Internationalization and Right to Left layouts
- Different resolutions (1x, 2x, 3x)
- Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
- iPad Pointer interaction
- SwiftUI consumption (validation or new demo scenarios needed)
- Objective-C exposure (provide it only if needed)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.