GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updating bottom sheet corner radius by JaquelineGomez · Pull Request #2194 · microsoft/fluentui-apple

Conversation

@JaquelineGomez

@JaquelineGomez Jaqueline Gomez (JaquelineGomez) commented Jul 30, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

  • Added a new corner radius token
  • Changed the corner radius of the BottomSheets to the new corner radius only if they are using the new iOS version that will be released soon
  • This new corner radius makes the BottomSheets more consistent with Apple styling

Verification

Ran it on two iPhone simulators:

  1. Running on iOS 18
  2. Running on iOS 26

Ran it on two iPad simulators:

  1. Running on iOS 18
  2. Running on iOS 26

The change was only seen on the iPhone and iPad running on iOS26.

Visual Verification
Before After
image image
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • SwiftUI consumption (validation or new demo scenarios needed)
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jaqueline Gomez added 2 commits July 30, 2025 10:04
Jaqueline Gomez
Added a new corner radius to match bottom sheets radius to new iOS
ddbb46d
Jaqueline Gomez
add spacing
e70567d
@JaquelineGomez
Jaqueline Gomez (JaquelineGomez) requested a review from a team as a code owner July 30, 2025 18:53
@JaquelineGomez

Jaqueline Gomez (JaquelineGomez) commented Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anandrajeswaran
Anand Rajeswaran (anandrajeswaran) reviewed Jul 30, 2025
View reviewed changes
Comment thread Sources/FluentUI_common/Core/Theme/Tokens/GlobalTokens.swift Resolved

Uh oh!

There was an error while loading. Please reload this page.
Jaqueline Gomez added 2 commits July 30, 2025 14:15
Jaqueline Gomez
removed cornerRadius from global tokens
e36c423
Jaqueline Gomez
Added cornerRadius to Constants section
c79fc2e
joannaquu
Joanna Qu (joannaquu) approved these changes Jul 30, 2025
View reviewed changes
Comment thread Sources/FluentUI_iOS/Components/BottomSheet/BottomSheetTokenSet.swift Resolved

Uh oh!

There was an error while loading. Please reload this page.
Jaqueline Gomez
removed 400 from var name
95883aa
joannaquu
Joanna Qu (joannaquu) approved these changes Jul 30, 2025
View reviewed changes
nodes11
Des Marks (nodes11) approved these changes Jul 31, 2025
View reviewed changes
@joannaquu
Joanna Qu (joannaquu) merged commit 7b7a8a8 into microsoft:main Jul 31, 2025
@joannaquu Joanna Qu (joannaquu) mentioned this pull request Oct 23, 2025
Bump version to 0.35 #2225
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischreiber Mike Schreiber (mischreiber) mischreiber left review comments
@anandrajeswaran Anand Rajeswaran (anandrajeswaran) anandrajeswaran left review comments
@nodes11 Des Marks (nodes11) nodes11 approved these changes
@joannaquu Joanna Qu (joannaquu) joannaquu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JaquelineGomez @mischreiber @nodes11 @anandrajeswaran @joannaquu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.