GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Centering Navigation Title by JaquelineGomez · Pull Request #2200 · microsoft/fluentui-apple

Conversation

@JaquelineGomez

@JaquelineGomez Jaqueline Gomez (JaquelineGomez) commented Aug 21, 2025 •
edited by microsoft-github-policy-service Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

In iOS 26, the containingStackView (which manages the title and subtitle) was expanding to fill the entire available space to the right of the back button, causing the text to be centered within this oversized container rather than within the navigation bar itself. This resulted in visually off-center navigation titles. This fix calculates the minimum space required by the containingStackView to properly display all its content, allowing the navigation controller to center the appropriately-sized container within the navigation bar for proper title alignment.

Verification

iPhone 16 Pro with iOS 26 and iOS 18 (no affect on iOS 18)
iPad iOS 16

Visual Verification
Before After
image image
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Jaqueline Gomez added 12 commits August 13, 2025 11:44
Jaqueline Gomez
add new image to dataset
3457818
Jaqueline Gomez
change back button image and center it
146da3f
Jaqueline Gomez
change image to look more similar to current image
426cfa9
Jaqueline Gomez
updated name
24c3675
Jaqueline Gomez
removed unnecessary line
e7b6f3c
Jaqueline Gomez
support RTL
c162970
Jaqueline Gomez
use system image for iOS 26 and above
e4293de
Jaqueline Gomez
removed fluent ui image
e667d93
Jaqueline Gomez
add iOS26+ scope
2f88260
Jaqueline Gomez
re-add comment
e1a4d33
Jaqueline Gomez
Navigation title centered
b368bf7
Jaqueline Gomez
Merge remote-tracking branch 'upstream' into user/jagomez/fixNavTitle
08c9a00
@JaquelineGomez
Jaqueline Gomez (JaquelineGomez) requested a review from a team as a code owner August 21, 2025 21:01
@JaquelineGomez Jaqueline Gomez (JaquelineGomez) assigned Jaqueline Gomez (JaquelineGomez) and Joanna Qu (joannaquu) and unassigned Jaqueline Gomez (JaquelineGomez) Aug 21, 2025
@joannaquu

Joanna Qu (joannaquu) commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

just double checking, after initial setup, do we ever do a layout change that would require a call to invalidateIntrinsicContentSize

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joannaquu

Joanna Qu (joannaquu) commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

nit: can we rename pr title

JaquelineGomez reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joannaquu
Joanna Qu (joannaquu) approved these changes Aug 21, 2025
View reviewed changes
@JaquelineGomez Jaqueline Gomez (JaquelineGomez) changed the title User/jagomez/center nav title Centering Navigation Title Aug 21, 2025
@JaquelineGomez

Jaqueline Gomez (JaquelineGomez) commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

just double checking, after initial setup, do we ever do a layout change that would require a call to invalidateIntrinsicContentSize

The navigation title is not being changed meaning the size does not change, so no.

Also tested with rotating the device and it still has the title centered correctly.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JaquelineGomez
Jaqueline Gomez (JaquelineGomez) merged commit d1a8e97 into microsoft:main Aug 21, 2025
@joannaquu Joanna Qu (joannaquu) mentioned this pull request Oct 23, 2025
Bump version to 0.35 #2225
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joannaquu Joanna Qu (joannaquu) joannaquu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@joannaquu Joanna Qu (joannaquu)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JaquelineGomez @joannaquu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.