GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [BottomSheetController] Explicitly set isAccessibilityElement of resizingHandleView by nodes11 · Pull Request #2227 · microsoft/fluentui-apple

Conversation

@nodes11

@nodes11 Des Marks (nodes11) commented Oct 27, 2025 •
edited by microsoft-github-policy-service Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

When the isExpandable state of the BottomSheetController changes to false, the resizingHandleView hides but its frame remains an accessible element in VoiceOver mode.

This change sets the isAccessibilityElement property when isExpandable changes.

Binary change

N/A

Verification

Validated in Fluent Demo Controller that the issue no longer reproduces.

Visual Verification
Before After

|

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-10-27.at.10.04.50.mov

|

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2025-10-27.at.10.03.35.mov

|

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodes11
Explicity set isAccessiblityElement of resizingHandleView when isExpa…
bbe65fe 
…ndable changes
@nodes11
Des Marks (nodes11) requested a review from a team as a code owner October 27, 2025 17:10
joannaquu
Joanna Qu (joannaquu) approved these changes Oct 27, 2025
View reviewed changes
@nodes11
Merge branch 'main' into fix_bottom_sheet_handle_a11y
4334a2f
@nodes11
Des Marks (nodes11) enabled auto-merge (squash) October 27, 2025 19:02
@nodes11
Des Marks (nodes11) merged commit cc00c74 into microsoft:main Oct 27, 2025
@joannaquu Joanna Qu (joannaquu) mentioned this pull request Jul 9, 2026
Bump version to 0.36 #2276
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joannaquu Joanna Qu (joannaquu) joannaquu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nodes11 @joannaquu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.