GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [Bottom Sheet] Merge duplicate detents + other fixes by lukas-cap · Pull Request #2255 · microsoft/fluentui-apple

Conversation

@lukas-cap

@lukas-cap Lukas Capkovic (lukas-cap) commented Mar 19, 2026 •
edited by microsoft-github-policy-service Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

We saw a bug where the partial detent height wasn't accounting for bottom safe area.

While fixing that, I noticed we have a lot of bugs around detent availability in restricted height scenarios. Dynamic height resolvers can produce a partial height effectively equal to collapsed or expanded. This caused invisible state cycling on handle taps, incorrect pan snapping, and meaningless delegate notifications.

Add supportsCollapsedState and supportsPartialState computed properties that gate detent availability. Partial is skipped when its height is within a merge threshold of collapsed or expanded. Collapsed is skipped when the sheet is height-restricted. Layout changes that invalidate the current detent reposition the sheet to expanded with delegate notification.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Lukas Capkovic and others added 3 commits March 18, 2026 22:13
Lukas Capkovic @claude
[Bottom Sheet] Merge duplicate detents when partial ≈ collapsed or ex…
771ab02
…panded

Dynamic height resolvers can produce a partial height effectively equal
to collapsed or expanded. This caused invisible state cycling on handle
taps, incorrect pan snapping, and meaningless delegate notifications.

Add supportsCollapsedState and supportsPartialState computed properties
that gate detent availability. Partial is skipped when its height is
within a merge threshold of collapsed or expanded. Collapsed is skipped
when the sheet is height-restricted. Layout changes that invalidate the
current detent reposition the sheet to expanded with delegate notification.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Lukas Capkovic
updates
7270e75
Lukas Capkovic @claude
[Bottom Sheet] Fire willMoveTo before forced detent change in layout
692e54d
When a detent becomes invalid during layout (e.g. partial merges with
collapsed), the controller now properly fires willMoveTo before didMoveTo,
preserving the standard will/did delegate contract. Also avoids redundant
side effects by inlining only the necessary state update instead of calling
handleCompletedStateChange.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@lukas-cap
Lukas Capkovic (lukas-cap) marked this pull request as ready for review March 19, 2026 20:47
@lukas-cap
Lukas Capkovic (lukas-cap) requested a review from a team as a code owner March 19, 2026 20:48
joannaquu
Joanna Qu (joannaquu) approved these changes Mar 19, 2026
View reviewed changes
@lukas-cap
Lukas Capkovic (lukas-cap) merged commit e5f7987 into microsoft:main Mar 19, 2026
7 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@joannaquu Joanna Qu (joannaquu) mentioned this pull request Jul 9, 2026
Bump version to 0.36 #2276
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joannaquu Joanna Qu (joannaquu) joannaquu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lukas-cap @joannaquu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.