GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Separators between Command Bar Groups by cbowdoin · Pull Request #2258 · microsoft/fluentui-apple

Conversation

@cbowdoin

@cbowdoin cbowdoin commented Mar 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

Currently there is no meaning for what a group means in a command bar. Lets fix this by separating each group to have a separator that is displayed between each group. We will only add the separator if we have more than 1 group otherwise we will show no separator.

Verification

Tested the presentation of the separators between groups in the demo app

Visual Verification
Before After
image image

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cbowdoin
Add separators between Command bar groups
0765263
joannaquu
Joanna Qu (joannaquu) reviewed Mar 30, 2026
View reviewed changes
Comment thread Sources/FluentUI_iOS/Components/CommandBar/CommandBarCommandGroupsView.swift Resolved

Uh oh!

There was an error while loading. Please reload this page.
@joannaquu

Joanna Qu (joannaquu) commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

add a showsSeparator property on command bar defaulting to false to preserve existing behavior.

@objc public var showsSeparators: Bool = false {
        didSet {
            leadingCommandGroupsView.showsSeparators = showsSeparators
            mainCommandGroupsView.showsSeparators = showsSeparators
            trailingCommandGroupsView.showsSeparators = showsSeparators
        }
    }

pass it through to the command groups

var showsSeparators: Bool = false {
        didSet {
            if showsSeparators != oldValue {
                updateButtonsShown()
            }
        }
    }
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cbowdoin cbowdoin changed the title [Draft] Add separators between Command bar groups [Draft] Add Separators between Command Bar Groups Mar 30, 2026
@cbowdoin
Clean up
e7f80a8
@cbowdoin

cbowdoin commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

add a showsSeparator property on command bar defaulting to false to preserve existing behavior.

@objc public var showsSeparators: Bool = false {
        didSet {
            leadingCommandGroupsView.showsSeparators = showsSeparators
            mainCommandGroupsView.showsSeparators = showsSeparators
            trailingCommandGroupsView.showsSeparators = showsSeparators
        }
    }

pass it through to the command groups

var showsSeparators: Bool = false {
        didSet {
            if showsSeparators != oldValue {
                updateButtonsShown()
            }
        }
    }

Spoke offline. Decided to show separator by default to give meaning to groupings.
joannaquu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cbowdoin cbowdoin changed the title [Draft] Add Separators between Command Bar Groups Add Separators between Command Bar Groups Mar 30, 2026
@cbowdoin
Merge branch 'main' into user/cbowdoin/SeparatorsInCCB
08191f9
@cbowdoin
cbowdoin marked this pull request as ready for review March 30, 2026 22:38
@cbowdoin
cbowdoin requested a review from a team as a code owner March 30, 2026 22:38
joannaquu
Joanna Qu (joannaquu) approved these changes Mar 30, 2026
View reviewed changes
@joannaquu Joanna Qu (joannaquu) mentioned this pull request Mar 30, 2026
Add the Ability to Specify a Separator in CommandBar #2253
Closed
3 of 12 tasks
@cbowdoin
cbowdoin enabled auto-merge (squash) March 30, 2026 23:28
@cbowdoin
cbowdoin merged commit 02f669e into microsoft:main Mar 31, 2026
12 of 13 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@joannaquu Joanna Qu (joannaquu) mentioned this pull request Jul 9, 2026
Bump version to 0.36 #2276
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joannaquu Joanna Qu (joannaquu) joannaquu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cbowdoin @joannaquu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.