GeezerVison is showing github.com — Rename IndeterminateProgressBar to ProgressBar, add determinite progress mode by nodes11 · Pull Request #2279 · microsoft/fluentui-apple
Conversation
Des Marks (nodes11)
commented
Jul 29, 2026
•
edited by microsoft-github-policy-service
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Platforms Impacted
Description of changes
The exisiting IndeterminateProgressBar only supports showing indeterminate progress and its name reflects that. We need a progress bar that can show both indeterminate and determinate progress.
This change renames to the IndeterminateProgressBar to ProgressBar (MSFProgressBar for Obj-C consumers) and adds a determinate progress mode.
Changes:
- A bulk rename of
IndeterminateProgressBar to ProgressBar. I used Copilot to aid in this process.
- Added an optional
progress property to the MSFProgressBarState (previously MSFIndeterminateProgressBarState), which when non-nil, enables the determinite mode for the progress bar.
- Added toggle to the demo controller so that both the indeterminate and determinate modes can be tested.
Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
(how the change was tested, including both manual and automated tests)
Visual Verification
Simulator.Screen.Recording.-.iPad.Pro.13-inch.M5.-.2026-07-29.at.08.24.23.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-07-29.at.08.18.57.mov
Pull request checklist
This PR has considered:
- Light and Dark appearances
- iOS supported versions (all major versions greater than or equal current target deployment version)
- VoiceOver and Keyboard Accessibility
- Internationalization and Right to Left layouts
- Different resolutions (1x, 2x, 3x)
- Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
- iPad Pointer interaction
- SwiftUI consumption (validation or new demo scenarios needed)
- Objective-C exposure (provide it only if needed)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
API break
This PR introduces a breaking API change
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.