GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Rename IndeterminateProgressBar to ProgressBar, add determinite progress mode by nodes11 · Pull Request #2279 · microsoft/fluentui-apple

Conversation

@nodes11

@nodes11 Des Marks (nodes11) commented Jul 29, 2026 •
edited by microsoft-github-policy-service Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

The exisiting IndeterminateProgressBar only supports showing indeterminate progress and its name reflects that. We need a progress bar that can show both indeterminate and determinate progress.

This change renames to the IndeterminateProgressBar to ProgressBar (MSFProgressBar for Obj-C consumers) and adds a determinate progress mode.

Changes:

  • A bulk rename of IndeterminateProgressBar to ProgressBar. I used Copilot to aid in this process.
  • Added an optional progress property to the MSFProgressBarState (previously MSFIndeterminateProgressBarState), which when non-nil, enables the determinite mode for the progress bar.
  • Added toggle to the demo controller so that both the indeterminate and determinate modes can be tested.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Simulator.Screen.Recording.-.iPad.Pro.13-inch.M5.-.2026-07-29.at.08.24.23.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-07-29.at.08.18.57.mov

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Des Marks (nodes11) added 2 commits July 29, 2026 08:04
@nodes11
Rename IndeterminateProgressBar to ProgressBar, add determinite mode
f438304
@nodes11
Alphabetical order
5c05441
@nodes11
Des Marks (nodes11) requested review from a team as code owners July 29, 2026 15:46
joannaquu
Joanna Qu (joannaquu) reviewed Jul 29, 2026
View reviewed changes
Comment thread Demos/FluentUIDemo_iOS/FluentUI.Demo.xcodeproj/project.pbxproj Resolved

Uh oh!

There was an error while loading. Please reload this page.

joannaquu
Joanna Qu (joannaquu) reviewed Jul 29, 2026
View reviewed changes
Comment thread Sources/FluentUI_iOS/Components/ProgressBar/ProgressBar.swift Resolved

Uh oh!

There was an error while loading. Please reload this page.

joannaquu
Joanna Qu (joannaquu) reviewed Jul 29, 2026
View reviewed changes
Comment thread Sources/FluentUI_iOS/Components/ProgressBar/ProgressBar.swift Resolved

Uh oh!

There was an error while loading. Please reload this page.

joannaquu
Joanna Qu (joannaquu) reviewed Jul 29, 2026
View reviewed changes
Comment thread Sources/FluentUI_iOS/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

joannaquu
Joanna Qu (joannaquu) reviewed Jul 29, 2026
View reviewed changes
Comment thread MicrosoftFluentUI.podspec Resolved

Uh oh!

There was an error while loading. Please reload this page.

Des Marks (nodes11) added 2 commits July 29, 2026 11:33
@nodes11
PR Updates
62b7747
@nodes11
Fix issue where progress bar doesn't extend edge to edge of screen
7857b34
joannaquu
Joanna Qu (joannaquu) approved these changes Jul 30, 2026
View reviewed changes
@joannaquu Joanna Qu (joannaquu) added the API break This PR introduces a breaking API change label Jul 30, 2026
mischreiber
Mike Schreiber (mischreiber) approved these changes Jul 30, 2026
View reviewed changes
@nodes11
Des Marks (nodes11) merged commit d37085f into microsoft:main Jul 30, 2026
7 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@nodes11 Des Marks (nodes11) mentioned this pull request Aug 3, 2026
Bump version to 0.37 #2280
Merged
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischreiber Mike Schreiber (mischreiber) mischreiber approved these changes
@joannaquu Joanna Qu (joannaquu) joannaquu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

API break This PR introduces a breaking API change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nodes11 @mischreiber @joannaquu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.