GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: provide driver with the host-lang version by mxschmitt · Pull Request #1107 · microsoft/playwright-python

Conversation

@mxschmitt

@mxschmitt Max Schmitt (mxschmitt) commented Jan 16, 2022

Copy link
Copy Markdown
Contributor

Fixes #1103

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mxschmitt
Max Schmitt (mxschmitt) force-pushed the driver-version branch from 3a9cba8 to 50521d1 Compare January 17, 2022 22:00
aslushnikov
Andrey Lushnikov (aslushnikov) approved these changes Jan 18, 2022
View reviewed changes

@aslushnikov Andrey Lushnikov (aslushnikov) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % test that the default user agent indeed includes Python + version (see Java for the test example - microsoft/playwright-java#774)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mxschmitt
chore: provide driver with the host-lang version
e08ffc9
@mxschmitt
Max Schmitt (mxschmitt) force-pushed the driver-version branch 2 times, most recently from 824711b to 4935382 Compare January 18, 2022 17:10
@mxschmitt
added test
976b715
@mxschmitt
Max Schmitt (mxschmitt) force-pushed the driver-version branch from 4935382 to 976b715 Compare January 18, 2022 17:12
@mxschmitt
Max Schmitt (mxschmitt) merged commit 4e1113c into microsoft:main Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@aslushnikov Andrey Lushnikov (aslushnikov) aslushnikov approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

internal: setup env variables when launching driver

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mxschmitt @aslushnikov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.