GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: stderr redirect with monkeypatched stderr by mxschmitt · Pull Request #159 · microsoft/playwright-python

Conversation

@mxschmitt

@mxschmitt Max Schmitt (mxschmitt) commented Aug 7, 2020

Copy link
Copy Markdown
Contributor

fixes #158

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mxschmitt
fix: stderr redirect with monkeypatched stderr
78d2b2a
pavelfeldman
Pavel Feldman (pavelfeldman) approved these changes Aug 7, 2020
View reviewed changes
@coveralls

Coveralls (coveralls) commented Aug 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 198452624

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

  • For more information on this, see Tracking coverage changes with pull request builds.
  • To avoid this issue with future PRs, see these Recommended CI Configurations.
  • For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 89.944%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/main.py 4 6 66.67%
Totals Coverage Status
Change from base Build 198064508: -0.03%
Covered Lines: 3676
Relevant Lines: 4087
💛 - Coveralls
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mxschmitt
Max Schmitt (mxschmitt) merged commit 05e48f6 into microsoft:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman Pavel Feldman (pavelfeldman) pavelfeldman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stdout/stderr pipe throws stacktrace if stdout/stderr is mocked by Pytest

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mxschmitt @coveralls @pavelfeldman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.