GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore(roll): roll glob changes from Playwright 1.52.0 by agg23 · Pull Request #2824 · microsoft/playwright-python

Conversation

@agg23

@agg23 Adam Gastineau (agg23) commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Continuation of #2823, addressing the changes is microsoft/playwright#34923 and microsoft/playwright#35136.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mxschmitt reacted with rocket emoji
All reactions
  • 🚀 1 reaction
Adam Gastineau (agg23) added 2 commits April 28, 2025 05:45
@agg23
Initial working implementation of JS's new custom glob
4b6e8d1
@agg23
Added missing interception test
026a158
@agg23
Adam Gastineau (agg23) force-pushed the roll/glob-rewrite branch from 503169e to 026a158 Compare April 28, 2025 12:45
@agg23
Add missing sync test
611d2c1
dgozman
Dmitry Gozman (dgozman) reviewed Apr 28, 2025
View reviewed changes
Comment thread playwright/_impl/_helper.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@agg23
More clearly document strange parsing behavior
9b92509
dgozman
Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes
Comment thread playwright/_impl/_helper.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@agg23
Abstract away non-JS code
aa69aef
dgozman
Dmitry Gozman (dgozman) approved these changes Apr 28, 2025
View reviewed changes
@agg23
Adam Gastineau (agg23) merged commit eec856f into microsoft:main Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman Dmitry Gozman (dgozman) dgozman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@agg23 @dgozman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.