GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: explicit timeout config for send by agg23 · Pull Request #2900 · microsoft/playwright-python

Conversation

@agg23

@agg23 Adam Gastineau (agg23) commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Follow up from #2892. Remove implicit timeout information in server calls and make it explicit and required.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@agg23
Adam Gastineau (agg23) requested a review from Dmitry Gozman (dgozman) June 24, 2025 15:55
Adam Gastineau (agg23) added 2 commits June 24, 2025 11:18
@agg23
chore: explicit timeout config for send
6004e4c
@agg23
Fix timeout not being passed around to certain send() calls
07834ba
@agg23
Adam Gastineau (agg23) force-pushed the explicit-timeout-config branch from 64e12e4 to 07834ba Compare June 24, 2025 18:18
@agg23
Disable none filtering on send_no_reply()
68a832b
agg23
Adam Gastineau (agg23) commented Jun 24, 2025
View reviewed changes
Comment thread playwright/_impl/_connection.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
dgozman
Dmitry Gozman (dgozman) reviewed Jun 24, 2025
View reviewed changes

@dgozman Dmitry Gozman (dgozman) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started to annotate places that now have a timeout, but previously did not, but there are too many. Could you please align with Node.js to avoid behavior changes?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread playwright/_impl/_clock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread playwright/_impl/_connection.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread playwright/_impl/_element_handle.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread playwright/_impl/_fetch.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread playwright/_impl/_fetch.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread playwright/_impl/_frame.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Adam Gastineau (agg23) added 4 commits June 25, 2025 06:23
@agg23
Only set timeouts on necessary protocol calls
535debf
@agg23
Add missing screenshot timeout
23c3792
@agg23
Fix strange connection filtering
ce672f2
@agg23
Collapsed nested filtering
2f6bbf9
dgozman
Dmitry Gozman (dgozman) approved these changes Jun 25, 2025
View reviewed changes
Comment thread playwright/_impl/_connection.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread playwright/_impl/_frame.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@agg23
Remove unnecessary waitForTimeout wrapper
43d771a
dgozman
Dmitry Gozman (dgozman) approved these changes Jun 25, 2025
View reviewed changes
@agg23
Adam Gastineau (agg23) merged commit 3713a32 into microsoft:main Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgozman Dmitry Gozman (dgozman) dgozman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@agg23 @dgozman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.