GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Python: Send the NVIDIA nvext setting in extra_body by codewithfourtix · Pull Request #14698 · microsoft/semantic-kernel

Conversation

@codewithfourtix

@codewithfourtix Ali Zulfiqar (codewithfourtix) commented Oct 31, 2026

Copy link
Copy Markdown

Motivation and Context

NvidiaChatPromptExecutionSettings.nvext is dumped as a top-level argument of chat.completions.create(), so every request that sets it fails:

ServiceResponseException: ... service failed to complete the chat
caused by: TypeError: AsyncCompletions.create() got an unexpected keyword argument 'nvext'

Description

  • prepare_settings_dict() now sends nvext in extra_body, merged with the guided_json that response_format puts there. On a key clash, extra_body["nvext"] wins.
  • Removed the handler's copy of extra_body["nvext"]. model_dump() already includes extra_body, and the copy would overwrite the merged value.
  • Added two regression tests. The existing tests mock create() with a plain AsyncMock, which accepts any keyword, so they could not catch this.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
  • All unit tests pass, and I have added new tests where possible
  • I didn't break anyone 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@codewithfourtix
Python: Send the NVIDIA nvext setting in extra_body
24d10e9 
NvidiaChatPromptExecutionSettings.nvext was dumped as a top-level
argument of chat.completions.create(), which rejects it with a
TypeError, so every request that set nvext failed. Move it into
extra_body and merge it with the guided_json that response_format
puts there, and drop the handler's copy of extra_body["nvext"],
which would overwrite the merged value.
Copilot AI balanced review requested due to automatic review settings October 31, 2026 11:02
@codewithfourtix
Ali Zulfiqar (codewithfourtix) requested a review from a team as a code owner October 31, 2026 11:02
@codewithfourtix
Ali Zulfiqar (codewithfourtix) temporarily deployed to github-app-auth October 31, 2026 11:02 — with GitHub Actions Inactive
Copilot AI reviewed Oct 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@semantic-kernel-automation semantic-kernel-automation Bot added the python Pull requests for the Python Semantic Kernel label Oct 31, 2026
eavanvalkenburg
Eduard van Valkenburg (eavanvalkenburg) approved these changes Nov 2, 2026
View reviewed changes
@eavanvalkenburg
Eduard van Valkenburg (eavanvalkenburg) added this pull request to the merge queue Nov 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 2, 2026

Uh oh!

There was an error while loading. Please reload this page.
@eavanvalkenburg
Eduard van Valkenburg (eavanvalkenburg) added this pull request to the merge queue Nov 4, 2026
Merged via the queue into microsoft:main with commit 703eb5f Nov 4, 2026
34 checks passed

Uh oh!

There was an error while loading. Please reload this page.

This branch was previously deployed

1 inactive deployment
github-app-auth — 24d10e9e Deployed Oct 31, 2026 by codewithfourtix via add_label #29519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@eavanvalkenburg Eduard van Valkenburg (eavanvalkenburg) eavanvalkenburg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

python Pull requests for the Python Semantic Kernel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@codewithfourtix @eavanvalkenburg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.