GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix: Don't ignore the indent settings in advanced wrapping mode by byteit101 · Pull Request #134171 · microsoft/vscode

Conversation

@byteit101

@byteit101 Patrick Plenefisch (byteit101) commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

This PR fixes #132220
and
This PR fixes #120844

This still works in one pass by using negative text-indent with matching
padding to generate a CSS-based hanging indent that we can measure.
This could be upgraded to the hanging modifier in the far future. (No browsers support it at this time)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@byteit101
Don't ignore the indent settings in advanced wrapping mode
4acd587 
Fixes microsoft#132220
Fixes microsoft#120844

This still works in one pass by using negative text-indent with matching
padding to generate a CSS-based hanging indent that we can measure.
This could be upgraded to the `hanging` modifier in the far future.
@ghost

Deleted user (ghost) commented Sep 29, 2021 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@byteit101 Patrick Plenefisch (byteit101) mentioned this pull request Sep 29, 2021
Wrapping & indent broken when used together for non-monospace glyphs (proportional fonts or non-latin chars) #132220
Closed
@vscode-triage-bot VS Code Issue Triage Bot (vscode-triage-bot) assigned Alexandru Dima (alexdima) Sep 29, 2021
@byteit101

Patrick Plenefisch (byteit101) commented Sep 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Text I used to verify this fix (I didn't see any advanced wrapping test file):

W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W

i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i

											This is a normal long line that has normal words on it. No abnormal words here, though maybe that last one could count as one.

		Very wide glyphs:
		𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒈓 𒍼 𒅃 𒌧 𒈓 𒍼

		𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫

		﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽

		Above is U+12143, U+12213, U+1237C, U+12327 (Cuneiform block characters), then U+1242B (CUNEIFORM NUMERIC SIGN NINE SHAR2), then finally U+FDFD (ARABIC LIGATURE BISMILLAH AR-RAHMAN AR-RAHEEM)

Screenshots of correctly wrapping & indenting with this change:

Monospace font (wide non-Latin characters fixed):
mono-advanced

Proportional font (all characters fixed):
sans-advanced
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexdima
Merge remote-tracking branch 'origin/main' into pr/byteit101/134171
3e5ddbf
@alexdima Alexandru Dima (alexdima) added this to the October 2021 milestone Sep 30, 2021
@alexdima Alexandru Dima (alexdima) added the editor-wrapping Editor line wrapping issues label Oct 27, 2021
@alexdima
Merge remote-tracking branch 'origin/main' into pr/byteit101/134171
bc4945e
@alexdima

Alexandru Dima (alexdima) commented Oct 27, 2021

Copy link
Copy Markdown
Member

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexdima
Alexandru Dima (alexdima) merged commit d578207 into microsoft:main Oct 27, 2021
@alexdima Alexandru Dima (alexdima) mentioned this pull request Oct 27, 2021
Wrapping indent ignored with advanced strategy #120844
Closed
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@alexdima Alexandru Dima (alexdima)

Labels

editor-wrapping Editor line wrapping issues

Projects

None yet

Milestone

October 2021

Development

Successfully merging this pull request may close these issues.

Wrapping & indent broken when used together for non-monospace glyphs (proportional fonts or non-latin chars) Wrapping indent ignored with advanced strategy

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@byteit101 @alexdima
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.