GeezerVison

Thanks for creating this! Could you please split out the selection patch so that this PR impacts only search editor code?

Jackson Kearl (@JacksonKearl), thanks for looking. Which part do you want me to split out? I assume you mean to only keep the code to fix one of the two issues in this branch, but I'm not sure which one you want kept in here and which to open a new PR for.

This PR should only have the code changes needed for #135226. I would try to avoid changing src/vs/editor/contrib/gotoSymbol/goToCommands.ts for #128927.

Thanks, Jackson Kearl (@JacksonKearl)! I update it. A far as I can tell, I cannot accomplish #128927 with an extension. If I create a new pull request for that, do you think it could be merged?

Pushed a change to fix an off-by-one on context lines, besides that looks good. Thanks for this!

As for #128927, IMO handling untyped args in the goTo provider for this narrow use case is a bit odd, but I also don't know a better way. The search result editor is a bit of a patchwork of existing editor features, to change the underlying constructs too much for the narrow use case of the search editor doesn't feel great.

Thanks. I was thinking if I could get decorations (#48364) I could write an extension to do this instead, but that's not supported. What if I implement it without the args? I haven't checked yet, but I'm wondering if after calling executeCommand for editor.action.goToDeclaration, I can just set the selection on the new editor.

If you can implement it with changes localized to search editor files I would consider it.

Great. Thank you, Jackson Kearl (@JacksonKearl). I found a way to do that in #136002.