GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Mention dependency of codeDescription on code by dc-mak · Pull Request #830 · microsoft/vscode-languageserver-node

Conversation

@dc-mak

@dc-mak Dhruv Makwana (dc-mak) commented Oct 11, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This was, in retrospect, obvious, but took me a while to figure out.

vscode-languageserver-node/client/src/common/protocolConverter.ts

Lines 269 to 272 in d5b8fbe

function asDiagnostic(diagnostic: ls.Diagnostic): code.Diagnostic {
let result = new ProtocolDiagnostic(asRange(diagnostic.range), diagnostic.message, asDiagnosticSeverity(diagnostic.severity), diagnostic.data);
if (diagnostic.code !== undefined) {
if (ls.CodeDescription.is(diagnostic.codeDescription)) {

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dc-mak
Mention dependency of codeDescription on code
a6a6cad 
This was, in retrospect, obvious, but took me a while to figure out.
https://github.com/microsoft/vscode-languageserver-node/blob/d5b8fbe2b164bfb093734ba54d481da353bb1060/client/src/common/protocolConverter.ts#L271
@dbaeumer
Dirk Bäumer (dbaeumer) merged commit c605d75 into microsoft:main Oct 19, 2021
@dbaeumer Dirk Bäumer (dbaeumer) added the October 2021 label Oct 19, 2021
@dc-mak
Dhruv Makwana (dc-mak) deleted the patch-1 branch October 20, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dc-mak @dbaeumer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.